| Message ID | 20250225033914.18617-1-liuhangbin@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [PATCHv2,net-next] bonding: report duplicate MAC address in all situations | expand |
On 2/25/25 05:39, Hangbin Liu wrote: > Normally, a bond uses the MAC address of the first added slave as the bond’s > MAC address. And the bond will set active slave’s MAC address to bond’s > address if fail_over_mac is set to none (0) or follow (2). > > When the first slave is removed, the bond will still use the removed slave’s > MAC address, which can lead to a duplicate MAC address and potentially cause > issues with the switch. To avoid confusion, let's warn the user in all > situations, including when fail_over_mac is set to 2 or not in active-backup > mode. > > Signed-off-by: Hangbin Liu <liuhangbin@gmail.com> > --- > > v2: add fail_over_mac != BOND_FOM_ACTIVE to condition (Jakub Kicinski) > > --- > drivers/net/bonding/bond_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c > index 7d716e90a84c..7d98fee5a27f 100644 > --- a/drivers/net/bonding/bond_main.c > +++ b/drivers/net/bonding/bond_main.c > @@ -2548,7 +2548,7 @@ static int __bond_release_one(struct net_device *bond_dev, > > RCU_INIT_POINTER(bond->current_arp_slave, NULL); > > - if (!all && (!bond->params.fail_over_mac || > + if (!all && (bond->params.fail_over_mac != BOND_FOM_ACTIVE || > BOND_MODE(bond) != BOND_MODE_ACTIVEBACKUP)) { > if (ether_addr_equal_64bits(bond_dev->dev_addr, slave->perm_hwaddr) && > bond_has_slaves(bond)) LGTM, Reviewed-by: Nikolay Aleksandrov <razor@blackwall.org>
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c index 7d716e90a84c..7d98fee5a27f 100644 --- a/drivers/net/bonding/bond_main.c +++ b/drivers/net/bonding/bond_main.c @@ -2548,7 +2548,7 @@ static int __bond_release_one(struct net_device *bond_dev, RCU_INIT_POINTER(bond->current_arp_slave, NULL); - if (!all && (!bond->params.fail_over_mac || + if (!all && (bond->params.fail_over_mac != BOND_FOM_ACTIVE || BOND_MODE(bond) != BOND_MODE_ACTIVEBACKUP)) { if (ether_addr_equal_64bits(bond_dev->dev_addr, slave->perm_hwaddr) && bond_has_slaves(bond))
Normally, a bond uses the MAC address of the first added slave as the bond’s MAC address. And the bond will set active slave’s MAC address to bond’s address if fail_over_mac is set to none (0) or follow (2). When the first slave is removed, the bond will still use the removed slave’s MAC address, which can lead to a duplicate MAC address and potentially cause issues with the switch. To avoid confusion, let's warn the user in all situations, including when fail_over_mac is set to 2 or not in active-backup mode. Signed-off-by: Hangbin Liu <liuhangbin@gmail.com> --- v2: add fail_over_mac != BOND_FOM_ACTIVE to condition (Jakub Kicinski) --- drivers/net/bonding/bond_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)