Message ID | 20250224090052.260495-1-Adithya.Balakumar@toshiba-tsip.com (mailing list archive) |
---|---|
Headers | show |
Series | Test reproducibility of wic images | expand |
On 24.02.25 10:00, Adithya.Balakumar@toshiba-tsip.com wrote: > From: Adithya Balakumar <Adithya.Balakumar@toshiba-tsip.com> > > Currently only the individual partition images are checked in the > reproducibility test. This patch set tests reproducibility of entire > disk image too. > Are we now testing both, partitions and full images? Or are we rather moving from partition testing to image testing with these patches? Jan > Adithya Balakumar (2): > .reproducible-check-ci.yml: Upload wic files for reproducibility test > scripts/repro-tests.sh: Update script to check wic file > reproducibility > > .reproducible-check-ci.yml | 10 ++++- > scripts/repro-tests.sh | 92 +++++++++++++++++++++++++------------- > 2 files changed, 68 insertions(+), 34 deletions(-) >
Hi, >Are we now testing both, partitions and full images? Or are we rather >moving from partition testing to image testing with these patches? I would say the higher priority is to check if the full images are reproducible (As those are the artifacts often released/used). I retained the partition wise check (if the full image are not reproducible) just as way of quick debugging to see in which partition the reproducible issue lies (if one exists). And also running a diffoscope scan on a complete image has problems like I mentioned in the patch If you prefer to keep things simple, we can just full do the repro-test on full images and drop the partition wise check entirely. Thanks and Regards, Adithya Balakumar
On 25.02.25 11:03, Adithya.Balakumar@toshiba-tsip.com wrote: > Hi, > >> Are we now testing both, partitions and full images? Or are we rather >> moving from partition testing to image testing with these patches? > > I would say the higher priority is to check if the full images are reproducible (As those are the artifacts often released/used). > > I retained the partition wise check (if the full image are not reproducible) just as way of quick debugging to see in which partition the reproducible issue lies (if one exists). And also running a diffoscope scan on a complete image has problems like I mentioned in the patch > > If you prefer to keep things simple, we can just full do the repro-test on full images and drop the partition wise check entirely. I just want to avoid that we are doing both unconditional. If the part check depends on a failed fast image check, that is fine. Jan > > Thanks and Regards, > Adithya Balakumar > ________________________________________ > From: cip-dev@lists.cip-project.org <cip-dev@lists.cip-project.org> on behalf of Jan Kiszka via lists.cip-project.org <jan.kiszka=siemens.com@lists.cip-project.org> > Sent: Tuesday, February 25, 2025 3:20 PM > To: balakumar adithya(TSIP DITC_DIT-OST); cip-dev@lists.cip-project.org > Cc: kunijadar shivanand(TSIP DITC_DIT-OST); ashrith sai(TSIP DITC_DIT-OST); dinesh kumar(TSIP DITC_DIT-OST); hayashi kazuhiro(林 和宏 DME ○DIG□MPS○MP4) > Subject: Re: [cip-dev] [isar-cip-core][PATCH v1 0/2] Test reproducibility of wic images > > On 24.02.25 10:00, Adithya.Balakumar@toshiba-tsip.com wrote: >> From: Adithya Balakumar <Adithya.Balakumar@toshiba-tsip.com> >> >> Currently only the individual partition images are checked in the >> reproducibility test. This patch set tests reproducibility of entire >> disk image too. >> > > Are we now testing both, partitions and full images? Or are we rather > moving from partition testing to image testing with these patches? > > Jan > >> Adithya Balakumar (2): >> .reproducible-check-ci.yml: Upload wic files for reproducibility test >> scripts/repro-tests.sh: Update script to check wic file >> reproducibility >> >> .reproducible-check-ci.yml | 10 ++++- >> scripts/repro-tests.sh | 92 +++++++++++++++++++++++++------------- >> 2 files changed, 68 insertions(+), 34 deletions(-) >> > > -- > Siemens AG, Foundational Technologies > Linux Expert Center >
From: Adithya Balakumar <Adithya.Balakumar@toshiba-tsip.com> Currently only the individual partition images are checked in the reproducibility test. This patch set tests reproducibility of entire disk image too. Adithya Balakumar (2): .reproducible-check-ci.yml: Upload wic files for reproducibility test scripts/repro-tests.sh: Update script to check wic file reproducibility .reproducible-check-ci.yml | 10 ++++- scripts/repro-tests.sh | 92 +++++++++++++++++++++++++------------- 2 files changed, 68 insertions(+), 34 deletions(-)