| Message ID | 20250225120707.2658709-1-m.felsch@pengutronix.de (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [1/3] arm64: dts: imx8mn: fix micfil dmas settings | expand |
On Tue, Feb 25, 2025 at 2:12 PM Marco Felsch <m.felsch@pengutronix.de> wrote: > > The third dma cell is used for priority information not to encode > something else. The NXP downstream kernel use the third cell to encode > more information: > > - Bit31: sw_done feature enable/disable > - Bit15~Bit8: selector > - Bit7~Bit0: priority level > > but this was never mainlined. Therefore drop the further information and > just specify the priority which is 0. > > FTR: The sw_done feature was mainlined without making use of the > devicetree. > > Fixes: cca69ef6eba5 ("arm64: dts: imx8mn: Add support for micfil") > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> For all series: Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com> Marco I couldn't find the cover letter for this series so I add my R-b tag here.
diff --git a/arch/arm64/boot/dts/freescale/imx8mn.dtsi b/arch/arm64/boot/dts/freescale/imx8mn.dtsi index a5f9cfb46e5d..8ab4af78acb5 100644 --- a/arch/arm64/boot/dts/freescale/imx8mn.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8mn.dtsi @@ -369,7 +369,7 @@ micfil: audio-controller@30080000 { <&clk IMX8MN_CLK_EXT3>; clock-names = "ipg_clk", "ipg_clk_app", "pll8k", "pll11k", "clkext3"; - dmas = <&sdma2 24 25 0x80000000>; + dmas = <&sdma2 24 25 0>; dma-names = "rx"; #sound-dai-cells = <0>; status = "disabled";
The third dma cell is used for priority information not to encode something else. The NXP downstream kernel use the third cell to encode more information: - Bit31: sw_done feature enable/disable - Bit15~Bit8: selector - Bit7~Bit0: priority level but this was never mainlined. Therefore drop the further information and just specify the priority which is 0. FTR: The sw_done feature was mainlined without making use of the devicetree. Fixes: cca69ef6eba5 ("arm64: dts: imx8mn: Add support for micfil") Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> --- arch/arm64/boot/dts/freescale/imx8mn.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)