Message ID | 20250217-adpdrm-v7-0-ca2e44b3c7d8@gmail.com (mailing list archive) |
---|---|
Headers | show |
Series | Driver for pre-DCP apple display controller. | expand |
Hi, On Mon, 17 Feb 2025 12:39:30 +0100, Sasha Finkelstein wrote: > This patch series adds support for a secondary display controller > present on Apple M1/M2 chips and used to drive the display of the > "touchbar" touch panel present on those. > > Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-next) [3/5] drm: panel: Add a panel driver for the Summit display https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/40115947b59f2ca361a47615304dff0a2b69a2b4
On Tue, 25 Feb 2025 at 12:25, Neil Armstrong <neil.armstrong@linaro.org> wrote: > > Hi, > > On Mon, 17 Feb 2025 12:39:30 +0100, Sasha Finkelstein wrote: > > This patch series adds support for a secondary display controller > > present on Apple M1/M2 chips and used to drive the display of the > > "touchbar" touch panel present on those. > > > > > > Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-next) > > [3/5] drm: panel: Add a panel driver for the Summit display > https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/40115947b59f2ca361a47615304dff0a2b69a2b4 Without the bindings?!
On 25/02/2025 12:37, Dmitry Baryshkov wrote: > On Tue, 25 Feb 2025 at 12:25, Neil Armstrong <neil.armstrong@linaro.org> wrote: >> >> Hi, >> >> On Mon, 17 Feb 2025 12:39:30 +0100, Sasha Finkelstein wrote: >>> This patch series adds support for a secondary display controller >>> present on Apple M1/M2 chips and used to drive the display of the >>> "touchbar" touch panel present on those. >>> >>> >> >> Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-next) >> >> [3/5] drm: panel: Add a panel driver for the Summit display >> https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/40115947b59f2ca361a47615304dff0a2b69a2b4 > > Without the bindings?! > Bindings will be funneled with the rest of the ADP driver, the panel driver can be applied individually. Neil
On Tue, 25 Feb 2025 at 19:59, Neil Armstrong <neil.armstrong@linaro.org> wrote: > > On 25/02/2025 12:37, Dmitry Baryshkov wrote: > > On Tue, 25 Feb 2025 at 12:25, Neil Armstrong <neil.armstrong@linaro.org> wrote: > >> > >> Hi, > >> > >> On Mon, 17 Feb 2025 12:39:30 +0100, Sasha Finkelstein wrote: > >>> This patch series adds support for a secondary display controller > >>> present on Apple M1/M2 chips and used to drive the display of the > >>> "touchbar" touch panel present on those. > >>> > >>> > >> > >> Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-next) > >> > >> [3/5] drm: panel: Add a panel driver for the Summit display > >> https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/40115947b59f2ca361a47615304dff0a2b69a2b4 > > > > Without the bindings?! > > > > Bindings will be funneled with the rest of the ADP driver, the panel driver can be applied individually. Okay.....
On Tue, Feb 25, 2025 at 11:59 AM Neil Armstrong <neil.armstrong@linaro.org> wrote: > > On 25/02/2025 12:37, Dmitry Baryshkov wrote: > > On Tue, 25 Feb 2025 at 12:25, Neil Armstrong <neil.armstrong@linaro.org> wrote: > >> > >> Hi, > >> > >> On Mon, 17 Feb 2025 12:39:30 +0100, Sasha Finkelstein wrote: > >>> This patch series adds support for a secondary display controller > >>> present on Apple M1/M2 chips and used to drive the display of the > >>> "touchbar" touch panel present on those. > >>> > >>> > >> > >> Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-next) > >> > >> [3/5] drm: panel: Add a panel driver for the Summit display > >> https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/40115947b59f2ca361a47615304dff0a2b69a2b4 > > > > Without the bindings?! > > > > Bindings will be funneled with the rest of the ADP driver, the panel driver can be applied individually. Uh, no. The bindings go with the user. Now 'make dt_compatible_check' reports apple,summit is not documented. Rob
Hi, On 17/02/2025 12:39, Sasha Finkelstein via B4 Relay wrote: > Hi. > > This patch series adds support for a secondary display controller > present on Apple M1/M2 chips and used to drive the display of the > "touchbar" touch panel present on those. > > Signed-off-by: Sasha Finkelstein <fnkl.kernel@gmail.com> > --- > Changes in v7: > - No changes aside from adding r-b trailers, effectively a resend. > - Link to v6: https://lore.kernel.org/r/20250206-adpdrm-v6-0-c8ab9348b853@gmail.com > > Changes in v6: > - Use the drm_connector_helper_get_modes_fixed helper. > - Split out into a separate MAINTAINERS entry > - Link to v5: https://lore.kernel.org/r/20250205-adpdrm-v5-0-4e4ec979bbf2@gmail.com > > Changes in v5: > - Moved to using the component framework. > - Other lifetime fixes > - Link to v4: https://lore.kernel.org/r/20250114-adpdrm-v4-0-e9b5260a39f1@gmail.com > > Changes in v4: > - Fixed dt bindings. > - Link to v3: https://lore.kernel.org/r/20250112-adpdrm-v3-0-c674dc19fa7f@gmail.com > > Changes in v3: > - Fixed building as module after splitting out mipi block > - Addressing the review feedback. > - Link to v2: https://lore.kernel.org/r/20241126-adpdrm-v2-0-c90485336c09@gmail.com > > Changes in v2: > - Addressing the review feedback. > - Split out the mipi part of the display controller into a separate device > - Link to v1: https://lore.kernel.org/r/20241124-adpdrm-v1-0-3191d8e6e49a@gmail.com > > --- > Sasha Finkelstein (5): > dt-bindings: display: Add Apple pre-DCP display controller > drm: adp: Add Apple Display Pipe driver > drm: panel: Add a panel driver for the Summit display > arm64: dts: apple: Add touchbar screen nodes > MAINTAINERS: Add entries for touchbar display driver > > .../display/apple,h7-display-pipe-mipi.yaml | 83 +++ > .../bindings/display/apple,h7-display-pipe.yaml | 88 +++ > .../bindings/display/panel/apple,summit.yaml | 58 ++ > MAINTAINERS | 16 + > arch/arm64/boot/dts/apple/t8103-j293.dts | 31 ++ > arch/arm64/boot/dts/apple/t8103.dtsi | 61 ++ > arch/arm64/boot/dts/apple/t8112-j493.dts | 31 ++ > arch/arm64/boot/dts/apple/t8112.dtsi | 61 ++ > drivers/gpu/drm/Kconfig | 2 + > drivers/gpu/drm/Makefile | 1 + > drivers/gpu/drm/adp/Kconfig | 17 + > drivers/gpu/drm/adp/Makefile | 5 + > drivers/gpu/drm/adp/adp-mipi.c | 276 +++++++++ > drivers/gpu/drm/adp/adp_drv.c | 617 +++++++++++++++++++++ > drivers/gpu/drm/panel/Kconfig | 9 + > drivers/gpu/drm/panel/Makefile | 1 + > drivers/gpu/drm/panel/panel-summit.c | 132 +++++ > 17 files changed, 1489 insertions(+) > --- > base-commit: b62cef9a5c673f1b8083159f5dc03c1c5daced2f > change-id: 20241124-adpdrm-25fce3dd8a71 > > All patches are reviewed, can we funnel patches 1, 2 & 5 via drm-misc-next now ? Neil
> > Sasha Finkelstein (5): > > dt-bindings: display: Add Apple pre-DCP display controller > > drm: adp: Add Apple Display Pipe driver > > drm: panel: Add a panel driver for the Summit display > > arm64: dts: apple: Add touchbar screen nodes > > MAINTAINERS: Add entries for touchbar display driver > > > > .../display/apple,h7-display-pipe-mipi.yaml | 83 +++ > > .../bindings/display/apple,h7-display-pipe.yaml | 88 +++ > > .../bindings/display/panel/apple,summit.yaml | 58 ++ > > MAINTAINERS | 16 + > > arch/arm64/boot/dts/apple/t8103-j293.dts | 31 ++ > > arch/arm64/boot/dts/apple/t8103.dtsi | 61 ++ > > arch/arm64/boot/dts/apple/t8112-j493.dts | 31 ++ > > arch/arm64/boot/dts/apple/t8112.dtsi | 61 ++ > > drivers/gpu/drm/Kconfig | 2 + > > drivers/gpu/drm/Makefile | 1 + > > drivers/gpu/drm/adp/Kconfig | 17 + > > drivers/gpu/drm/adp/Makefile | 5 + > > drivers/gpu/drm/adp/adp-mipi.c | 276 +++++++++ > > drivers/gpu/drm/adp/adp_drv.c | 617 +++++++++++++++++++++ > > drivers/gpu/drm/panel/Kconfig | 9 + > > drivers/gpu/drm/panel/Makefile | 1 + > > drivers/gpu/drm/panel/panel-summit.c | 132 +++++ > > 17 files changed, 1489 insertions(+) > > --- > > base-commit: b62cef9a5c673f1b8083159f5dc03c1c5daced2f > > change-id: 20241124-adpdrm-25fce3dd8a71 > > > > > > All patches are reviewed, can we funnel patches 1, 2 & 5 via drm-misc-next now ? I'm planning to do so today, just need to get dim setup first :)
On 03/03/2025 17:43, Alyssa Rosenzweig wrote: >>> Sasha Finkelstein (5): >>> dt-bindings: display: Add Apple pre-DCP display controller >>> drm: adp: Add Apple Display Pipe driver >>> drm: panel: Add a panel driver for the Summit display >>> arm64: dts: apple: Add touchbar screen nodes >>> MAINTAINERS: Add entries for touchbar display driver >>> >>> .../display/apple,h7-display-pipe-mipi.yaml | 83 +++ >>> .../bindings/display/apple,h7-display-pipe.yaml | 88 +++ >>> .../bindings/display/panel/apple,summit.yaml | 58 ++ >>> MAINTAINERS | 16 + >>> arch/arm64/boot/dts/apple/t8103-j293.dts | 31 ++ >>> arch/arm64/boot/dts/apple/t8103.dtsi | 61 ++ >>> arch/arm64/boot/dts/apple/t8112-j493.dts | 31 ++ >>> arch/arm64/boot/dts/apple/t8112.dtsi | 61 ++ >>> drivers/gpu/drm/Kconfig | 2 + >>> drivers/gpu/drm/Makefile | 1 + >>> drivers/gpu/drm/adp/Kconfig | 17 + >>> drivers/gpu/drm/adp/Makefile | 5 + >>> drivers/gpu/drm/adp/adp-mipi.c | 276 +++++++++ >>> drivers/gpu/drm/adp/adp_drv.c | 617 +++++++++++++++++++++ >>> drivers/gpu/drm/panel/Kconfig | 9 + >>> drivers/gpu/drm/panel/Makefile | 1 + >>> drivers/gpu/drm/panel/panel-summit.c | 132 +++++ >>> 17 files changed, 1489 insertions(+) >>> --- >>> base-commit: b62cef9a5c673f1b8083159f5dc03c1c5daced2f >>> change-id: 20241124-adpdrm-25fce3dd8a71 >>> >>> >> >> All patches are reviewed, can we funnel patches 1, 2 & 5 via drm-misc-next now ? > > I'm planning to do so today, just need to get dim setup first :) Nice, go ahead then ! Neil
On Mon, 17 Feb 2025 12:39:30 +0100, Sasha Finkelstein wrote: > This patch series adds support for a secondary display controller > present on Apple M1/M2 chips and used to drive the display of the > "touchbar" touch panel present on those. > > Since the dt-bindings are now part of drm-misc-next I've also applied the dts change, thanks! [4/5] arm64: dts: apple: Add touchbar screen nodes commit: 7275e795e520c7064af52ba67c74d7bac27eea4f Best regards,
On Mon, Mar 03, 2025 at 11:43:11AM -0500, Alyssa Rosenzweig wrote: > > > Sasha Finkelstein (5): > > > dt-bindings: display: Add Apple pre-DCP display controller > > > drm: adp: Add Apple Display Pipe driver > > > drm: panel: Add a panel driver for the Summit display > > > arm64: dts: apple: Add touchbar screen nodes > > > MAINTAINERS: Add entries for touchbar display driver > > > > > > .../display/apple,h7-display-pipe-mipi.yaml | 83 +++ > > > .../bindings/display/apple,h7-display-pipe.yaml | 88 +++ > > > .../bindings/display/panel/apple,summit.yaml | 58 ++ > > > MAINTAINERS | 16 + > > > arch/arm64/boot/dts/apple/t8103-j293.dts | 31 ++ > > > arch/arm64/boot/dts/apple/t8103.dtsi | 61 ++ > > > arch/arm64/boot/dts/apple/t8112-j493.dts | 31 ++ > > > arch/arm64/boot/dts/apple/t8112.dtsi | 61 ++ > > > drivers/gpu/drm/Kconfig | 2 + > > > drivers/gpu/drm/Makefile | 1 + > > > drivers/gpu/drm/adp/Kconfig | 17 + > > > drivers/gpu/drm/adp/Makefile | 5 + > > > drivers/gpu/drm/adp/adp-mipi.c | 276 +++++++++ > > > drivers/gpu/drm/adp/adp_drv.c | 617 +++++++++++++++++++++ > > > drivers/gpu/drm/panel/Kconfig | 9 + > > > drivers/gpu/drm/panel/Makefile | 1 + > > > drivers/gpu/drm/panel/panel-summit.c | 132 +++++ > > > 17 files changed, 1489 insertions(+) > > > --- > > > base-commit: b62cef9a5c673f1b8083159f5dc03c1c5daced2f > > > change-id: 20241124-adpdrm-25fce3dd8a71 > > > > > > > > > > All patches are reviewed, can we funnel patches 1, 2 & 5 via drm-misc-next now ? > > I'm planning to do so today, just need to get dim setup first :) Nice! As a heads up, it would be really-really nice if you can send any kind of 'applied' message. If you are using 'dim b4-shazam', then 'b4 ty -a' might do that for you. Otherwise just a simple 'hey, applied' email is useful enough.
> > > All patches are reviewed, can we funnel patches 1, 2 & 5 via drm-misc-next now ? > > > > I'm planning to do so today, just need to get dim setup first :) > > Nice! As a heads up, it would be really-really nice if you can send any > kind of 'applied' message. If you are using 'dim b4-shazam', then > 'b4 ty -a' might do that for you. Otherwise just a simple 'hey, applied' > email is useful enough. Oh cool, it didn't occur to me that `b4 ty` would compose with `dim b4-shazam`. Sent a very belated message and will try to make a habit of it going forward. Thanks for the tip! Cheers, Alyssa
Hi. This patch series adds support for a secondary display controller present on Apple M1/M2 chips and used to drive the display of the "touchbar" touch panel present on those. Signed-off-by: Sasha Finkelstein <fnkl.kernel@gmail.com> --- Changes in v7: - No changes aside from adding r-b trailers, effectively a resend. - Link to v6: https://lore.kernel.org/r/20250206-adpdrm-v6-0-c8ab9348b853@gmail.com Changes in v6: - Use the drm_connector_helper_get_modes_fixed helper. - Split out into a separate MAINTAINERS entry - Link to v5: https://lore.kernel.org/r/20250205-adpdrm-v5-0-4e4ec979bbf2@gmail.com Changes in v5: - Moved to using the component framework. - Other lifetime fixes - Link to v4: https://lore.kernel.org/r/20250114-adpdrm-v4-0-e9b5260a39f1@gmail.com Changes in v4: - Fixed dt bindings. - Link to v3: https://lore.kernel.org/r/20250112-adpdrm-v3-0-c674dc19fa7f@gmail.com Changes in v3: - Fixed building as module after splitting out mipi block - Addressing the review feedback. - Link to v2: https://lore.kernel.org/r/20241126-adpdrm-v2-0-c90485336c09@gmail.com Changes in v2: - Addressing the review feedback. - Split out the mipi part of the display controller into a separate device - Link to v1: https://lore.kernel.org/r/20241124-adpdrm-v1-0-3191d8e6e49a@gmail.com --- Sasha Finkelstein (5): dt-bindings: display: Add Apple pre-DCP display controller drm: adp: Add Apple Display Pipe driver drm: panel: Add a panel driver for the Summit display arm64: dts: apple: Add touchbar screen nodes MAINTAINERS: Add entries for touchbar display driver .../display/apple,h7-display-pipe-mipi.yaml | 83 +++ .../bindings/display/apple,h7-display-pipe.yaml | 88 +++ .../bindings/display/panel/apple,summit.yaml | 58 ++ MAINTAINERS | 16 + arch/arm64/boot/dts/apple/t8103-j293.dts | 31 ++ arch/arm64/boot/dts/apple/t8103.dtsi | 61 ++ arch/arm64/boot/dts/apple/t8112-j493.dts | 31 ++ arch/arm64/boot/dts/apple/t8112.dtsi | 61 ++ drivers/gpu/drm/Kconfig | 2 + drivers/gpu/drm/Makefile | 1 + drivers/gpu/drm/adp/Kconfig | 17 + drivers/gpu/drm/adp/Makefile | 5 + drivers/gpu/drm/adp/adp-mipi.c | 276 +++++++++ drivers/gpu/drm/adp/adp_drv.c | 617 +++++++++++++++++++++ drivers/gpu/drm/panel/Kconfig | 9 + drivers/gpu/drm/panel/Makefile | 1 + drivers/gpu/drm/panel/panel-summit.c | 132 +++++ 17 files changed, 1489 insertions(+) --- base-commit: b62cef9a5c673f1b8083159f5dc03c1c5daced2f change-id: 20241124-adpdrm-25fce3dd8a71