diff mbox series

[v10,6/6] arm64: defconfig: Enable Synopsys HDMI receiver

Message ID 20250225183058.607047-7-dmitry.osipenko@collabora.com (mailing list archive)
State New
Headers show
Series Add Synopsys DesignWare HDMI RX Controller | expand

Commit Message

Dmitry Osipenko Feb. 25, 2025, 6:30 p.m. UTC 
From: Sebastian Reichel <sebastian.reichel@collabora.com>

The Rockchip RK3588 has a built-in HDMI receiver block from
Synopsys. Let's enable the driver for it.

Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
---
 arch/arm64/configs/defconfig | 2 ++
 1 file changed, 2 insertions(+)

Comments

Hans Verkuil Feb. 26, 2025, 8:31 a.m. UTC | #1 
On 25/02/2025 19:30, Dmitry Osipenko wrote:
> From: Sebastian Reichel <sebastian.reichel@collabora.com>
> 
> The Rockchip RK3588 has a built-in HDMI receiver block from
> Synopsys. Let's enable the driver for it.
> 
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
> Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
> ---
>  arch/arm64/configs/defconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index cb7da4415599..3dccc9e1c4aa 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -859,6 +859,8 @@ CONFIG_VIDEO_SAMSUNG_EXYNOS_GSC=m
>  CONFIG_VIDEO_SAMSUNG_S5P_JPEG=m
>  CONFIG_VIDEO_SAMSUNG_S5P_MFC=m
>  CONFIG_VIDEO_SUN6I_CSI=m
> +CONFIG_VIDEO_SYNOPSYS_HDMIRX=m
> +CONFIG_VIDEO_SYNOPSYS_HDMIRX_LOAD_DEFAULT_EDID=y

I do not believe it is a good idea to default to y for this option.

The EDID depends on the specific device you make, and you should
think carefully about whether the default EDID fits the needs of the
device.

So if you want the default EDID, then you should manually select it
and not have it autoselected.

Regards,

	Hans

>  CONFIG_VIDEO_TI_J721E_CSI2RX=m
>  CONFIG_VIDEO_HANTRO=m
>  CONFIG_VIDEO_IMX219=m
Dmitry Osipenko Feb. 26, 2025, 9:24 a.m. UTC | #2 
On 2/26/25 11:31, Hans Verkuil wrote:
> On 25/02/2025 19:30, Dmitry Osipenko wrote:
>> From: Sebastian Reichel <sebastian.reichel@collabora.com>
>>
>> The Rockchip RK3588 has a built-in HDMI receiver block from
>> Synopsys. Let's enable the driver for it.
>>
>> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
>> Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
>> ---
>>  arch/arm64/configs/defconfig | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
>> index cb7da4415599..3dccc9e1c4aa 100644
>> --- a/arch/arm64/configs/defconfig
>> +++ b/arch/arm64/configs/defconfig
>> @@ -859,6 +859,8 @@ CONFIG_VIDEO_SAMSUNG_EXYNOS_GSC=m
>>  CONFIG_VIDEO_SAMSUNG_S5P_JPEG=m
>>  CONFIG_VIDEO_SAMSUNG_S5P_MFC=m
>>  CONFIG_VIDEO_SUN6I_CSI=m
>> +CONFIG_VIDEO_SYNOPSYS_HDMIRX=m
>> +CONFIG_VIDEO_SYNOPSYS_HDMIRX_LOAD_DEFAULT_EDID=y
> 
> I do not believe it is a good idea to default to y for this option.
> 
> The EDID depends on the specific device you make, and you should
> think carefully about whether the default EDID fits the needs of the
> device.
> 
> So if you want the default EDID, then you should manually select it
> and not have it autoselected.

Ack
diff mbox series

Patch

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index cb7da4415599..3dccc9e1c4aa 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -859,6 +859,8 @@  CONFIG_VIDEO_SAMSUNG_EXYNOS_GSC=m
 CONFIG_VIDEO_SAMSUNG_S5P_JPEG=m
 CONFIG_VIDEO_SAMSUNG_S5P_MFC=m
 CONFIG_VIDEO_SUN6I_CSI=m
+CONFIG_VIDEO_SYNOPSYS_HDMIRX=m
+CONFIG_VIDEO_SYNOPSYS_HDMIRX_LOAD_DEFAULT_EDID=y
 CONFIG_VIDEO_TI_J721E_CSI2RX=m
 CONFIG_VIDEO_HANTRO=m
 CONFIG_VIDEO_IMX219=m