diff mbox series

[v2,2/6] dt-bindings: arm: add CIX P1 (SKY1) SoC

Message ID 20250226012136.854614-3-peter.chen@cixtech.com (mailing list archive)
State New
Headers show
Series arm64: Introduce CIX P1 (SKY1) SoC | expand

Commit Message

Peter Chen Feb. 26, 2025, 1:21 a.m. UTC
Add device tree bindings for CIX P1 (Internal name sky1) Arm SoC,
it consists several SoC models like CP8180, CD8180, etc.

Acked-by: Fugang Duan <fugang.duan@cixtech.com>
Signed-off-by: Peter Chen <peter.chen@cixtech.com>
---
 .../devicetree/bindings/arm/cix.yaml          | 26 +++++++++++++++++++
 1 file changed, 26 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/arm/cix.yaml

Comments

Krzysztof Kozlowski Feb. 26, 2025, 7:02 a.m. UTC | #1
On 26/02/2025 02:21, Peter Chen wrote:
> Add device tree bindings for CIX P1 (Internal name sky1) Arm SoC,
> it consists several SoC models like CP8180, CD8180, etc.
> 
> Acked-by: Fugang Duan <fugang.duan@cixtech.com>
> Signed-off-by: Peter Chen <peter.chen@cixtech.com>
> ---

<form letter>
This is a friendly reminder during the review process.

It looks like you received a tag and forgot to add it.

If you do not know the process, here is a short explanation:
Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions
of patchset, under or above your Signed-off-by tag, unless patch changed
significantly (e.g. new properties added to the DT bindings). Tag is
"received", when provided in a message replied to you on the mailing
list. Tools like b4 can help here. However, there's no need to repost
patches *only* to add the tags. The upstream maintainer will do that for
tags received on the version they apply.

Please read:
https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577

If a tag was not added on purpose, please state why and what changed.
</form letter>

Best regards,
Krzysztof
Peter Chen Feb. 26, 2025, 8:09 a.m. UTC | #2
On 25-02-26 08:02:12, Krzysztof Kozlowski wrote:
> EXTERNAL EMAIL
> 
> On 26/02/2025 02:21, Peter Chen wrote:
> > Add device tree bindings for CIX P1 (Internal name sky1) Arm SoC,
> > it consists several SoC models like CP8180, CD8180, etc.
> >
> > Acked-by: Fugang Duan <fugang.duan@cixtech.com>
> > Signed-off-by: Peter Chen <peter.chen@cixtech.com>
> > ---
> 
> <form letter>
> This is a friendly reminder during the review process.
> 
> It looks like you received a tag and forgot to add it.
> 
> If you do not know the process, here is a short explanation:
> Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions
> of patchset, under or above your Signed-off-by tag, unless patch changed
> significantly (e.g. new properties added to the DT bindings). Tag is
> "received", when provided in a message replied to you on the mailing
> list. Tools like b4 can help here. However, there's no need to repost
> patches *only* to add the tags. The upstream maintainer will do that for
> tags received on the version they apply.
> 
> Please read:
> https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577
> 
> If a tag was not added on purpose, please state why and what changed.
> </form letter>
> 

I have checked the review-process again at:
https://patchwork.kernel.org/project/linux-arm-kernel/list/?series=935897
It seems no one gives any Reviewed-by or Acked-by Tag.

If I am missing something, please correct me.
Krzysztof Kozlowski Feb. 26, 2025, 8:40 a.m. UTC | #3
On 26/02/2025 09:09, Peter Chen wrote:
> On 25-02-26 08:02:12, Krzysztof Kozlowski wrote:
>> EXTERNAL EMAIL
>>
>> On 26/02/2025 02:21, Peter Chen wrote:
>>> Add device tree bindings for CIX P1 (Internal name sky1) Arm SoC,
>>> it consists several SoC models like CP8180, CD8180, etc.
>>>
>>> Acked-by: Fugang Duan <fugang.duan@cixtech.com>
>>> Signed-off-by: Peter Chen <peter.chen@cixtech.com>
>>> ---
>>
>> <form letter>
>> This is a friendly reminder during the review process.
>>
>> It looks like you received a tag and forgot to add it.
>>
>> If you do not know the process, here is a short explanation:
>> Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions
>> of patchset, under or above your Signed-off-by tag, unless patch changed
>> significantly (e.g. new properties added to the DT bindings). Tag is
>> "received", when provided in a message replied to you on the mailing
>> list. Tools like b4 can help here. However, there's no need to repost
>> patches *only* to add the tags. The upstream maintainer will do that for
>> tags received on the version they apply.
>>
>> Please read:
>> https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577
>>
>> If a tag was not added on purpose, please state why and what changed.
>> </form letter>
>>
> 
> I have checked the review-process again at:
> https://patchwork.kernel.org/project/linux-arm-kernel/list/?series=935897

This does not matter - that's not a patchwork anyone uses...

> It seems no one gives any Reviewed-by or Acked-by Tag.

You were directly addressed! So you got email and what did you do with it?

And lists received it:
https://lore.kernel.org/all/ac6c4a8b-a6bd-44a9-993b-3b743a172dcc@kernel.org/

> 
> If I am missing something, please correct me.
> 


Best regards,
Krzysztof
Peter Chen Feb. 26, 2025, 10:26 a.m. UTC | #4
On 25-02-26 09:40:06, Krzysztof Kozlowski wrote:
> >>
> >> On 26/02/2025 02:21, Peter Chen wrote:
> >>> Add device tree bindings for CIX P1 (Internal name sky1) Arm SoC,
> >>> it consists several SoC models like CP8180, CD8180, etc.
> >>>
> >>> Acked-by: Fugang Duan <fugang.duan@cixtech.com>
> >>> Signed-off-by: Peter Chen <peter.chen@cixtech.com>
> >>> ---
> >>
> >> <form letter>
> >> This is a friendly reminder during the review process.
> >>
> >> It looks like you received a tag and forgot to add it.
> >>
> >> If you do not know the process, here is a short explanation:
> >> Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions
> >> of patchset, under or above your Signed-off-by tag, unless patch changed
> >> significantly (e.g. new properties added to the DT bindings). Tag is
> >> "received", when provided in a message replied to you on the mailing
> >> list. Tools like b4 can help here. However, there's no need to repost
> >> patches *only* to add the tags. The upstream maintainer will do that for
> >> tags received on the version they apply.
> >>
> >> Please read:
> >> https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577
> >>
> >> If a tag was not added on purpose, please state why and what changed.
> >> </form letter>
> >>
> >
> > I have checked the review-process again at:
> > https://patchwork.kernel.org/project/linux-arm-kernel/list/?series=935897
> 
> This does not matter - that's not a patchwork anyone uses...
> 
> > It seems no one gives any Reviewed-by or Acked-by Tag.
> 
> You were directly addressed! So you got email and what did you do with it?
> 
> And lists received it:
> https://lore.kernel.org/all/ac6c4a8b-a6bd-44a9-993b-3b743a172dcc@kernel.org/
> 

I am sorry about that. I checked this email with our IT engineers at
office365 administration page, it was not received by Microsoft office365
server, we don't know what's the reason.

I will put your Reviewed-by tag when sending v3 patch, may I get your
Ack for the 1st patch:
https://lore.kernel.org/linux-arm-kernel/330a01b7-7285-47fe-abb1-8d5fa71dd240@kernel.org/T/#u
Krzysztof Kozlowski Feb. 26, 2025, 10:30 a.m. UTC | #5
On 26/02/2025 11:26, Peter Chen wrote:
> On 25-02-26 09:40:06, Krzysztof Kozlowski wrote:
>>>>
>>>> On 26/02/2025 02:21, Peter Chen wrote:
>>>>> Add device tree bindings for CIX P1 (Internal name sky1) Arm SoC,
>>>>> it consists several SoC models like CP8180, CD8180, etc.
>>>>>
>>>>> Acked-by: Fugang Duan <fugang.duan@cixtech.com>
>>>>> Signed-off-by: Peter Chen <peter.chen@cixtech.com>
>>>>> ---
>>>>
>>>> <form letter>
>>>> This is a friendly reminder during the review process.
>>>>
>>>> It looks like you received a tag and forgot to add it.
>>>>
>>>> If you do not know the process, here is a short explanation:
>>>> Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions
>>>> of patchset, under or above your Signed-off-by tag, unless patch changed
>>>> significantly (e.g. new properties added to the DT bindings). Tag is
>>>> "received", when provided in a message replied to you on the mailing
>>>> list. Tools like b4 can help here. However, there's no need to repost
>>>> patches *only* to add the tags. The upstream maintainer will do that for
>>>> tags received on the version they apply.
>>>>
>>>> Please read:
>>>> https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577
>>>>
>>>> If a tag was not added on purpose, please state why and what changed.
>>>> </form letter>
>>>>
>>>
>>> I have checked the review-process again at:
>>> https://patchwork.kernel.org/project/linux-arm-kernel/list/?series=935897
>>
>> This does not matter - that's not a patchwork anyone uses...
>>
>>> It seems no one gives any Reviewed-by or Acked-by Tag.
>>
>> You were directly addressed! So you got email and what did you do with it?
>>
>> And lists received it:
>> https://lore.kernel.org/all/ac6c4a8b-a6bd-44a9-993b-3b743a172dcc@kernel.org/
>>
> 
> I am sorry about that. I checked this email with our IT engineers at
> office365 administration page, it was not received by Microsoft office365
> server, we don't know what's the reason.


That's the only email which did not reach you, I think. 4 or 5 others
did, so this could mean your system will spam/reject silently anything
with review tag (or email address).

If so, your corporate mail system is not suitable for upstream work
(Microsoft outlook is known of poor quality in that matter and that's
not the first case people have trouble with Outlook servers) and maybe
you should switch to b4-relay and other mail boxes.

> 
> I will put your Reviewed-by tag when sending v3 patch, may I get your
> Ack for the 1st patch:
> https://lore.kernel.org/linux-arm-kernel/330a01b7-7285-47fe-abb1-8d5fa71dd240@kernel.org/T/#u


I'll send it, but I still have doubts Microsoft won't put me in spam :/


Best regards,
Krzysztof
Peter Chen Feb. 26, 2025, 12:59 p.m. UTC | #6
On 25-02-26 11:30:38, Krzysztof Kozlowski wrote:
> >>>
> >>> I have checked the review-process again at:
> >>> https://patchwork.kernel.org/project/linux-arm-kernel/list/?series=935897
> >>
> >> This does not matter - that's not a patchwork anyone uses...
> >>
> >>> It seems no one gives any Reviewed-by or Acked-by Tag.
> >>
> >> You were directly addressed! So you got email and what did you do with it?
> >>
> >> And lists received it:
> >> https://lore.kernel.org/all/ac6c4a8b-a6bd-44a9-993b-3b743a172dcc@kernel.org/
> >>
> >
> > I am sorry about that. I checked this email with our IT engineers at
> > office365 administration page, it was not received by Microsoft office365
> > server, we don't know what's the reason.
> 
> 
> That's the only email which did not reach you, I think. 4 or 5 others
> did, so this could mean your system will spam/reject silently anything
> with review tag (or email address).
> 
> If so, your corporate mail system is not suitable for upstream work
> (Microsoft outlook is known of poor quality in that matter and that's
> not the first case people have trouble with Outlook servers) and maybe
> you should switch to b4-relay and other mail boxes.
> 
> >
> > I will put your Reviewed-by tag when sending v3 patch, may I get your
> > Ack for the 1st patch:
> > https://lore.kernel.org/linux-arm-kernel/330a01b7-7285-47fe-abb1-8d5fa71dd240@kernel.org/T/#u
> 
> 
> I'll send it, but I still have doubts Microsoft won't put me in spam :/
> 

Hi Krzysztof,

Do you use kernel.org as your smtp server? It may kernel.org's smtp
server issue, both lore.kernel.org[1] and patchwork.kernel.org[2]
have received your ack for my v2 patch.

But only lore.kernel.org [3] received your reviewed-by Tag for my v1
patch, the patch.kernel.org[4] did not receive it, office365 server
for my company also did not receive it.

Another strange is I did not received [5], but my colleagues in our
upstream mail list (cix-kernel-upstream@cixtech.com) received it, I have
not in that list at that time (now I am at it), but my name is at your
reply to, it seems kernel.org did not send to me.

That's just my suspect, if someone meets the similar issues in future,
it may prove my suspect.


[1] https://lore.kernel.org/linux-arm-kernel/df24ac09-1717-4a91-a710-cf1e46341ca8@kernel.org/
[2] https://patchwork.kernel.org/project/linux-arm-kernel/patch/20250226012136.854614-2-peter.chen@cixtech.com/#26265571
[3] https://lore.kernel.org/all/ac6c4a8b-a6bd-44a9-993b-3b743a172dcc@kernel.org/
[4] https://patchwork.kernel.org/project/linux-arm-kernel/patch/20250220084020.628704-2-peter.chen@cixtech.com/
[5] https://lore.kernel.org/all/f56e9c68-0745-43c1-ae80-e2dc0942ea07@kernel.org/
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/cix.yaml b/Documentation/devicetree/bindings/arm/cix.yaml
new file mode 100644
index 000000000000..114dab4bc4d2
--- /dev/null
+++ b/Documentation/devicetree/bindings/arm/cix.yaml
@@ -0,0 +1,26 @@ 
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/arm/cix.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: CIX platforms
+
+maintainers:
+  - Peter Chen <peter.chen@cixtech.com>
+  - Fugang Duan <fugang.duan@cixtech.com>
+
+properties:
+  $nodename:
+    const: '/'
+  compatible:
+    oneOf:
+
+      - description: Radxa Orion O6
+        items:
+          - const: radxa,orion-o6
+          - const: cix,sky1
+
+additionalProperties: true
+
+...