| Message ID | 20250225121742.721871-1-jani.nikula@intel.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | drm/i915/power: move runtime power status info to power debugfs | expand |
On Tue, Feb 25, 2025 at 02:17:42PM +0200, Jani Nikula wrote: > The i915 core debugfs has no business looking at power domain guts for > runtime power status. Move the info to the more appropriate place. > > Cc: Imre Deak <imre.deak@intel.com> > Signed-off-by: Jani Nikula <jani.nikula@intel.com> Reviewed-by: Imre Deak <imre.deak@intel.com> > --- > drivers/gpu/drm/i915/display/intel_display_power.c | 3 +++ > drivers/gpu/drm/i915/i915_debugfs.c | 3 --- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c b/drivers/gpu/drm/i915/display/intel_display_power.c > index 396930937d98..96346b33d7e9 100644 > --- a/drivers/gpu/drm/i915/display/intel_display_power.c > +++ b/drivers/gpu/drm/i915/display/intel_display_power.c > @@ -2317,6 +2317,9 @@ void intel_display_power_debug(struct intel_display *display, struct seq_file *m > > mutex_lock(&power_domains->lock); > > + seq_printf(m, "Runtime power status: %s\n", > + str_enabled_disabled(!power_domains->init_wakeref)); > + > seq_printf(m, "%-25s %s\n", "Power well/domain", "Use count"); > for (i = 0; i < power_domains->power_well_count; i++) { > struct i915_power_well *power_well; > diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c > index 1c2a97f593c7..0d9e263913ff 100644 > --- a/drivers/gpu/drm/i915/i915_debugfs.c > +++ b/drivers/gpu/drm/i915/i915_debugfs.c > @@ -411,9 +411,6 @@ static int i915_runtime_pm_status(struct seq_file *m, void *unused) > if (!HAS_RUNTIME_PM(dev_priv)) > seq_puts(m, "Runtime power management not supported\n"); > > - seq_printf(m, "Runtime power status: %s\n", > - str_enabled_disabled(!dev_priv->display.power.domains.init_wakeref)); > - > seq_printf(m, "GPU idle: %s\n", str_yes_no(!to_gt(dev_priv)->awake)); > seq_printf(m, "IRQs disabled: %s\n", > str_yes_no(!intel_irqs_enabled(dev_priv))); > -- > 2.39.5 >
On Wed, 26 Feb 2025, Imre Deak <imre.deak@intel.com> wrote: > On Tue, Feb 25, 2025 at 02:17:42PM +0200, Jani Nikula wrote: >> The i915 core debugfs has no business looking at power domain guts for >> runtime power status. Move the info to the more appropriate place. >> >> Cc: Imre Deak <imre.deak@intel.com> >> Signed-off-by: Jani Nikula <jani.nikula@intel.com> > > Reviewed-by: Imre Deak <imre.deak@intel.com> Thanks, pushed to din. BR, Jani. > >> --- >> drivers/gpu/drm/i915/display/intel_display_power.c | 3 +++ >> drivers/gpu/drm/i915/i915_debugfs.c | 3 --- >> 2 files changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c b/drivers/gpu/drm/i915/display/intel_display_power.c >> index 396930937d98..96346b33d7e9 100644 >> --- a/drivers/gpu/drm/i915/display/intel_display_power.c >> +++ b/drivers/gpu/drm/i915/display/intel_display_power.c >> @@ -2317,6 +2317,9 @@ void intel_display_power_debug(struct intel_display *display, struct seq_file *m >> >> mutex_lock(&power_domains->lock); >> >> + seq_printf(m, "Runtime power status: %s\n", >> + str_enabled_disabled(!power_domains->init_wakeref)); >> + >> seq_printf(m, "%-25s %s\n", "Power well/domain", "Use count"); >> for (i = 0; i < power_domains->power_well_count; i++) { >> struct i915_power_well *power_well; >> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c >> index 1c2a97f593c7..0d9e263913ff 100644 >> --- a/drivers/gpu/drm/i915/i915_debugfs.c >> +++ b/drivers/gpu/drm/i915/i915_debugfs.c >> @@ -411,9 +411,6 @@ static int i915_runtime_pm_status(struct seq_file *m, void *unused) >> if (!HAS_RUNTIME_PM(dev_priv)) >> seq_puts(m, "Runtime power management not supported\n"); >> >> - seq_printf(m, "Runtime power status: %s\n", >> - str_enabled_disabled(!dev_priv->display.power.domains.init_wakeref)); >> - >> seq_printf(m, "GPU idle: %s\n", str_yes_no(!to_gt(dev_priv)->awake)); >> seq_printf(m, "IRQs disabled: %s\n", >> str_yes_no(!intel_irqs_enabled(dev_priv))); >> -- >> 2.39.5 >>
diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c b/drivers/gpu/drm/i915/display/intel_display_power.c index 396930937d98..96346b33d7e9 100644 --- a/drivers/gpu/drm/i915/display/intel_display_power.c +++ b/drivers/gpu/drm/i915/display/intel_display_power.c @@ -2317,6 +2317,9 @@ void intel_display_power_debug(struct intel_display *display, struct seq_file *m mutex_lock(&power_domains->lock); + seq_printf(m, "Runtime power status: %s\n", + str_enabled_disabled(!power_domains->init_wakeref)); + seq_printf(m, "%-25s %s\n", "Power well/domain", "Use count"); for (i = 0; i < power_domains->power_well_count; i++) { struct i915_power_well *power_well; diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c index 1c2a97f593c7..0d9e263913ff 100644 --- a/drivers/gpu/drm/i915/i915_debugfs.c +++ b/drivers/gpu/drm/i915/i915_debugfs.c @@ -411,9 +411,6 @@ static int i915_runtime_pm_status(struct seq_file *m, void *unused) if (!HAS_RUNTIME_PM(dev_priv)) seq_puts(m, "Runtime power management not supported\n"); - seq_printf(m, "Runtime power status: %s\n", - str_enabled_disabled(!dev_priv->display.power.domains.init_wakeref)); - seq_printf(m, "GPU idle: %s\n", str_yes_no(!to_gt(dev_priv)->awake)); seq_printf(m, "IRQs disabled: %s\n", str_yes_no(!intel_irqs_enabled(dev_priv)));
The i915 core debugfs has no business looking at power domain guts for runtime power status. Move the info to the more appropriate place. Cc: Imre Deak <imre.deak@intel.com> Signed-off-by: Jani Nikula <jani.nikula@intel.com> --- drivers/gpu/drm/i915/display/intel_display_power.c | 3 +++ drivers/gpu/drm/i915/i915_debugfs.c | 3 --- 2 files changed, 3 insertions(+), 3 deletions(-)