mbox series

[0/5] drm/i915/pfit: panel fitter refactors

Message ID cover.1740564009.git.jani.nikula@intel.com (mailing list archive)
Headers show
Series drm/i915/pfit: panel fitter refactors | expand

Message

Jani Nikula Feb. 26, 2025, 10:01 a.m. UTC
Move pfit code to intel_pfit.c, convert to struct intel_display, split
out pfit registers to a separate file, etc.

Jani Nikula (5):
  drm/i915/pfit: rename intel_panel_fitting() to
    intel_pfit_compute_config()
  drm/i915/pfit: move ilk and i9xx pfit code to intel_pfit.[ch]
  drm/i915/pfit: fix comment style for moved comments
  drm/i915/pfit: convert moved code to struct intel_display
  drm/i915/pfit: split out intel_pfit_regs.h

 drivers/gpu/drm/i915/display/icl_dsi.c        |   2 +-
 drivers/gpu/drm/i915/display/intel_crt.c      |   1 +
 drivers/gpu/drm/i915/display/intel_ddi.c      |   1 +
 drivers/gpu/drm/i915/display/intel_display.c  | 165 +----------------
 drivers/gpu/drm/i915/display/intel_display.h  |   2 -
 drivers/gpu/drm/i915/display/intel_dp.c       |   2 +-
 drivers/gpu/drm/i915/display/intel_dp_mst.c   |   1 +
 drivers/gpu/drm/i915/display/intel_hdmi.c     |   2 +-
 drivers/gpu/drm/i915/display/intel_lvds.c     |   3 +-
 drivers/gpu/drm/i915/display/intel_overlay.c  |   1 +
 drivers/gpu/drm/i915/display/intel_pfit.c     | 168 +++++++++++++++++-
 drivers/gpu/drm/i915/display/intel_pfit.h     |  10 +-
 .../gpu/drm/i915/display/intel_pfit_regs.h    |  79 ++++++++
 drivers/gpu/drm/i915/display/vlv_dsi.c        |   2 +-
 drivers/gpu/drm/i915/i915_reg.h               |  70 --------
 drivers/gpu/drm/i915/intel_gvt_mmio_table.c   |   1 +
 16 files changed, 268 insertions(+), 242 deletions(-)
 create mode 100644 drivers/gpu/drm/i915/display/intel_pfit_regs.h

Comments

Saarinen, Jani Feb. 26, 2025, 12:07 p.m. UTC | #1
HI, 
See related error. Please re-report. 

> -----Original Message-----
> From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of
> Patchwork
> Sent: Wednesday, 26 February 2025 13.56
> To: Nikula, Jani <jani.nikula@intel.com>
> Cc: intel-gfx@lists.freedesktop.org
> Subject: ✗ i915.CI.BAT: failure for drm/i915/pfit: panel fitter refactors
> 
> Patch Details
> Series:	drm/i915/pfit: panel fitter refactors
> URL:	https://patchwork.freedesktop.org/series/145471/
> State:	failure
> Details:	https://intel-gfx-ci.01.org/tree/drm-
> tip/Patchwork_145471v1/index.html
> 
> CI Bug Log - changes from CI_DRM_16183 -> Patchwork_145471v1
> 
> 
> Summary
> 
> 
> FAILURE
> 
> Serious unknown changes coming with Patchwork_145471v1 absolutely need
> to be verified manually.
> 
> If you think the reported changes have nothing to do with the changes
> introduced in Patchwork_145471v1, please notify your bug team (I915-ci-
> infra@lists.freedesktop.org) to allow them to document this new failure
> mode, which will reduce false positives in CI.
> 
> External URL: https://intel-gfx-ci.01.org/tree/drm-
> tip/Patchwork_145471v1/index.html
> 
> 
> Participating hosts (44 -> 44)
> 
> 
> No changes in participating hosts
> 
> 
> Possible new issues
> 
> 
> Here are the unknown changes that may have been introduced in
> Patchwork_145471v1:
> 
> 
> IGT changes
> 
> 
> Possible regressions
> 
> 
> *	igt@kms_flip@basic-flip-vs-modeset@c-dp1:
> 
> 	*	fi-kbl-7567u: PASS <https://intel-gfx-ci.01.org/tree/drm-
> tip/CI_DRM_16183/fi-kbl-7567u/igt@kms_flip@basic-flip-vs-modeset@c-
> dp1.html>  -> DMESG-WARN <https://intel-gfx-ci.01.org/tree/drm-
> tip/Patchwork_145471v1/fi-kbl-7567u/igt@kms_flip@basic-flip-vs-
> modeset@c-dp1.html>  +1 other test dmesg-warn
Same as https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13770 

> 
> 
> Known issues
> 
> 
> Here are the changes found in Patchwork_145471v1 that come from known
> issues:
> 
> 
> IGT changes
> 
> 
> Issues hit
> 
> 
> *	igt@i915_pm_rpm@module-reload:
> 
> 	*	bat-rpls-4: PASS <https://intel-gfx-ci.01.org/tree/drm-
> tip/CI_DRM_16183/bat-rpls-4/igt@i915_pm_rpm@module-reload.html>  ->
> FAIL <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_145471v1/bat-
> rpls-4/igt@i915_pm_rpm@module-reload.html>  (i915#13633
> <https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13633> )
> 
> *	igt@i915_selftest@live@memory_region:
> 
> 	*	bat-twl-2: NOTRUN -> ABORT <https://intel-gfx-
> ci.01.org/tree/drm-tip/Patchwork_145471v1/bat-twl-
> 2/igt@i915_selftest@live@memory_region.html>  (i915#12919
> <https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12919> )
> 
> *	igt@i915_selftest@live@workarounds:
> 
> 	*	bat-arls-6: PASS <https://intel-gfx-ci.01.org/tree/drm-
> tip/CI_DRM_16183/bat-arls-6/igt@i915_selftest@live@workarounds.html>
> -> DMESG-FAIL <https://intel-gfx-ci.01.org/tree/drm-
> tip/Patchwork_145471v1/bat-arls-
> 6/igt@i915_selftest@live@workarounds.html>  (i915#12061
> <https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12061> ) +1 other
> test dmesg-fail
> 
> *	igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence:
> 
> 	*	bat-dg2-11: PASS <https://intel-gfx-ci.01.org/tree/drm-
> tip/CI_DRM_16183/bat-dg2-11/igt@kms_pipe_crc_basic@nonblocking-crc-
> frame-sequence.html>  -> SKIP <https://intel-gfx-ci.01.org/tree/drm-
> tip/Patchwork_145471v1/bat-dg2-
> 11/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence.html>
> (i915#9197 <https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9197>
> ) +3 other tests skip
> 
> 
> Possible fixes
> 
> 
> *	igt@i915_selftest@live@reset:
> 
> 	*	bat-twl-2: INCOMPLETE <https://intel-gfx-
> ci.01.org/tree/drm-tip/CI_DRM_16183/bat-twl-
> 2/igt@i915_selftest@live@reset.html>  (i915#12445
> <https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12445> ) -> PASS
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_145471v1/bat-twl-
> 2/igt@i915_selftest@live@reset.html>
> 
> *	igt@i915_selftest@live@workarounds:
> 
> 	*	bat-arlh-3: DMESG-FAIL <https://intel-gfx-
> ci.01.org/tree/drm-tip/CI_DRM_16183/bat-arlh-
> 3/igt@i915_selftest@live@workarounds.html>  (i915#12061
> <https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12061> ) -> PASS
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_145471v1/bat-arlh-
> 3/igt@i915_selftest@live@workarounds.html>  +1 other test pass
> 	*	bat-arls-5: DMESG-FAIL <https://intel-gfx-ci.01.org/tree/drm-
> tip/CI_DRM_16183/bat-arls-5/igt@i915_selftest@live@workarounds.html>
> (i915#12061 <https://gitlab.freedesktop.org/drm/i915/kernel/-
> /issues/12061> ) -> PASS <https://intel-gfx-ci.01.org/tree/drm-
> tip/Patchwork_145471v1/bat-arls-
> 5/igt@i915_selftest@live@workarounds.html>  +1 other test pass
> 	*	bat-mtlp-9: DMESG-FAIL <https://intel-gfx-
> ci.01.org/tree/drm-tip/CI_DRM_16183/bat-mtlp-
> 9/igt@i915_selftest@live@workarounds.html>  (i915#12061
> <https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12061> ) -> PASS
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_145471v1/bat-mtlp-
> 9/igt@i915_selftest@live@workarounds.html>  +1 other test pass
> 
> 
> Warnings
> 
> 
> *	igt@i915_selftest@live:
> 
> 	*	bat-twl-2: INCOMPLETE <https://intel-gfx-
> ci.01.org/tree/drm-tip/CI_DRM_16183/bat-twl-
> 2/igt@i915_selftest@live.html>  (i915#12445
> <https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12445>  /
> i915#13761 <https://gitlab.freedesktop.org/drm/i915/kernel/-
> /issues/13761> ) -> ABORT <https://intel-gfx-ci.01.org/tree/drm-
> tip/Patchwork_145471v1/bat-twl-2/igt@i915_selftest@live.html>
> (i915#12435 <https://gitlab.freedesktop.org/drm/i915/kernel/-
> /issues/12435>  / i915#12919
> <https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12919>  /
> i915#13503 <https://gitlab.freedesktop.org/drm/i915/kernel/-
> /issues/13503> )
> 
> 
> Build changes
> 
> 
> *	Linux: CI_DRM_16183 -> Patchwork_145471v1
> 
> CI-20190529: 20190529
> CI_DRM_16183: 5bcb67a2a4c61034f5a25c024631c5fbf351ee8d @
> git://anongit.freedesktop.org/gfx-ci/linux
> IGT_8248: 8248
> Patchwork_145471v1: 5bcb67a2a4c61034f5a25c024631c5fbf351ee8d @
> git://anongit.freedesktop.org/gfx-ci/linux
Ville Syrjälä Feb. 26, 2025, 12:53 p.m. UTC | #2
On Wed, Feb 26, 2025 at 12:01:06PM +0200, Jani Nikula wrote:
> Move pfit code to intel_pfit.c, convert to struct intel_display, split
> out pfit registers to a separate file, etc.
> 
> Jani Nikula (5):
>   drm/i915/pfit: rename intel_panel_fitting() to
>     intel_pfit_compute_config()
>   drm/i915/pfit: move ilk and i9xx pfit code to intel_pfit.[ch]
>   drm/i915/pfit: fix comment style for moved comments
>   drm/i915/pfit: convert moved code to struct intel_display
>   drm/i915/pfit: split out intel_pfit_regs.h

Series is 
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> 
>  drivers/gpu/drm/i915/display/icl_dsi.c        |   2 +-
>  drivers/gpu/drm/i915/display/intel_crt.c      |   1 +
>  drivers/gpu/drm/i915/display/intel_ddi.c      |   1 +
>  drivers/gpu/drm/i915/display/intel_display.c  | 165 +----------------
>  drivers/gpu/drm/i915/display/intel_display.h  |   2 -
>  drivers/gpu/drm/i915/display/intel_dp.c       |   2 +-
>  drivers/gpu/drm/i915/display/intel_dp_mst.c   |   1 +
>  drivers/gpu/drm/i915/display/intel_hdmi.c     |   2 +-
>  drivers/gpu/drm/i915/display/intel_lvds.c     |   3 +-
>  drivers/gpu/drm/i915/display/intel_overlay.c  |   1 +
>  drivers/gpu/drm/i915/display/intel_pfit.c     | 168 +++++++++++++++++-
>  drivers/gpu/drm/i915/display/intel_pfit.h     |  10 +-
>  .../gpu/drm/i915/display/intel_pfit_regs.h    |  79 ++++++++
>  drivers/gpu/drm/i915/display/vlv_dsi.c        |   2 +-
>  drivers/gpu/drm/i915/i915_reg.h               |  70 --------
>  drivers/gpu/drm/i915/intel_gvt_mmio_table.c   |   1 +
>  16 files changed, 268 insertions(+), 242 deletions(-)
>  create mode 100644 drivers/gpu/drm/i915/display/intel_pfit_regs.h
> 
> -- 
> 2.39.5
Ravali, JupallyX Feb. 27, 2025, 8:35 a.m. UTC | #3
Hi,

https://patchwork.freedesktop.org/series/145471/ - Re-reported.
i915.CI.BAT - Re-reported.


Thanks,
Ravali.

-----Original Message-----
From: I915-ci-infra <i915-ci-infra-bounces@lists.freedesktop.org> On Behalf Of Saarinen, Jani
Sent: 26 February 2025 17:38
To: intel-gfx@lists.freedesktop.org; Nikula, Jani <jani.nikula@intel.com>; I915-ci-infra@lists.freedesktop.org
Subject: RE: ✗ i915.CI.BAT: failure for drm/i915/pfit: panel fitter refactors

HI,
See related error. Please re-report. 

> -----Original Message-----
> From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of 
> Patchwork
> Sent: Wednesday, 26 February 2025 13.56
> To: Nikula, Jani <jani.nikula@intel.com>
> Cc: intel-gfx@lists.freedesktop.org
> Subject: ✗ i915.CI.BAT: failure for drm/i915/pfit: panel fitter 
> refactors
> 
> Patch Details
> Series:	drm/i915/pfit: panel fitter refactors
> URL:	https://patchwork.freedesktop.org/series/145471/
> State:	failure
> Details:	https://intel-gfx-ci.01.org/tree/drm-
> tip/Patchwork_145471v1/index.html
> 
> CI Bug Log - changes from CI_DRM_16183 -> Patchwork_145471v1
> 
> 
> Summary
> 
> 
> FAILURE
> 
> Serious unknown changes coming with Patchwork_145471v1 absolutely need 
> to be verified manually.
> 
> If you think the reported changes have nothing to do with the changes 
> introduced in Patchwork_145471v1, please notify your bug team 
> (I915-ci-
> infra@lists.freedesktop.org) to allow them to document this new 
> failure mode, which will reduce false positives in CI.
> 
> External URL: https://intel-gfx-ci.01.org/tree/drm-
> tip/Patchwork_145471v1/index.html
> 
> 
> Participating hosts (44 -> 44)
> 
> 
> No changes in participating hosts
> 
> 
> Possible new issues
> 
> 
> Here are the unknown changes that may have been introduced in
> Patchwork_145471v1:
> 
> 
> IGT changes
> 
> 
> Possible regressions
> 
> 
> *	igt@kms_flip@basic-flip-vs-modeset@c-dp1:
> 
> 	*	fi-kbl-7567u: PASS <https://intel-gfx-ci.01.org/tree/drm-
> tip/CI_DRM_16183/fi-kbl-7567u/igt@kms_flip@basic-flip-vs-modeset@c-
> dp1.html>  -> DMESG-WARN <https://intel-gfx-ci.01.org/tree/drm-
> tip/Patchwork_145471v1/fi-kbl-7567u/igt@kms_flip@basic-flip-vs-
> modeset@c-dp1.html>  +1 other test dmesg-warn
Same as https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13770 

> 
> 
> Known issues
> 
> 
> Here are the changes found in Patchwork_145471v1 that come from known
> issues:
> 
> 
> IGT changes
> 
> 
> Issues hit
> 
> 
> *	igt@i915_pm_rpm@module-reload:
> 
> 	*	bat-rpls-4: PASS <https://intel-gfx-ci.01.org/tree/drm-
> tip/CI_DRM_16183/bat-rpls-4/igt@i915_pm_rpm@module-reload.html>  -> 
> FAIL <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_145471v1/bat-
> rpls-4/igt@i915_pm_rpm@module-reload.html>  (i915#13633 
> <https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13633> )
> 
> *	igt@i915_selftest@live@memory_region:
> 
> 	*	bat-twl-2: NOTRUN -> ABORT <https://intel-gfx-
> ci.01.org/tree/drm-tip/Patchwork_145471v1/bat-twl-
> 2/igt@i915_selftest@live@memory_region.html>  (i915#12919 
> <https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12919> )
> 
> *	igt@i915_selftest@live@workarounds:
> 
> 	*	bat-arls-6: PASS <https://intel-gfx-ci.01.org/tree/drm-
> tip/CI_DRM_16183/bat-arls-6/igt@i915_selftest@live@workarounds.html>
> -> DMESG-FAIL <https://intel-gfx-ci.01.org/tree/drm-
> tip/Patchwork_145471v1/bat-arls-
> 6/igt@i915_selftest@live@workarounds.html>  (i915#12061 
> <https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12061> ) +1 
> other test dmesg-fail
> 
> *	igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence:
> 
> 	*	bat-dg2-11: PASS <https://intel-gfx-ci.01.org/tree/drm-
> tip/CI_DRM_16183/bat-dg2-11/igt@kms_pipe_crc_basic@nonblocking-crc-
> frame-sequence.html>  -> SKIP <https://intel-gfx-ci.01.org/tree/drm-
> tip/Patchwork_145471v1/bat-dg2-
> 11/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence.html>
> (i915#9197 
> <https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9197>
> ) +3 other tests skip
> 
> 
> Possible fixes
> 
> 
> *	igt@i915_selftest@live@reset:
> 
> 	*	bat-twl-2: INCOMPLETE <https://intel-gfx-
> ci.01.org/tree/drm-tip/CI_DRM_16183/bat-twl-
> 2/igt@i915_selftest@live@reset.html>  (i915#12445 
> <https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12445> ) -> 
> PASS
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_145471v1/bat-twl-
> 2/igt@i915_selftest@live@reset.html>
> 
> *	igt@i915_selftest@live@workarounds:
> 
> 	*	bat-arlh-3: DMESG-FAIL <https://intel-gfx-
> ci.01.org/tree/drm-tip/CI_DRM_16183/bat-arlh-
> 3/igt@i915_selftest@live@workarounds.html>  (i915#12061 
> <https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12061> ) -> 
> PASS
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_145471v1/bat-arlh-
> 3/igt@i915_selftest@live@workarounds.html>  +1 other test pass
> 	*	bat-arls-5: DMESG-FAIL <https://intel-gfx-ci.01.org/tree/drm-
> tip/CI_DRM_16183/bat-arls-5/igt@i915_selftest@live@workarounds.html>
> (i915#12061 <https://gitlab.freedesktop.org/drm/i915/kernel/-
> /issues/12061> ) -> PASS <https://intel-gfx-ci.01.org/tree/drm-
> tip/Patchwork_145471v1/bat-arls-
> 5/igt@i915_selftest@live@workarounds.html>  +1 other test pass
> 	*	bat-mtlp-9: DMESG-FAIL <https://intel-gfx-
> ci.01.org/tree/drm-tip/CI_DRM_16183/bat-mtlp-
> 9/igt@i915_selftest@live@workarounds.html>  (i915#12061 
> <https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12061> ) -> 
> PASS
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_145471v1/bat-mtlp-
> 9/igt@i915_selftest@live@workarounds.html>  +1 other test pass
> 
> 
> Warnings
> 
> 
> *	igt@i915_selftest@live:
> 
> 	*	bat-twl-2: INCOMPLETE <https://intel-gfx-
> ci.01.org/tree/drm-tip/CI_DRM_16183/bat-twl-
> 2/igt@i915_selftest@live.html>  (i915#12445 
> <https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12445>  /
> i915#13761 <https://gitlab.freedesktop.org/drm/i915/kernel/-
> /issues/13761> ) -> ABORT <https://intel-gfx-ci.01.org/tree/drm-
> tip/Patchwork_145471v1/bat-twl-2/igt@i915_selftest@live.html>
> (i915#12435 <https://gitlab.freedesktop.org/drm/i915/kernel/-
> /issues/12435>  / i915#12919
> <https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12919>  /
> i915#13503 <https://gitlab.freedesktop.org/drm/i915/kernel/-
> /issues/13503> )
> 
> 
> Build changes
> 
> 
> *	Linux: CI_DRM_16183 -> Patchwork_145471v1
> 
> CI-20190529: 20190529
> CI_DRM_16183: 5bcb67a2a4c61034f5a25c024631c5fbf351ee8d @ 
> git://anongit.freedesktop.org/gfx-ci/linux
> IGT_8248: 8248
> Patchwork_145471v1: 5bcb67a2a4c61034f5a25c024631c5fbf351ee8d @ 
> git://anongit.freedesktop.org/gfx-ci/linux