diff mbox series

[v3,15/20] ASoC: tas2764: Enable main IRQs

Message ID 20250227-apple-codec-changes-v3-15-cbb130030acf@gmail.com (mailing list archive)
State New
Headers show
Series ASoC: tas27{64,70}: improve support for Apple codec variants | expand

Commit Message

James Calligeros Feb. 27, 2025, 12:07 p.m. UTC 
From: Hector Martin <marcan@marcan.st>

IRQ handling was added in commit dae191fb957f ("ASoC: tas2764: Add IRQ
handling") however that same commit masks all interrupts coming from
the chip. Unmask the "main" interrupts so that we can see and
deal with a number of errors including clock, voltage, and current.

Reviewed-by: Neal Gompa <neal@gompa.dev>
Signed-off-by: Hector Martin <marcan@marcan.st>
Signed-off-by: James Calligeros <jcalligeros99@gmail.com>
---
 sound/soc/codecs/tas2764.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Mark Brown Feb. 27, 2025, 4:23 p.m. UTC | #1 
On Thu, Feb 27, 2025 at 10:07:42PM +1000, James Calligeros wrote:
> From: Hector Martin <marcan@marcan.st>
> 
> IRQ handling was added in commit dae191fb957f ("ASoC: tas2764: Add IRQ
> handling") however that same commit masks all interrupts coming from
> the chip. Unmask the "main" interrupts so that we can see and
> deal with a number of errors including clock, voltage, and current.

Shouldn't this also be a fix?
James Calligeros Feb. 27, 2025, 9:58 p.m. UTC | #2 
On Fri, Feb 28, 2025 at 2:23 AM Mark Brown <broonie@kernel.org> wrote:
>
> On Thu, Feb 27, 2025 at 10:07:42PM +1000, James Calligeros wrote:
> > From: Hector Martin <marcan@marcan.st>
> >
> > IRQ handling was added in commit dae191fb957f ("ASoC: tas2764: Add IRQ
> > handling") however that same commit masks all interrupts coming from
> > the chip. Unmask the "main" interrupts so that we can see and
> > deal with a number of errors including clock, voltage, and current.
>
> Shouldn't this also be a fix?

I don't think so. The referenced commit only says that it adds an IRQ handler.
I don't think this commit is actually "fixing" anything - it's just
enabling previously
masked interrupts.

Happy to move things around if you disagree.

James
diff mbox series

Patch

diff --git a/sound/soc/codecs/tas2764.c b/sound/soc/codecs/tas2764.c
index 2a787baaff5342e09cdfbf7939b0d635433f27ac..c122c07e2483b9ed1e6011dd949f97f8b2d0897f 100644
--- a/sound/soc/codecs/tas2764.c
+++ b/sound/soc/codecs/tas2764.c
@@ -715,7 +715,7 @@  static int tas2764_codec_probe(struct snd_soc_component *component)
 	regmap_reinit_cache(tas2764->regmap, &tas2764_i2c_regmap);
 
 	if (tas2764->irq) {
-		ret = snd_soc_component_write(tas2764->component, TAS2764_INT_MASK0, 0xff);
+		ret = snd_soc_component_write(tas2764->component, TAS2764_INT_MASK0, 0x00);
 		if (ret < 0)
 			return ret;