| Message ID | 20250228082936.5694-1-johan+linaro@kernel.org (mailing list archive) |
|---|---|
| State | New |
| Delegated to: | Daniel Lezcano |
| Headers | show |
| Series | thermal/drivers/qcom-spmi-temp-alarm: drop unused driver data | expand |
On 28/02/2025 09:29, Johan Hovold wrote: > The platform device driver data has not been used since commit > 7a4ca51b7040 ("thermal/drivers/qcom-spmi: Use devm_iio_channel_get") so > drop the unnecessary assignment. > > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> > --- > > I noticed this when doing some rework for pm8008 last year that I have > yet to finish. > > This can go in meanwhile. > > Johan > > > drivers/thermal/qcom/qcom-spmi-temp-alarm.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/thermal/qcom/qcom-spmi-temp-alarm.c b/drivers/thermal/qcom/qcom-spmi-temp-alarm.c > index c2d59cbfaea9..a81e7d6e865f 100644 > --- a/drivers/thermal/qcom/qcom-spmi-temp-alarm.c > +++ b/drivers/thermal/qcom/qcom-spmi-temp-alarm.c > @@ -360,7 +360,6 @@ static int qpnp_tm_probe(struct platform_device *pdev) > if (!chip) > return -ENOMEM; > > - dev_set_drvdata(&pdev->dev, chip); > chip->dev = &pdev->dev; > > mutex_init(&chip->lock); Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
On Fri, Feb 28, 2025 at 09:29:36AM +0100, Johan Hovold wrote: > The platform device driver data has not been used since commit > 7a4ca51b7040 ("thermal/drivers/qcom-spmi: Use devm_iio_channel_get") so > drop the unnecessary assignment. > > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> > --- > > I noticed this when doing some rework for pm8008 last year that I have > yet to finish. > > This can go in meanwhile. > > Johan > > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
diff --git a/drivers/thermal/qcom/qcom-spmi-temp-alarm.c b/drivers/thermal/qcom/qcom-spmi-temp-alarm.c index c2d59cbfaea9..a81e7d6e865f 100644 --- a/drivers/thermal/qcom/qcom-spmi-temp-alarm.c +++ b/drivers/thermal/qcom/qcom-spmi-temp-alarm.c @@ -360,7 +360,6 @@ static int qpnp_tm_probe(struct platform_device *pdev) if (!chip) return -ENOMEM; - dev_set_drvdata(&pdev->dev, chip); chip->dev = &pdev->dev; mutex_init(&chip->lock);
The platform device driver data has not been used since commit 7a4ca51b7040 ("thermal/drivers/qcom-spmi: Use devm_iio_channel_get") so drop the unnecessary assignment. Signed-off-by: Johan Hovold <johan+linaro@kernel.org> --- I noticed this when doing some rework for pm8008 last year that I have yet to finish. This can go in meanwhile. Johan drivers/thermal/qcom/qcom-spmi-temp-alarm.c | 1 - 1 file changed, 1 deletion(-)