[3/9] dt-bindings: gpu: mali-valhall-csf: Document optional reset

Commit Message

Marek Vasut Feb. 27, 2025, 4:58 p.m. UTC

The instance of the GPU populated in Freescale i.MX95 does require
release from reset by writing into a single GPUMIX block controller
GPURESET register bit 0. Document support for one optional reset.

Signed-off-by: Marek Vasut <[e-mail]>
---
Cc: Boris Brezillon <[e-mail]>
Cc: Conor Dooley <[e-mail]>
Cc: David Airlie <[e-mail]>
Cc: Fabio Estevam <[e-mail]>
Cc: Krzysztof Kozlowski <[e-mail]>
Cc: Liviu Dudau <[e-mail]>
Cc: Maarten Lankhorst <[e-mail]>
Cc: Maxime Ripard <[e-mail]>
Cc: Pengutronix Kernel Team <[e-mail]>
Cc: Philipp Zabel <[e-mail]>
Cc: Rob Herring <[e-mail]>
Cc: Sascha Hauer <[e-mail]>
Cc: Sebastian Reichel <[e-mail]>
Cc: Shawn Guo <[e-mail]>
Cc: Simona Vetter <[e-mail]>
Cc: Steven Price <[e-mail]>
Cc: Thomas Zimmermann <[e-mail]>
Cc: [e-mail]
Cc: [e-mail]
Cc: [e-mail]
Cc: [e-mail]
---
 .../devicetree/bindings/gpu/arm,mali-valhall-csf.yaml          | 3 +++
 1 file changed, 3 insertions(+)

Comments

Frank Li Feb. 27, 2025, 5:33 p.m. UTC | #1

On Thu, Feb 27, 2025 at 05:58:03PM +0100, Marek Vasut wrote:
> The instance of the GPU populated in Freescale i.MX95 does require
> release from reset by writing into a single GPUMIX block controller
> GPURESET register bit 0. Document support for one optional reset.
>
> Signed-off-by: Marek Vasut <[e-mail]>

Reviewed-by: Frank Li <[e-mail]>

> ---
> Cc: Boris Brezillon <[e-mail]>
> Cc: Conor Dooley <[e-mail]>
> Cc: David Airlie <[e-mail]>
> Cc: Fabio Estevam <[e-mail]>
> Cc: Krzysztof Kozlowski <[e-mail]>
> Cc: Liviu Dudau <[e-mail]>
> Cc: Maarten Lankhorst <[e-mail]>
> Cc: Maxime Ripard <[e-mail]>
> Cc: Pengutronix Kernel Team <[e-mail]>
> Cc: Philipp Zabel <[e-mail]>
> Cc: Rob Herring <[e-mail]>
> Cc: Sascha Hauer <[e-mail]>
> Cc: Sebastian Reichel <[e-mail]>
> Cc: Shawn Guo <[e-mail]>
> Cc: Simona Vetter <[e-mail]>
> Cc: Steven Price <[e-mail]>
> Cc: Thomas Zimmermann <[e-mail]>
> Cc: [e-mail]
> Cc: [e-mail]
> Cc: [e-mail]
> Cc: [e-mail]
> ---
>  .../devicetree/bindings/gpu/arm,mali-valhall-csf.yaml          | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-valhall-csf.yaml b/Documentation/devicetree/bindings/gpu/arm,mali-valhall-csf.yaml
> index a5b4e00217587..0efa06822a543 100644
> --- a/Documentation/devicetree/bindings/gpu/arm,mali-valhall-csf.yaml
> +++ b/Documentation/devicetree/bindings/gpu/arm,mali-valhall-csf.yaml
> @@ -61,6 +61,9 @@ properties:
>      minItems: 1
>      maxItems: 5
>
> +  resets:
> +    maxItems: 1
> +
>    sram-supply: true
>
>    "#cooling-cells":
> --
> 2.47.2
>

Rob Herring (Arm) Feb. 27, 2025, 6:38 p.m. UTC | #2

On Thu, 27 Feb 2025 17:58:03 +0100, Marek Vasut wrote:
> The instance of the GPU populated in Freescale i.MX95 does require
> release from reset by writing into a single GPUMIX block controller
> GPURESET register bit 0. Document support for one optional reset.
> 
> Signed-off-by: Marek Vasut <[e-mail]>
> ---
> Cc: Boris Brezillon <[e-mail]>
> Cc: Conor Dooley <[e-mail]>
> Cc: David Airlie <[e-mail]>
> Cc: Fabio Estevam <[e-mail]>
> Cc: Krzysztof Kozlowski <[e-mail]>
> Cc: Liviu Dudau <[e-mail]>
> Cc: Maarten Lankhorst <[e-mail]>
> Cc: Maxime Ripard <[e-mail]>
> Cc: Pengutronix Kernel Team <[e-mail]>
> Cc: Philipp Zabel <[e-mail]>
> Cc: Rob Herring <[e-mail]>
> Cc: Sascha Hauer <[e-mail]>
> Cc: Sebastian Reichel <[e-mail]>
> Cc: Shawn Guo <[e-mail]>
> Cc: Simona Vetter <[e-mail]>
> Cc: Steven Price <[e-mail]>
> Cc: Thomas Zimmermann <[e-mail]>
> Cc: [e-mail]
> Cc: [e-mail]
> Cc: [e-mail]
> Cc: [e-mail]
> ---
>  .../devicetree/bindings/gpu/arm,mali-valhall-csf.yaml          | 3 +++
>  1 file changed, 3 insertions(+)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:


doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/[e-mail]

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.

Rob Herring (Arm) Feb. 28, 2025, 12:25 p.m. UTC | #3

On Thu, 27 Feb 2025 17:58:03 +0100, Marek Vasut wrote:
> The instance of the GPU populated in Freescale i.MX95 does require
> release from reset by writing into a single GPUMIX block controller
> GPURESET register bit 0. Document support for one optional reset.
> 
> Signed-off-by: Marek Vasut <[e-mail]>
> ---
> Cc: Boris Brezillon <[e-mail]>
> Cc: Conor Dooley <[e-mail]>
> Cc: David Airlie <[e-mail]>
> Cc: Fabio Estevam <[e-mail]>
> Cc: Krzysztof Kozlowski <[e-mail]>
> Cc: Liviu Dudau <[e-mail]>
> Cc: Maarten Lankhorst <[e-mail]>
> Cc: Maxime Ripard <[e-mail]>
> Cc: Pengutronix Kernel Team <[e-mail]>
> Cc: Philipp Zabel <[e-mail]>
> Cc: Rob Herring <[e-mail]>
> Cc: Sascha Hauer <[e-mail]>
> Cc: Sebastian Reichel <[e-mail]>
> Cc: Shawn Guo <[e-mail]>
> Cc: Simona Vetter <[e-mail]>
> Cc: Steven Price <[e-mail]>
> Cc: Thomas Zimmermann <[e-mail]>
> Cc: [e-mail]
> Cc: [e-mail]
> Cc: [e-mail]
> Cc: [e-mail]
> ---
>  .../devicetree/bindings/gpu/arm,mali-valhall-csf.yaml          | 3 +++
>  1 file changed, 3 insertions(+)
> 

Acked-by: Rob Herring (Arm) <[e-mail]>

Patch

diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-valhall-csf.yaml b/Documentation/devicetree/bindings/gpu/arm,mali-valhall-csf.yaml
index a5b4e00217587..0efa06822a543 100644
--- a/Documentation/devicetree/bindings/gpu/arm,mali-valhall-csf.yaml
+++ b/Documentation/devicetree/bindings/gpu/arm,mali-valhall-csf.yaml
@@ -61,6 +61,9 @@  properties:
     minItems: 1
     maxItems: 5
 
+  resets:
+    maxItems: 1
+
   sram-supply: true
 
   "#cooling-cells":