| Message ID | 20250228-dpu-fix-catalog-v1-1-b05d22fbc2b4@linaro.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | drm/msm/dpu: disable DSC on some of old DPU models | expand |
On 28.02.2025 3:40 AM, Dmitry Baryshkov wrote: > The MSM8937 platform doesn't have DSC blocks nor does have it DSC > registers in the PINGPONG block. Drop the DPU_PINGPONG_DSC feature bit > from the PINGPONG's feature mask and, as it is the only remaining bit, > drop the .features assignment completely. > > Fixes: c079680bb0fa ("drm/msm/dpu: Add support for MSM8937") > Reported-by: Abhinav Kumar <quic_abhinavk@quicinc.com> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- With the commit message fixed: Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> Konrad
On 28.02.2025 2:43 PM, Konrad Dybcio wrote: > On 28.02.2025 3:40 AM, Dmitry Baryshkov wrote: >> The MSM8937 platform doesn't have DSC blocks nor does have it DSC >> registers in the PINGPONG block. Drop the DPU_PINGPONG_DSC feature bit >> from the PINGPONG's feature mask and, as it is the only remaining bit, >> drop the .features assignment completely. >> >> Fixes: c079680bb0fa ("drm/msm/dpu: Add support for MSM8937") >> Reported-by: Abhinav Kumar <quic_abhinavk@quicinc.com> >> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> >> --- > > With the commit message fixed: I like to copy-paste too.. this one needs no fixing Konrad
diff --git a/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_1_14_msm8937.h b/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_1_14_msm8937.h index ab3dfb0b374ead36c7f07b0a77c703fb2c09ff8a..a848f825c5948c5819758e131af60b83b543b15a 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_1_14_msm8937.h +++ b/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_1_14_msm8937.h @@ -100,14 +100,12 @@ static const struct dpu_pingpong_cfg msm8937_pp[] = { { .name = "pingpong_0", .id = PINGPONG_0, .base = 0x70000, .len = 0xd4, - .features = PINGPONG_MSM8996_MASK, .sblk = &msm8996_pp_sblk, .intr_done = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 8), .intr_rdptr = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 12), }, { .name = "pingpong_1", .id = PINGPONG_1, .base = 0x70800, .len = 0xd4, - .features = PINGPONG_MSM8996_MASK, .sblk = &msm8996_pp_sblk, .intr_done = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 9), .intr_rdptr = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 13),
The MSM8937 platform doesn't have DSC blocks nor does have it DSC registers in the PINGPONG block. Drop the DPU_PINGPONG_DSC feature bit from the PINGPONG's feature mask and, as it is the only remaining bit, drop the .features assignment completely. Fixes: c079680bb0fa ("drm/msm/dpu: Add support for MSM8937") Reported-by: Abhinav Kumar <quic_abhinavk@quicinc.com> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_1_14_msm8937.h | 2 -- 1 file changed, 2 deletions(-)