| Message ID | 20250228-edma_err-v1-1-d1869fe4163e@nxp.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | dmaengine: fsl-edma: add error irq to help debug problem | expand |
On Fri, Feb 28, 2025 at 12:42:03PM -0500, Frank Li wrote: > From: Joy Zou <joy.zou@nxp.com> > > The edma controller support optional error interrupt, so update interrupts > and interrupt-names's maxItems. This seems like something were you would know based on the soc (or compatible) whether or not 64 or 65 is the correct maximum for that device? > > Signed-off-by: Joy Zou <joy.zou@nxp.com> > Signed-off-by: Frank Li <Frank.Li@nxp.com> > --- > Documentation/devicetree/bindings/dma/fsl,edma.yaml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/dma/fsl,edma.yaml b/Documentation/devicetree/bindings/dma/fsl,edma.yaml > index 4f925469533e7..900170b3606ef 100644 > --- a/Documentation/devicetree/bindings/dma/fsl,edma.yaml > +++ b/Documentation/devicetree/bindings/dma/fsl,edma.yaml > @@ -40,11 +40,11 @@ properties: > > interrupts: > minItems: 1 > - maxItems: 64 > + maxItems: 65 > > interrupt-names: > minItems: 1 > - maxItems: 64 > + maxItems: 65 > > "#dma-cells": > description: | > > -- > 2.34.1 >
On Fri, Feb 28, 2025 at 06:13:50PM +0000, Conor Dooley wrote: > On Fri, Feb 28, 2025 at 12:42:03PM -0500, Frank Li wrote: > > From: Joy Zou <joy.zou@nxp.com> > > > > The edma controller support optional error interrupt, so update interrupts > > and interrupt-names's maxItems. > > This seems like something were you would know based on the soc (or > compatible) whether or not 64 or 65 is the correct maximum for that > device? Not exactly, 64 channel is maxium value, which IP supportted. There are difference instances in the same SOC. Some may only 31 dma channel, some may only 12, some have 64. Each channel have one irqs and one shared err irq. Ideally it should be property 'dma-channels' + 1. But not sure if schema can check such case. Frank > > > > > Signed-off-by: Joy Zou <joy.zou@nxp.com> > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > > --- > > Documentation/devicetree/bindings/dma/fsl,edma.yaml | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/dma/fsl,edma.yaml b/Documentation/devicetree/bindings/dma/fsl,edma.yaml > > index 4f925469533e7..900170b3606ef 100644 > > --- a/Documentation/devicetree/bindings/dma/fsl,edma.yaml > > +++ b/Documentation/devicetree/bindings/dma/fsl,edma.yaml > > @@ -40,11 +40,11 @@ properties: > > > > interrupts: > > minItems: 1 > > - maxItems: 64 > > + maxItems: 65 > > > > interrupt-names: > > minItems: 1 > > - maxItems: 64 > > + maxItems: 65 > > > > "#dma-cells": > > description: | > > > > -- > > 2.34.1 > >
On Fri, 28 Feb 2025 12:42:03 -0500, Frank Li wrote: > From: Joy Zou <joy.zou@nxp.com> > > The edma controller support optional error interrupt, so update interrupts > and interrupt-names's maxItems. > > Signed-off-by: Joy Zou <joy.zou@nxp.com> > Signed-off-by: Frank Li <Frank.Li@nxp.com> > --- > Documentation/devicetree/bindings/dma/fsl,edma.yaml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/dma/fsl,edma.yaml b/Documentation/devicetree/bindings/dma/fsl,edma.yaml index 4f925469533e7..900170b3606ef 100644 --- a/Documentation/devicetree/bindings/dma/fsl,edma.yaml +++ b/Documentation/devicetree/bindings/dma/fsl,edma.yaml @@ -40,11 +40,11 @@ properties: interrupts: minItems: 1 - maxItems: 64 + maxItems: 65 interrupt-names: minItems: 1 - maxItems: 64 + maxItems: 65 "#dma-cells": description: |