| Message ID | 20250228163117.47318-2-ziyao@disroot.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | arm64: dts: rockchip: Remove undocumented sdmmc property from lubancat-1 | expand |
On Fri Feb 28, 2025 at 5:31 PM CET, Yao Zi wrote: > Property "supports-cd" isn't documented anywhere and is unnecessary for s/supports-cd/supports-sd/ ? Cheers, Diederik > mainline driver to function. It seems a property used by downstream > kernel was brought into mainline. > > This should be reported by dtbs_check, but mmc-controller-common.yaml > defaults additionalProperties to true thus allows it. Remove the > property to clean the devicetree up and avoid possible confusion. > > Fixes: 8d94da58de53 ("arm64: dts: rockchip: Add EmbedFire LubanCat 1") > Signed-off-by: Yao Zi <ziyao@disroot.org> > --- > arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts b/arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts > index 61dd71c259aa..ddf84c2a19cf 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts > @@ -512,7 +512,6 @@ &sdhci { > > &sdmmc0 { > max-frequency = <150000000>; > - supports-sd; > bus-width = <4>; > cap-mmc-highspeed; > cap-sd-highspeed;
On Fri, Feb 28, 2025 at 05:55:47PM +0100, Diederik de Haas wrote: > On Fri Feb 28, 2025 at 5:31 PM CET, Yao Zi wrote: > > Property "supports-cd" isn't documented anywhere and is unnecessary for > > s/supports-cd/supports-sd/ ? Oops, yes, it's a typo. As it's a trival patch, could it be fixed on merging? Or should I send another version? > Cheers, > Diederik Thanks, Yao Zi > > mainline driver to function. It seems a property used by downstream > > kernel was brought into mainline. > > > > This should be reported by dtbs_check, but mmc-controller-common.yaml > > defaults additionalProperties to true thus allows it. Remove the > > property to clean the devicetree up and avoid possible confusion. > > > > Fixes: 8d94da58de53 ("arm64: dts: rockchip: Add EmbedFire LubanCat 1") > > Signed-off-by: Yao Zi <ziyao@disroot.org>
Hi, Am Freitag, 28. Februar 2025, 18:59:42 MEZ schrieb Yao Zi: > On Fri, Feb 28, 2025 at 05:55:47PM +0100, Diederik de Haas wrote: > > On Fri Feb 28, 2025 at 5:31 PM CET, Yao Zi wrote: > > > Property "supports-cd" isn't documented anywhere and is unnecessary for > > > > s/supports-cd/supports-sd/ ? > > Oops, yes, it's a typo. > > As it's a trival patch, could it be fixed on merging? Or should I send > another version? I can change that when applying. Heiko
On Fri, 28 Feb 2025 16:31:18 +0000, Yao Zi wrote: > Property "supports-cd" isn't documented anywhere and is unnecessary for > mainline driver to function. It seems a property used by downstream > kernel was brought into mainline. > > This should be reported by dtbs_check, but mmc-controller-common.yaml > defaults additionalProperties to true thus allows it. Remove the > property to clean the devicetree up and avoid possible confusion. > > [...] Applied, thanks! [1/1] arm64: dts: rockchip: Remove undocumented sdmmc property from lubancat-1 commit: 43c854c65e47d2f3763345683b06257b4d12e4e3 Best regards,
diff --git a/arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts b/arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts index 61dd71c259aa..ddf84c2a19cf 100644 --- a/arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts +++ b/arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts @@ -512,7 +512,6 @@ &sdhci { &sdmmc0 { max-frequency = <150000000>; - supports-sd; bus-width = <4>; cap-mmc-highspeed; cap-sd-highspeed;
Property "supports-cd" isn't documented anywhere and is unnecessary for mainline driver to function. It seems a property used by downstream kernel was brought into mainline. This should be reported by dtbs_check, but mmc-controller-common.yaml defaults additionalProperties to true thus allows it. Remove the property to clean the devicetree up and avoid possible confusion. Fixes: 8d94da58de53 ("arm64: dts: rockchip: Add EmbedFire LubanCat 1") Signed-off-by: Yao Zi <ziyao@disroot.org> --- arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts | 1 - 1 file changed, 1 deletion(-)