| Message ID | 20250224180529.1916812-1-willy@infradead.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | Orangefs fixes for 6.15 | expand |
Howdy Matthew... I got your patch and deciphered the note about leaving out the include files. It is compiling on top of Linux 6.14-rc4 now, and I'll let you know how testing goes... -Mike On Mon, Feb 24, 2025 at 1:05 PM Matthew Wilcox (Oracle) <willy@infradead.org> wrote: > > The start of this was the removal of orangefs_writepage(), but it > quickly spiralled out of hand. The first patch is an actual bug fix. > I haven't tagged it for backport, as I don't think we really care about > 32-bit systems any more, but feel free to add a cc to stable. > > Patches 2 and 3 are compilation fixes for warnings which aren't enabled > by default. > > Patches 4-9 are improvements which simplify orangefs or convert it > from pages to folios. There is still a little use of 'struct page' > in orangefs, but it's not in the areas that deal with the page cache. > > Matthew Wilcox (Oracle) (9): > orangefs: Do not truncate file size > orangefs: Move s_kmod_keyword_mask_map to orangefs-debugfs.c > orangefs: make open_for_read and open_for_write boolean > orangefs: Remove orangefs_writepage() > orangefs: Convert orangefs_writepage_locked() to take a folio > orangefs: Pass mapping to orangefs_writepages_work() > orangefs: Unify error & success paths in orangefs_writepages_work() > orangefs: Simplify bvec setup in orangefs_writepages_work() > orangefs: Convert orangefs_writepages to contain an array of folios > > fs/orangefs/file.c | 4 +- > fs/orangefs/inode.c | 149 ++++++++++++++------------------- > fs/orangefs/orangefs-debug.h | 43 ---------- > fs/orangefs/orangefs-debugfs.c | 43 ++++++++++ > include/linux/mm_types.h | 6 +- > include/linux/nfs_page.h | 2 +- > include/linux/page-flags.h | 6 +- > 7 files changed, 116 insertions(+), 137 deletions(-) > > -- > 2.47.2 >
Matthew... Thanks for the patch. I get no xfstests regressions with it... -Mike On Thu, Feb 27, 2025 at 3:18 PM Mike Marshall <hubcap@omnibond.com> wrote: > > Howdy Matthew... I got your patch and deciphered the note > about leaving out the include files. It is compiling on top of > Linux 6.14-rc4 now, and I'll let you know how testing goes... > > -Mike > > On Mon, Feb 24, 2025 at 1:05 PM Matthew Wilcox (Oracle) > <willy@infradead.org> wrote: > > > > The start of this was the removal of orangefs_writepage(), but it > > quickly spiralled out of hand. The first patch is an actual bug fix. > > I haven't tagged it for backport, as I don't think we really care about > > 32-bit systems any more, but feel free to add a cc to stable. > > > > Patches 2 and 3 are compilation fixes for warnings which aren't enabled > > by default. > > > > Patches 4-9 are improvements which simplify orangefs or convert it > > from pages to folios. There is still a little use of 'struct page' > > in orangefs, but it's not in the areas that deal with the page cache. > > > > Matthew Wilcox (Oracle) (9): > > orangefs: Do not truncate file size > > orangefs: Move s_kmod_keyword_mask_map to orangefs-debugfs.c > > orangefs: make open_for_read and open_for_write boolean > > orangefs: Remove orangefs_writepage() > > orangefs: Convert orangefs_writepage_locked() to take a folio > > orangefs: Pass mapping to orangefs_writepages_work() > > orangefs: Unify error & success paths in orangefs_writepages_work() > > orangefs: Simplify bvec setup in orangefs_writepages_work() > > orangefs: Convert orangefs_writepages to contain an array of folios > > > > fs/orangefs/file.c | 4 +- > > fs/orangefs/inode.c | 149 ++++++++++++++------------------- > > fs/orangefs/orangefs-debug.h | 43 ---------- > > fs/orangefs/orangefs-debugfs.c | 43 ++++++++++ > > include/linux/mm_types.h | 6 +- > > include/linux/nfs_page.h | 2 +- > > include/linux/page-flags.h | 6 +- > > 7 files changed, 116 insertions(+), 137 deletions(-) > > > > -- > > 2.47.2 > >