| Message ID | 20250225-topic-sm8x50-iris-v10-v1-1-128ef05d9665@linaro.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | media: qcom: iris: add support for SM8650 | expand |
On Tue, 25 Feb 2025 10:05:09 +0100, Neil Armstrong wrote: > Document the IRIS video decoder and encoder accelerator found in the > SM8650 platform, it requires 2 more reset lines in addition to the > properties required for the SM8550 platform. > > Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> > --- > .../bindings/media/qcom,sm8550-iris.yaml | 33 ++++++++++++++++++---- > 1 file changed, 28 insertions(+), 5 deletions(-) > Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
On 2/25/2025 2:35 PM, Neil Armstrong wrote: > Document the IRIS video decoder and encoder accelerator found in the > SM8650 platform, it requires 2 more reset lines in addition to the > properties required for the SM8550 platform. > > Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> > --- > .../bindings/media/qcom,sm8550-iris.yaml | 33 ++++++++++++++++++---- > 1 file changed, 28 insertions(+), 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml b/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml > index e424ea84c211f473a799481fd5463a16580187ed..536cf458dcb08141e5a1ec8c3df964196e599a57 100644 > --- a/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml > +++ b/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml > @@ -14,12 +14,11 @@ description: > The iris video processing unit is a video encode and decode accelerator > present on Qualcomm platforms. > > -allOf: > - - $ref: qcom,venus-common.yaml# > - > properties: > compatible: > - const: qcom,sm8550-iris > + enum: > + - qcom,sm8550-iris > + - qcom,sm8650-iris > > power-domains: > maxItems: 4 > @@ -49,11 +48,15 @@ properties: > - const: video-mem > > resets: > - maxItems: 1 > + minItems: 1 > + maxItems: 3 > > reset-names: > + minItems: 1 > items: > - const: bus > + - const: xo > + - const: core > > iommus: > maxItems: 2 > @@ -75,6 +78,26 @@ required: > - iommus > - dma-coherent > > +allOf: > + - $ref: qcom,venus-common.yaml# > + - if: > + properties: > + compatible: > + enum: > + - qcom,sm8650-iris > + then: > + properties: > + resets: > + minItems: 3 > + reset-names: > + minItems: 3 > + else: > + properties: > + resets: > + maxItems: 1 > + reset-names: > + maxItems: 1 > + > unevaluatedProperties: false > > examples: > Since we are using same binding for SM8550 and SM8650, I think, it would be good to rename this file to qcom,iris-commom.yaml Thanks, Dikshita
On 28/02/2025 13:21, Dikshita Agarwal wrote: > > > On 2/25/2025 2:35 PM, Neil Armstrong wrote: >> Document the IRIS video decoder and encoder accelerator found in the >> SM8650 platform, it requires 2 more reset lines in addition to the >> properties required for the SM8550 platform. >> >> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> >> --- >> .../bindings/media/qcom,sm8550-iris.yaml | 33 ++++++++++++++++++---- >> 1 file changed, 28 insertions(+), 5 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml b/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml >> index e424ea84c211f473a799481fd5463a16580187ed..536cf458dcb08141e5a1ec8c3df964196e599a57 100644 >> --- a/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml >> +++ b/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml >> @@ -14,12 +14,11 @@ description: >> The iris video processing unit is a video encode and decode accelerator >> present on Qualcomm platforms. >> >> -allOf: >> - - $ref: qcom,venus-common.yaml# >> - >> properties: >> compatible: >> - const: qcom,sm8550-iris >> + enum: >> + - qcom,sm8550-iris >> + - qcom,sm8650-iris >> >> power-domains: >> maxItems: 4 >> @@ -49,11 +48,15 @@ properties: >> - const: video-mem >> >> resets: >> - maxItems: 1 >> + minItems: 1 >> + maxItems: 3 >> >> reset-names: >> + minItems: 1 >> items: >> - const: bus >> + - const: xo >> + - const: core >> >> iommus: >> maxItems: 2 >> @@ -75,6 +78,26 @@ required: >> - iommus >> - dma-coherent >> >> +allOf: >> + - $ref: qcom,venus-common.yaml# >> + - if: >> + properties: >> + compatible: >> + enum: >> + - qcom,sm8650-iris >> + then: >> + properties: >> + resets: >> + minItems: 3 >> + reset-names: >> + minItems: 3 >> + else: >> + properties: >> + resets: >> + maxItems: 1 >> + reset-names: >> + maxItems: 1 >> + >> unevaluatedProperties: false >> >> examples: >> > Since we are using same binding for SM8550 and SM8650, I think, it would be > good to rename this file to qcom,iris-commom.yaml The usage is to name the file based on the first compatible introduce, and split/rename when adding new very different HW, here the difference is minimal so it's ok to keep the current name. Neil > > Thanks, > Dikshita
On 28/02/2025 13:21, Dikshita Agarwal wrote: >> + then: >> + properties: >> + resets: >> + minItems: 3 >> + reset-names: >> + minItems: 3 >> + else: >> + properties: >> + resets: >> + maxItems: 1 >> + reset-names: >> + maxItems: 1 >> + >> unevaluatedProperties: false >> >> examples: >> > Since we are using same binding for SM8550 and SM8650, I think, it would be > good to rename this file to qcom,iris-commom.yaml No. Please follow established upstream practices. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml b/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml index e424ea84c211f473a799481fd5463a16580187ed..536cf458dcb08141e5a1ec8c3df964196e599a57 100644 --- a/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml +++ b/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml @@ -14,12 +14,11 @@ description: The iris video processing unit is a video encode and decode accelerator present on Qualcomm platforms. -allOf: - - $ref: qcom,venus-common.yaml# - properties: compatible: - const: qcom,sm8550-iris + enum: + - qcom,sm8550-iris + - qcom,sm8650-iris power-domains: maxItems: 4 @@ -49,11 +48,15 @@ properties: - const: video-mem resets: - maxItems: 1 + minItems: 1 + maxItems: 3 reset-names: + minItems: 1 items: - const: bus + - const: xo + - const: core iommus: maxItems: 2 @@ -75,6 +78,26 @@ required: - iommus - dma-coherent +allOf: + - $ref: qcom,venus-common.yaml# + - if: + properties: + compatible: + enum: + - qcom,sm8650-iris + then: + properties: + resets: + minItems: 3 + reset-names: + minItems: 3 + else: + properties: + resets: + maxItems: 1 + reset-names: + maxItems: 1 + unevaluatedProperties: false examples:
Document the IRIS video decoder and encoder accelerator found in the SM8650 platform, it requires 2 more reset lines in addition to the properties required for the SM8550 platform. Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> --- .../bindings/media/qcom,sm8550-iris.yaml | 33 ++++++++++++++++++---- 1 file changed, 28 insertions(+), 5 deletions(-)