| Message ID | 20250304000940.9557-2-romank@linux.microsoft.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | scsi: storvsc: Don't report the host packet status as the hv status | expand |
On 3/3/2025 4:09 PM, Roman Kisel wrote: > The log statement reports the packet status code as the hv > status code which causes confusion when debugging as "hv" > might refer to a hypervisor, and sometimes to the host part > of the Hyper-V virtualization stack. > > Fix the name of the datum being logged to clearly indicate > the component reporting the error. Also log it in hexadecimal > everywhere for consistency. > > Signed-off-by: Roman Kisel <romank@linux.microsoft.com> > --- > drivers/scsi/storvsc_drv.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c > index a8614e54544e..35db061ae3ec 100644 > --- a/drivers/scsi/storvsc_drv.c > +++ b/drivers/scsi/storvsc_drv.c > @@ -776,7 +776,7 @@ static void handle_multichannel_storage(struct hv_device *device, int max_chns) > > if (vstor_packet->operation != VSTOR_OPERATION_COMPLETE_IO || > vstor_packet->status != 0) { > - dev_err(dev, "Failed to create sub-channel: op=%d, sts=%d\n", > + dev_err(dev, "Failed to create sub-channel: op=%d, host=0x%x\n", > vstor_packet->operation, vstor_packet->status); > return; > } > @@ -1183,7 +1183,7 @@ static void storvsc_on_io_completion(struct storvsc_device *stor_device, > STORVSC_LOGGING_WARN : STORVSC_LOGGING_ERROR; > > storvsc_log_ratelimited(device, loglevel, > - "tag#%d cmd 0x%x status: scsi 0x%x srb 0x%x hv 0x%x\n", > + "tag#%d cmd 0x%x status: scsi 0x%x srb 0x%x host 0x%x\n", > scsi_cmd_to_rq(request->cmd)->tag, > stor_pkt->vm_srb.cdb[0], > vstor_packet->vm_srb.scsi_status, Looks good to me. Reviewed-by: Easwar Hariharan <eahariha@linux.microsoft.com>
From: Roman Kisel <romank@linux.microsoft.com> Sent: Monday, March 3, 2025 4:10 PM > > The log statement reports the packet status code as the hv > status code which causes confusion when debugging as "hv" > might refer to a hypervisor, and sometimes to the host part > of the Hyper-V virtualization stack. > > Fix the name of the datum being logged to clearly indicate > the component reporting the error. Also log it in hexadecimal > everywhere for consistency. > > Signed-off-by: Roman Kisel <romank@linux.microsoft.com> > --- > drivers/scsi/storvsc_drv.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c > index a8614e54544e..35db061ae3ec 100644 > --- a/drivers/scsi/storvsc_drv.c > +++ b/drivers/scsi/storvsc_drv.c > @@ -776,7 +776,7 @@ static void handle_multichannel_storage(struct hv_device *device, int max_chns) > > if (vstor_packet->operation != VSTOR_OPERATION_COMPLETE_IO || > vstor_packet->status != 0) { > - dev_err(dev, "Failed to create sub-channel: op=%d, sts=%d\n", > + dev_err(dev, "Failed to create sub-channel: op=%d, host=0x%x\n", > vstor_packet->operation, vstor_packet->status); > return; > } > @@ -1183,7 +1183,7 @@ static void storvsc_on_io_completion(struct storvsc_device *stor_device, > STORVSC_LOGGING_WARN : STORVSC_LOGGING_ERROR; > > storvsc_log_ratelimited(device, loglevel, > - "tag#%d cmd 0x%x status: scsi 0x%x srb 0x%x hv 0x%x\n", > + "tag#%d cmd 0x%x status: scsi 0x%x srb 0x%x host 0x%x\n", > scsi_cmd_to_rq(request->cmd)->tag, > stor_pkt->vm_srb.cdb[0], > vstor_packet->vm_srb.scsi_status, I had not realized that handle_multichannel_storage() was displaying the host status in decimal! Ugh. Reviewed-by: Michael Kelley <mhklinux@outlook.com>
diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c index a8614e54544e..35db061ae3ec 100644 --- a/drivers/scsi/storvsc_drv.c +++ b/drivers/scsi/storvsc_drv.c @@ -776,7 +776,7 @@ static void handle_multichannel_storage(struct hv_device *device, int max_chns) if (vstor_packet->operation != VSTOR_OPERATION_COMPLETE_IO || vstor_packet->status != 0) { - dev_err(dev, "Failed to create sub-channel: op=%d, sts=%d\n", + dev_err(dev, "Failed to create sub-channel: op=%d, host=0x%x\n", vstor_packet->operation, vstor_packet->status); return; } @@ -1183,7 +1183,7 @@ static void storvsc_on_io_completion(struct storvsc_device *stor_device, STORVSC_LOGGING_WARN : STORVSC_LOGGING_ERROR; storvsc_log_ratelimited(device, loglevel, - "tag#%d cmd 0x%x status: scsi 0x%x srb 0x%x hv 0x%x\n", + "tag#%d cmd 0x%x status: scsi 0x%x srb 0x%x host 0x%x\n", scsi_cmd_to_rq(request->cmd)->tag, stor_pkt->vm_srb.cdb[0], vstor_packet->vm_srb.scsi_status,
The log statement reports the packet status code as the hv status code which causes confusion when debugging as "hv" might refer to a hypervisor, and sometimes to the host part of the Hyper-V virtualization stack. Fix the name of the datum being logged to clearly indicate the component reporting the error. Also log it in hexadecimal everywhere for consistency. Signed-off-by: Roman Kisel <romank@linux.microsoft.com> --- drivers/scsi/storvsc_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)