mbox series

[isar-cip-core,v2,0/2] Test reproducibility of wic images

Message ID 20250226083239.601295-1-Adithya.Balakumar@toshiba-tsip.com (mailing list archive)
Headers show
Series Test reproducibility of wic images | expand

Message

Adithya Balakumar Feb. 26, 2025, 8:32 a.m. UTC 
From: Adithya Balakumar <Adithya.Balakumar@toshiba-tsip.com>

Currently only the individual partition images are checked in the
reproducibility test. This patch set tests reproducibility of entire
disk image too.

Changes since v1:
- Addressed shellcheck warnings apart from the one mentioned below

In scripts/repro-tests.sh line 63:
set -- $remaining_vars
       ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Since word splitting is what I want in the scenario, I suppressed the
warning in the script

Adithya Balakumar (2):
  .reproducible-check-ci.yml: Upload wic files for reproducibility test
  scripts/repro-tests.sh: Update script to check wic file
    reproducibility

 .reproducible-check-ci.yml | 10 ++++-
 scripts/repro-tests.sh     | 92 +++++++++++++++++++++++++-------------
 2 files changed, 69 insertions(+), 33 deletions(-)

Comments

Jan Kiszka March 4, 2025, 5:12 a.m. UTC | #1 
On 26.02.25 09:32, Adithya.Balakumar@toshiba-tsip.com wrote:
> From: Adithya Balakumar <Adithya.Balakumar@toshiba-tsip.com>
> 
> Currently only the individual partition images are checked in the
> reproducibility test. This patch set tests reproducibility of entire
> disk image too.
> 
> Changes since v1:
> - Addressed shellcheck warnings apart from the one mentioned below
> 
> In scripts/repro-tests.sh line 63:
> set -- $remaining_vars
>        ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
> 
> Since word splitting is what I want in the scenario, I suppressed the
> warning in the script
> 
> Adithya Balakumar (2):
>   .reproducible-check-ci.yml: Upload wic files for reproducibility test
>   scripts/repro-tests.sh: Update script to check wic file
>     reproducibility
> 
>  .reproducible-check-ci.yml | 10 ++++-
>  scripts/repro-tests.sh     | 92 +++++++++++++++++++++++++-------------
>  2 files changed, 69 insertions(+), 33 deletions(-)
> 

Thanks, applied.

Jan