| Message ID | 20250304-mt7988-flooding-fix-v1-1-905523ae83e9@kernel.org (mailing list archive) |
|---|---|
| State | New |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] net: dsa: mt7530: Fix traffic flooding for MMIO devices | expand |
On 04/03/2025 08:50, Lorenzo Bianconi wrote: > On MMIO devices (e.g. MT7988 or EN7581) unicast traffic received on lanX > port is flooded on all other user ports if the DSA switch is configured > without VLAN support since PORT_MATRIX in PCR regs contains all user > ports. Similar to MDIO devices (e.g. MT7530 and MT7531) fix the issue > defining default VLAN-ID 0 for MT7530 MMIO devices. > > Fixes: 110c18bfed414 ("net: dsa: mt7530: introduce driver for MT7988 built-in switch") > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org> I was suspecting of this for a while. Thanks for addressing it. Reviewed-by: Chester A. Unal <chester.a.unal@arinc9.com> Chester A.
diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c index 1c83af805209cae40c56138fa8f72261e396f58c..5883eb93efb11423bec260a11ff8b60cfff1fd2c 100644 --- a/drivers/net/dsa/mt7530.c +++ b/drivers/net/dsa/mt7530.c @@ -2591,7 +2591,8 @@ mt7531_setup_common(struct dsa_switch *ds) if (ret < 0) return ret; - return 0; + /* Setup VLAN ID 0 for VLAN-unaware bridges */ + return mt7530_setup_vlan0(priv); } static int @@ -2687,11 +2688,6 @@ mt7531_setup(struct dsa_switch *ds) if (ret) return ret; - /* Setup VLAN ID 0 for VLAN-unaware bridges */ - ret = mt7530_setup_vlan0(priv); - if (ret) - return ret; - ds->assisted_learning_on_cpu_port = true; ds->mtu_enforcement_ingress = true;
On MMIO devices (e.g. MT7988 or EN7581) unicast traffic received on lanX port is flooded on all other user ports if the DSA switch is configured without VLAN support since PORT_MATRIX in PCR regs contains all user ports. Similar to MDIO devices (e.g. MT7530 and MT7531) fix the issue defining default VLAN-ID 0 for MT7530 MMIO devices. Fixes: 110c18bfed414 ("net: dsa: mt7530: introduce driver for MT7988 built-in switch") Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org> --- drivers/net/dsa/mt7530.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) --- base-commit: 64e6a754d33d31aa844b3ee66fb93ac84ca1565e change-id: 20250304-mt7988-flooding-fix-cdfec66a0640 Best regards,