| Message ID | 20250304135456.429407-1-jani.nikula@intel.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | drm/appletbdrm: fix format character for size_t | expand |
> On 4 Mar 2025, at 7:25 PM, Jani Nikula <jani.nikula@intel.com> wrote: > > Use %zu for size_t instead of %lu to avoid failures on 32-bit builds: > > error: format ‘%lu’ expects argument of type ‘long unsigned int’, but > argument 4 has type ‘size_t’ {aka ‘unsigned int’} > > Fixes: 0670c2f56e45 ("drm/tiny: add driver for Apple Touch Bars in x86 Macs") > Cc: Kerem Karabay <kekrby@gmail.com> > Cc: Atharva Tiwari <evepolonium@gmail.com> > Cc: Aditya Garg <gargaditya08@live.com> > Cc: Aun-Ali Zaidi <admin@kodeit.net> > Cc: Thomas Zimmermann <tzimmermann@suse.de> > Signed-off-by: Jani Nikula <jani.nikula@intel.com> > --- > drivers/gpu/drm/tiny/appletbdrm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) LGTM Acked-by: Aditya Garg <gargaditya08@live.com>
diff --git a/drivers/gpu/drm/tiny/appletbdrm.c b/drivers/gpu/drm/tiny/appletbdrm.c index f5d177e234e4..394c8f9bd41a 100644 --- a/drivers/gpu/drm/tiny/appletbdrm.c +++ b/drivers/gpu/drm/tiny/appletbdrm.c @@ -167,7 +167,7 @@ static int appletbdrm_send_request(struct appletbdrm_device *adev, } if (actual_size != size) { - drm_err(drm, "Actual size (%d) doesn't match expected size (%lu)\n", + drm_err(drm, "Actual size (%d) doesn't match expected size (%zu)\n", actual_size, size); return -EIO; } @@ -208,7 +208,7 @@ static int appletbdrm_read_response(struct appletbdrm_device *adev, } if (actual_size != size) { - drm_err(drm, "Actual size (%d) doesn't match expected size (%lu)\n", + drm_err(drm, "Actual size (%d) doesn't match expected size (%zu)\n", actual_size, size); return -EBADMSG; }
Use %zu for size_t instead of %lu to avoid failures on 32-bit builds: error: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 4 has type ‘size_t’ {aka ‘unsigned int’} Fixes: 0670c2f56e45 ("drm/tiny: add driver for Apple Touch Bars in x86 Macs") Cc: Kerem Karabay <kekrby@gmail.com> Cc: Atharva Tiwari <evepolonium@gmail.com> Cc: Aditya Garg <gargaditya08@live.com> Cc: Aun-Ali Zaidi <admin@kodeit.net> Cc: Thomas Zimmermann <tzimmermann@suse.de> Signed-off-by: Jani Nikula <jani.nikula@intel.com> --- drivers/gpu/drm/tiny/appletbdrm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)