| Message ID | 20250304142803.689201-1-arnd@kernel.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | pmdomain: rockchip: add regulator dependency | expand |
Hi, On Tue, Mar 04, 2025 at 03:27:59PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > When CONFIG_REGULATOR is disabled, this pmdomain driver fails to build: > > drivers/pmdomain/rockchip/pm-domains.c:653:30: error: implicit declaration of function 'devm_of_regulator_get'; did you mean 'devm_regulator_get'? [-Wimplicit-function-declaration] > 653 | pd->supply = devm_of_regulator_get(pmu->dev, pd->node, "domain"); > | ^~~~~~~~~~~~~~~~~~~~~ > | devm_regulator_get > drivers/pmdomain/rockchip/pm-domains.c:653:28: error: assignment to 'struct regulator *' from 'int' makes pointer from integer without a cast [-Wint-conversion] > 653 | pd->supply = devm_of_regulator_get(pmu->dev, pd->node, "domain"); > | ^ > > Add a Kconfig dependency. > > Fixes: db6df2e3fc16 ("pmdomain: rockchip: add regulator support") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com> -- Sebastian > drivers/pmdomain/rockchip/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pmdomain/rockchip/Kconfig b/drivers/pmdomain/rockchip/Kconfig > index 7e4f9b628f0b..218d43186e5b 100644 > --- a/drivers/pmdomain/rockchip/Kconfig > +++ b/drivers/pmdomain/rockchip/Kconfig > @@ -5,6 +5,7 @@ config ROCKCHIP_PM_DOMAINS > bool "Rockchip generic power domain" > depends on PM > depends on HAVE_ARM_SMCCC_DISCOVERY > + depends on REGULATOR > select PM_GENERIC_DOMAINS > help > Say y here to enable power domain support. > -- > 2.39.5 >
Hello Arnd, On 2025-03-04 15:27, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > When CONFIG_REGULATOR is disabled, this pmdomain driver fails to build: > > drivers/pmdomain/rockchip/pm-domains.c:653:30: error: implicit > declaration of function 'devm_of_regulator_get'; did you mean > 'devm_regulator_get'? [-Wimplicit-function-declaration] > 653 | pd->supply = devm_of_regulator_get(pmu->dev, > pd->node, "domain"); > | ^~~~~~~~~~~~~~~~~~~~~ > | devm_regulator_get > drivers/pmdomain/rockchip/pm-domains.c:653:28: error: assignment to > 'struct regulator *' from 'int' makes pointer from integer without a > cast [-Wint-conversion] > 653 | pd->supply = devm_of_regulator_get(pmu->dev, > pd->node, "domain"); > | ^ > > Add a Kconfig dependency. > > Fixes: db6df2e3fc16 ("pmdomain: rockchip: add regulator support") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/pmdomain/rockchip/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pmdomain/rockchip/Kconfig > b/drivers/pmdomain/rockchip/Kconfig > index 7e4f9b628f0b..218d43186e5b 100644 > --- a/drivers/pmdomain/rockchip/Kconfig > +++ b/drivers/pmdomain/rockchip/Kconfig > @@ -5,6 +5,7 @@ config ROCKCHIP_PM_DOMAINS > bool "Rockchip generic power domain" > depends on PM > depends on HAVE_ARM_SMCCC_DISCOVERY > + depends on REGULATOR > select PM_GENERIC_DOMAINS > help > Say y here to enable power domain support. Looking good to me, thanks for this patch. Reviewed-by: Dragan Simic <dsimic@manjaro.org>
diff --git a/drivers/pmdomain/rockchip/Kconfig b/drivers/pmdomain/rockchip/Kconfig index 7e4f9b628f0b..218d43186e5b 100644 --- a/drivers/pmdomain/rockchip/Kconfig +++ b/drivers/pmdomain/rockchip/Kconfig @@ -5,6 +5,7 @@ config ROCKCHIP_PM_DOMAINS bool "Rockchip generic power domain" depends on PM depends on HAVE_ARM_SMCCC_DISCOVERY + depends on REGULATOR select PM_GENERIC_DOMAINS help Say y here to enable power domain support.