mbox series

[net-next,0/3] eth: fbnic: Cleanup macros and string function

Message ID 20250228191935.3953712-1-lee@trager.us (mailing list archive)
Headers show
Series eth: fbnic: Cleanup macros and string function | expand

Message

Lee Trager Feb. 28, 2025, 7:15 p.m. UTC
We have received some feedback that the macros we use for reading FW mailbox
attributes are too large in scope and confusing to understanding. Additionally
the string function did not provide errors allowing it to silently succeed.
This patch set fixes theses issues.

Lee Trager (3):
  eth: fbnic: Prepend TSENE FW fields with FBNIC_FW
  eth: fbnic: Update fbnic_tlv_attr_get_string() to work like
    nla_strscpy()
  eth: fbnic: Replace firmware field macros

 drivers/net/ethernet/meta/fbnic/fbnic_fw.c  | 109 ++++++++++----------
 drivers/net/ethernet/meta/fbnic/fbnic_fw.h  |   8 +-
 drivers/net/ethernet/meta/fbnic/fbnic_tlv.c |  55 +++++++---
 drivers/net/ethernet/meta/fbnic/fbnic_tlv.h |  39 ++-----
 4 files changed, 110 insertions(+), 101 deletions(-)

--
2.43.5

Comments

Jakub Kicinski March 5, 2025, 2:50 a.m. UTC | #1
On Fri, 28 Feb 2025 11:15:25 -0800 Lee Trager wrote:
> We have received some feedback that the macros we use for reading FW mailbox
> attributes are too large in scope and confusing to understanding. Additionally
> the string function did not provide errors allowing it to silently succeed.
> This patch set fixes theses issues.

Applied, thanks!