mbox series

[v8,net-next,0/5] PHC support in ENA driver

Message ID 20250304190504.3743-1-darinzon@amazon.com (mailing list archive)
Headers show
Series PHC support in ENA driver | expand

Message

Arinzon, David March 4, 2025, 7:04 p.m. UTC 
Changes in v8:
- Create a sysfs entry for each PHC stat

Changes in v7 (https://lore.kernel.org/netdev/20250218183948.757-1-darinzon@amazon.com/):
- Move PHC stats to sysfs
- Add information about PHC enablement
- Remove unrelated style changes

Changes in v6 (https://lore.kernel.org/netdev/20250206141538.549-1-darinzon@amazon.com/):
- Remove PHC error bound

Changes in v5 (https://lore.kernel.org/netdev/20250122102040.752-1-darinzon@amazon.com/):
- Add PHC error bound
- Add PHC enablement and error bound retrieval through sysfs

Changes in v4 (https://lore.kernel.org/netdev/20241114095930.200-1-darinzon@amazon.com/):
- Minor documentation change (resolution instead of accuracy)

Changes in v3 (https://lore.kernel.org/netdev/20241103113140.275-1-darinzon@amazon.com/):
- Resolve a compilation error

Changes in v2 (https://lore.kernel.org/netdev/20241031085245.18146-1-darinzon@amazon.com/):
- CCd PTP maintainer
- Fixed style issues
- Fixed documentation warning

v1 (https://lore.kernel.org/netdev/20241021052011.591-1-darinzon@amazon.com/)

This patchset adds the support for PHC (PTP Hardware Clock)
in the ENA driver. The documentation part of the patchset
includes additional information, including statistics,
utilization and invocation examples through the testptp
utility.

David Arinzon (5):
  net: ena: Add PHC support in the ENA driver
  net: ena: PHC silent reset
  net: ena: PHC enable through sysfs
  net: ena: PHC stats through sysfs
  net: ena: Add PHC documentation

 .../device_drivers/ethernet/amazon/ena.rst    |  96 +++++++
 drivers/net/ethernet/amazon/Kconfig           |   1 +
 drivers/net/ethernet/amazon/ena/Makefile      |   2 +-
 .../net/ethernet/amazon/ena/ena_admin_defs.h  |  63 ++++-
 drivers/net/ethernet/amazon/ena/ena_com.c     | 247 ++++++++++++++++++
 drivers/net/ethernet/amazon/ena/ena_com.h     |  83 ++++++
 drivers/net/ethernet/amazon/ena/ena_ethtool.c |  16 +-
 drivers/net/ethernet/amazon/ena/ena_netdev.c  |  44 +++-
 drivers/net/ethernet/amazon/ena/ena_netdev.h  |   6 +
 drivers/net/ethernet/amazon/ena/ena_phc.c     | 230 ++++++++++++++++
 drivers/net/ethernet/amazon/ena/ena_phc.h     |  37 +++
 .../net/ethernet/amazon/ena/ena_regs_defs.h   |   8 +
 drivers/net/ethernet/amazon/ena/ena_sysfs.c   | 163 ++++++++++++
 drivers/net/ethernet/amazon/ena/ena_sysfs.h   |  28 ++
 14 files changed, 1014 insertions(+), 10 deletions(-)
 create mode 100644 drivers/net/ethernet/amazon/ena/ena_phc.c
 create mode 100644 drivers/net/ethernet/amazon/ena/ena_phc.h
 create mode 100644 drivers/net/ethernet/amazon/ena/ena_sysfs.c
 create mode 100644 drivers/net/ethernet/amazon/ena/ena_sysfs.h

Comments

Jakub Kicinski March 4, 2025, 11 p.m. UTC | #1 
On Tue, 4 Mar 2025 21:04:59 +0200 David Arinzon wrote:
> Changes in v8:
> - Create a sysfs entry for each PHC stat

coccicheck says:

drivers/net/ethernet/amazon/ena/ena_sysfs.c:80:8-16: WARNING: please use sysfs_emit or sysfs_emit_at
drivers/net/ethernet/amazon/ena/ena_sysfs.c:61:8-16: WARNING: please use sysfs_emit or sysfs_emit_at
drivers/net/ethernet/amazon/ena/ena_sysfs.c:125:8-16: WARNING: please use sysfs_emit or sysfs_emit_at
drivers/net/ethernet/amazon/ena/ena_sysfs.c:95:8-16: WARNING: please use sysfs_emit or sysfs_emit_at
drivers/net/ethernet/amazon/ena/ena_sysfs.c:110:8-16: WARNING: please use sysfs_emit or sysfs_emit_at
Arinzon, David March 5, 2025, 6:34 a.m. UTC | #2 
> > Changes in v8:
> > - Create a sysfs entry for each PHC stat
> 
> coccicheck says:
> 
> drivers/net/ethernet/amazon/ena/ena_sysfs.c:80:8-16: WARNING: please
> use sysfs_emit or sysfs_emit_at
> drivers/net/ethernet/amazon/ena/ena_sysfs.c:61:8-16: WARNING: please
> use sysfs_emit or sysfs_emit_at
> drivers/net/ethernet/amazon/ena/ena_sysfs.c:125:8-16: WARNING: please
> use sysfs_emit or sysfs_emit_at
> drivers/net/ethernet/amazon/ena/ena_sysfs.c:95:8-16: WARNING: please
> use sysfs_emit or sysfs_emit_at
> drivers/net/ethernet/amazon/ena/ena_sysfs.c:110:8-16: WARNING: please
> use sysfs_emit or sysfs_emit_at
> --
> pw-bot: cr

Thank you, Jakub.
Will fix in v9