diff mbox series

ASoC: rt1320: set wake_capable = 0 explicitly

Message ID 20250305134113.201326-1-yung-chuan.liao@linux.intel.com (mailing list archive)
State Accepted
Commit 927e6bec5cf3624665b0a2e9f64a1d32f3d22cdd
Headers show
Series ASoC: rt1320: set wake_capable = 0 explicitly | expand

Commit Message

Bard Liao March 5, 2025, 1:41 p.m. UTC 
"generic_new_peripheral_assigned: invalid dev_num 1, wake supported 1"
is reported by our internal CI test.

Rt1320's wake feature is not used in Linux and that's why it is not in
the wake_capable_list[] list in intel_auxdevice.c.
However, BIOS may set it as wake-capable. Overwrite wake_capable to 0
in the codec driver to align with wake_capable_list[].

Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Péter Ujfalusi <peter.ujfalusi@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Acked-by: Shuming Fan <shumingf@realtek.com>
---
 sound/soc/codecs/rt1320-sdw.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Mark Brown March 5, 2025, 4:54 p.m. UTC | #1 
On Wed, 05 Mar 2025 21:41:13 +0800, Bard Liao wrote:
> "generic_new_peripheral_assigned: invalid dev_num 1, wake supported 1"
> is reported by our internal CI test.
> 
> Rt1320's wake feature is not used in Linux and that's why it is not in
> the wake_capable_list[] list in intel_auxdevice.c.
> However, BIOS may set it as wake-capable. Overwrite wake_capable to 0
> in the codec driver to align with wake_capable_list[].
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: rt1320: set wake_capable = 0 explicitly
      commit: 927e6bec5cf3624665b0a2e9f64a1d32f3d22cdd

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark
diff mbox series

Patch

diff --git a/sound/soc/codecs/rt1320-sdw.c b/sound/soc/codecs/rt1320-sdw.c
index 3510c3819074..d83b236a0450 100644
--- a/sound/soc/codecs/rt1320-sdw.c
+++ b/sound/soc/codecs/rt1320-sdw.c
@@ -535,6 +535,9 @@  static int rt1320_read_prop(struct sdw_slave *slave)
 	/* set the timeout values */
 	prop->clk_stop_timeout = 64;
 
+	/* BIOS may set wake_capable. Make sure it is 0 as wake events are disabled. */
+	prop->wake_capable = 0;
+
 	return 0;
 }