mbox series

[v2,0/2] phy: freescale: imx8m-pcie: fix and cleanup phy

Message ID 20250305144355.20364-1-eichest@gmail.com (mailing list archive)
Headers show
Series phy: freescale: imx8m-pcie: fix and cleanup phy | expand

Message

Stefan Eichenberger March 5, 2025, 2:43 p.m. UTC 
The imx8m-pcie PHY PLL fails to lock under certain conditions when
returning from suspend. This is resolved by asserting the PHY reset when
powering off the PHY during suspend. This ensures that the PHY is
properly reset when powering on again in resume.

Changes in v2:
- Remove unnecessary check if perst is not null (Philipp)

Stefan Eichenberger (2):
  phy: freescale: imx8m-pcie: cleanup reset logic
  phy: freescale: imx8m-pcie: assert phy reset and perst in power off

 drivers/phy/freescale/phy-fsl-imx8m-pcie.c | 23 +++++++++++++---------
 1 file changed, 14 insertions(+), 9 deletions(-)

Comments

Richard Zhu March 6, 2025, 12:24 a.m. UTC | #1 
Hi Stefan:
Thanks for the clean up and bug fix. Please update the commit with Frank's comments.
For this series, Acked-by: Richard Zhu <hongxing.zhu@nxp.com>

Best Regards
Richard Zhu

> -----Original Message-----
> From: Stefan Eichenberger <eichest@gmail.com>
> Sent: 2025年3月5日 22:43
> To: vkoul@kernel.org; kishon@kernel.org; shawnguo@kernel.org;
> s.hauer@pengutronix.de; kernel@pengutronix.de; festevam@gmail.com;
> p.zabel@pengutronix.de; tharvey@gateworks.com; Hongxing Zhu
> <hongxing.zhu@nxp.com>; Francesco Dolcini <francesco.dolcini@toradex.com>
> Cc: linux-phy@lists.infradead.org; imx@lists.linux.dev;
> linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org
> Subject: [PATCH v2 0/2] phy: freescale: imx8m-pcie: fix and cleanup phy
> 
> The imx8m-pcie PHY PLL fails to lock under certain conditions when returning
> from suspend. This is resolved by asserting the PHY reset when powering off the
> PHY during suspend. This ensures that the PHY is properly reset when powering
> on again in resume.
> 
> Changes in v2:
> - Remove unnecessary check if perst is not null (Philipp)
> 
> Stefan Eichenberger (2):
>   phy: freescale: imx8m-pcie: cleanup reset logic
>   phy: freescale: imx8m-pcie: assert phy reset and perst in power off
> 
>  drivers/phy/freescale/phy-fsl-imx8m-pcie.c | 23 +++++++++++++---------
>  1 file changed, 14 insertions(+), 9 deletions(-)
> 
> --
> 2.45.2
Vinod Koul March 10, 2025, 8:13 p.m. UTC | #2 
On Wed, 05 Mar 2025 15:43:14 +0100, Stefan Eichenberger wrote:
> The imx8m-pcie PHY PLL fails to lock under certain conditions when
> returning from suspend. This is resolved by asserting the PHY reset when
> powering off the PHY during suspend. This ensures that the PHY is
> properly reset when powering on again in resume.
> 
> Changes in v2:
> - Remove unnecessary check if perst is not null (Philipp)
> 
> [...]

Applied, thanks!

[1/2] phy: freescale: imx8m-pcie: cleanup reset logic
      commit: 97e8a2ff28a3dc36ca3cdc94f37359852d7e1c8b
[2/2] phy: freescale: imx8m-pcie: assert phy reset and perst in power off
      commit: aecb63e88c5e5fb9afb782a1577264c76f179af9

Best regards,