| Message ID | 20250305-perf-calc-fix-v1-1-d57f356caf59@quicinc.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | drm/msm/dpu: Clear perf params before calculating bw | expand |
On 3/5/2025 7:46 PM, Jessica Zhang wrote: > To prevent incorrect BW calculation, zero out dpu_core_perf_params > before it is passed into dpu_core_perf_aggregate(). > > Signed-off-by: Jessica Zhang <quic_jesszhan@quicinc.com> > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Fixes: 795aef6f3653 ("drm/msm/dpu: remove duplicate code calculating sum of bandwidths") Good catch! Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com> > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c > index 7ff3405c68675..0fb5789c60d0d 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c > @@ -164,7 +164,7 @@ int dpu_core_perf_crtc_check(struct drm_crtc *crtc, > u32 bw, threshold; > struct dpu_crtc_state *dpu_cstate; > struct dpu_kms *kms; > - struct dpu_core_perf_params perf; > + struct dpu_core_perf_params perf = { 0 }; > > if (!crtc || !state) { > DPU_ERROR("invalid crtc\n"); > > --- > base-commit: 6d3175a72cc07e90f81fb35841048a8a9b5134cb > change-id: 20250305-perf-calc-fix-07147a3ff410 > > Best regards,
On Wed, Mar 05, 2025 at 07:46:44PM -0800, Jessica Zhang wrote: > To prevent incorrect BW calculation, zero out dpu_core_perf_params > before it is passed into dpu_core_perf_aggregate(). > > Signed-off-by: Jessica Zhang <quic_jesszhan@quicinc.com> > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c index 7ff3405c68675..0fb5789c60d0d 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c @@ -164,7 +164,7 @@ int dpu_core_perf_crtc_check(struct drm_crtc *crtc, u32 bw, threshold; struct dpu_crtc_state *dpu_cstate; struct dpu_kms *kms; - struct dpu_core_perf_params perf; + struct dpu_core_perf_params perf = { 0 }; if (!crtc || !state) { DPU_ERROR("invalid crtc\n");
To prevent incorrect BW calculation, zero out dpu_core_perf_params before it is passed into dpu_core_perf_aggregate(). Signed-off-by: Jessica Zhang <quic_jesszhan@quicinc.com> --- drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- base-commit: 6d3175a72cc07e90f81fb35841048a8a9b5134cb change-id: 20250305-perf-calc-fix-07147a3ff410 Best regards,