diff mbox series

XSM: correct xsm_get_domain_state()

Message ID dbc6907e-e23b-4216-828a-ce7c4b581a20@suse.com (mailing list archive)
State New
Headers show
Series XSM: correct xsm_get_domain_state() | expand

Commit Message

Jan Beulich March 6, 2025, 2:16 p.m. UTC
Add the missing first parameter and move it next to a close relative.

Fixes: 3ad3df1bd0aa ("xen: add new domctl get_domain_state")
Signed-off-by: Jan Beulich <jbeulich@suse.com>

Comments

Andrew Cooper March 6, 2025, 2:18 p.m. UTC | #1
On 06/03/2025 2:16 pm, Jan Beulich wrote:
> Add the missing first parameter and move it next to a close relative.
>
> Fixes: 3ad3df1bd0aa ("xen: add new domctl get_domain_state")
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
Daniel P. Smith March 6, 2025, 2:23 p.m. UTC | #2
On 3/6/25 09:16, Jan Beulich wrote:
> Add the missing first parameter and move it next to a close relative.
> 
> Fixes: 3ad3df1bd0aa ("xen: add new domctl get_domain_state")
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Daniel P. Smith <dpsmith@apertussolutions.com>
Juergen Gross March 6, 2025, 2:38 p.m. UTC | #3
On 06.03.25 15:16, Jan Beulich wrote:
> Add the missing first parameter and move it next to a close relative.
> 
> Fixes: 3ad3df1bd0aa ("xen: add new domctl get_domain_state")
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Juergen Gross <jgross@suse.com>

With this patch you can ignore my patch just sent out, I guess. :-)


Juergen
diff mbox series

Patch

--- a/xen/include/xsm/xsm.h
+++ b/xen/include/xsm/xsm.h
@@ -231,6 +231,11 @@  static inline int xsm_getdomaininfo(xsm_
     return alternative_call(xsm_ops.getdomaininfo, d);
 }
 
+static inline int xsm_get_domain_state(xsm_default_t def, struct domain *d)
+{
+    return alternative_call(xsm_ops.get_domain_state, d);
+}
+
 static inline int xsm_domctl_scheduler_op(
     xsm_default_t def, struct domain *d, int cmd)
 {
@@ -775,11 +780,6 @@  static inline int xsm_argo_send(const st
 
 #endif /* CONFIG_ARGO */
 
-static inline int xsm_get_domain_state(struct domain *d)
-{
-    return alternative_call(xsm_ops.get_domain_state, d);
-}
-
 #endif /* XSM_NO_WRAPPERS */
 
 #ifdef CONFIG_MULTIBOOT