| Message ID | 20250306160003.587816-1-luiz.dentz@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 04cd5d2a97c887938ff53b621a4a4a6cc7eec967 |
| Headers | show |
| Series | [BlueZ,v1] btdev: Fix scan-build warnings | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/BuildEll | success | Build ELL PASS |
| tedd_an/BluezMake | success | Bluez Make PASS |
| tedd_an/MakeCheck | success | Bluez Make Check PASS |
| tedd_an/MakeDistcheck | success | Make Distcheck PASS |
| tedd_an/CheckValgrind | success | Check Valgrind PASS |
| tedd_an/CheckSmatch | warning | CheckSparse WARNING emulator/btdev.c:450:29: warning: Variable length array is used. |
| tedd_an/bluezmakeextell | success | Make External ELL PASS |
| tedd_an/ScanBuild | success | Scan Build PASS |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=941078 ---Test result--- Test Summary: CheckPatch PENDING 0.21 seconds GitLint PENDING 0.21 seconds BuildEll PASS 20.77 seconds BluezMake PASS 1518.85 seconds MakeCheck PASS 13.48 seconds MakeDistcheck PASS 157.01 seconds CheckValgrind PASS 212.28 seconds CheckSmatch WARNING 281.44 seconds bluezmakeextell PASS 97.61 seconds IncrementalBuild PENDING 0.29 seconds ScanBuild PASS 852.14 seconds Details ############################## Test: CheckPatch - PENDING Desc: Run checkpatch.pl script Output: ############################## Test: GitLint - PENDING Desc: Run gitlint Output: ############################## Test: CheckSmatch - WARNING Desc: Run smatch tool with source Output: emulator/btdev.c:450:29: warning: Variable length array is used. ############################## Test: IncrementalBuild - PENDING Desc: Incremental build with the patches in the series Output: --- Regards, Linux Bluetooth
Hello: This patch was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Thu, 6 Mar 2025 11:00:03 -0500 you wrote: > From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com> > > This fixes the following scan-build warnings: > > emulator/btdev.c:1126:10: warning: Although the value stored to 'conn' is used in the enclosing expression, the value is never actually read from 'conn' [deadcode.DeadStores] > 1126 | while ((conn = queue_find(dev->conns, match_handle, > | ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > 1127 | UINT_TO_PTR(handle)))) > | ~~~~~~~~~~~~~~~~~~~~ > emulator/btdev.c:1413:24: warning: Access to field 'link' results in a dereference of a null pointer (loaded from variable 'conn') [core.NullDereference] > 1413 | pending_conn_del(dev, conn->link->dev); > | ^~~~~~~~~~ > emulator/btdev.c:1535:13: warning: Access to field 'dev' results in a dereference of a null pointer (loaded from variable 'conn') [core.NullDereference] > 1535 | send_event(conn->dev, BT_HCI_EVT_AUTH_COMPLETE, &ev, sizeof(ev)); > | ^~~~~~~~~ > > [...] Here is the summary with links: - [BlueZ,v1] btdev: Fix scan-build warnings https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=04cd5d2a97c8 You are awesome, thank you!
diff --git a/emulator/btdev.c b/emulator/btdev.c index ec52c5242df0..77d44ad84548 100644 --- a/emulator/btdev.c +++ b/emulator/btdev.c @@ -1123,8 +1123,7 @@ static struct btdev_conn *conn_new(struct btdev *dev, uint16_t handle, { struct btdev_conn *conn; - while ((conn = queue_find(dev->conns, match_handle, - UINT_TO_PTR(handle)))) + while (queue_find(dev->conns, match_handle, UINT_TO_PTR(handle))) handle++; conn = new0(struct btdev_conn, 1); @@ -1410,8 +1409,6 @@ static int cmd_add_sco_conn(struct btdev *dev, const void *data, uint8_t len) cc.encr_mode = 0x00; done: - pending_conn_del(dev, conn->link->dev); - send_event(dev, BT_HCI_EVT_CONN_COMPLETE, &cc, sizeof(cc)); return 0; @@ -1527,9 +1524,12 @@ static void auth_complete(struct btdev_conn *conn, uint8_t status) { struct bt_hci_evt_auth_complete ev; + if (!conn) + return; + memset(&ev, 0, sizeof(ev)); - ev.handle = conn ? cpu_to_le16(conn->handle) : 0x0000; + ev.handle = cpu_to_le16(conn->handle); ev.status = status; send_event(conn->dev, BT_HCI_EVT_AUTH_COMPLETE, &ev, sizeof(ev));
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com> This fixes the following scan-build warnings: emulator/btdev.c:1126:10: warning: Although the value stored to 'conn' is used in the enclosing expression, the value is never actually read from 'conn' [deadcode.DeadStores] 1126 | while ((conn = queue_find(dev->conns, match_handle, | ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1127 | UINT_TO_PTR(handle)))) | ~~~~~~~~~~~~~~~~~~~~ emulator/btdev.c:1413:24: warning: Access to field 'link' results in a dereference of a null pointer (loaded from variable 'conn') [core.NullDereference] 1413 | pending_conn_del(dev, conn->link->dev); | ^~~~~~~~~~ emulator/btdev.c:1535:13: warning: Access to field 'dev' results in a dereference of a null pointer (loaded from variable 'conn') [core.NullDereference] 1535 | send_event(conn->dev, BT_HCI_EVT_AUTH_COMPLETE, &ev, sizeof(ev)); | ^~~~~~~~~ --- emulator/btdev.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)