mbox series

[mptcp-next,v2,00/11] add bpf_iter_task

Message ID cover.1741347233.git.tanggeliang@kylinos.cn (mailing list archive)
Headers show
Series add bpf_iter_task | expand

Message

Geliang Tang March 7, 2025, 11:36 a.m. UTC
From: Geliang Tang <tanggeliang@kylinos.cn>

v2:
 - Keep mptcp scheduler API unchanged.
 - Add back struct mptcp_sched_data.
 - add bpf_iter_task in mptcp_sched_data instead of mptcp_sock
 - Add wrapper bpf_iter mptcp_subflow_sched.
 - Use mptcp_subflow_sched iter instead of mptcp_subflow.

v1:
 - https://patchwork.kernel.org/project/mptcp/cover/cover.1740997925.git.tanggeliang@kylinos.cn/

Geliang Tang (11):
  Revert "mptcp: sched: remove mptcp_sched_data"
  Squash to "bpf: Add bpf_mptcp_sched_ops"
  mptcp: add bpf_iter_task for mptcp_sched_data
  mptcp: set and clear bpf_iter_task
  mptcp: add mptcp_subflow_sched bpf_iter
  Squash to "selftests/bpf: Add bpf_first scheduler & test"
  Squash to "selftests/bpf: Add bpf_bkup scheduler & test"
  Squash to "selftests/bpf: Add bpf_rr scheduler & test"
  Squash to "selftests/bpf: Add bpf_red scheduler & test"
  Squash to "selftests/bpf: Add bpf_burst scheduler & test"
  mptcp: drop subflow contexts in mptcp_sched_data

 include/net/mptcp.h                           | 10 ++++--
 net/mptcp/bpf.c                               | 34 +++++++++++++++++--
 net/mptcp/protocol.h                          | 19 +++++++++++
 net/mptcp/sched.c                             | 31 +++++++++++++----
 .../testing/selftests/bpf/bpf_experimental.h  |  9 +++++
 .../selftests/bpf/progs/mptcp_bpf_bkup.c      |  5 +--
 .../selftests/bpf/progs/mptcp_bpf_burst.c     | 10 +++---
 .../selftests/bpf/progs/mptcp_bpf_first.c     |  3 +-
 .../selftests/bpf/progs/mptcp_bpf_red.c       |  5 +--
 .../selftests/bpf/progs/mptcp_bpf_rr.c        |  7 ++--
 10 files changed, 110 insertions(+), 23 deletions(-)

Comments

MPTCP CI March 7, 2025, 11:49 a.m. UTC | #1
Hi Geliang,

Thank you for your modifications, that's great!

But sadly, our CI spotted some issues with it when trying to build it.

You can find more details there:

  https://github.com/multipath-tcp/mptcp_net-next/actions/runs/13719922193

Status: failure
Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/76b642669ea6
Patchwork: https://patchwork.kernel.org/project/mptcp/list/?series=941486

Feel free to reply to this email if you cannot access logs, if you need
some support to fix the error, if this doesn't seem to be caused by your
modifications or if the error is a false positive one.

Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)
MPTCP CI March 7, 2025, 12:33 p.m. UTC | #2
Hi Geliang,

Thank you for your modifications, that's great!

Our CI did some validations and here is its report:

- KVM Validation: normal: Success! ✅
- KVM Validation: debug: Success! ✅
- KVM Validation: btf-normal (only bpftest_all): Success! ✅
- KVM Validation: btf-debug (only bpftest_all): Success! ✅
- Task: https://github.com/multipath-tcp/mptcp_net-next/actions/runs/13719922203

Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/76b642669ea6
Patchwork: https://patchwork.kernel.org/project/mptcp/list/?series=941486


If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:

    $ cd [kernel source code]
    $ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
        --pull always mptcp/mptcp-upstream-virtme-docker:latest \
        auto-normal

For more details:

    https://github.com/multipath-tcp/mptcp-upstream-virtme-docker


Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)

Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)