| Message ID | 20250307-drm-rework-dpcd-access-v3-4-9044a3a868ee@linaro.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | drm/display: dp: add new DPCD access functions | expand |
I thought we had agreed that drm_dp_aux_dev.c was one of the few places where we wanted to keep using the old functions here? On Fri, 2025-03-07 at 06:34 +0200, Dmitry Baryshkov wrote: > From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > Switch drm_dp_aux_dev.c to use new set of DPCD read / write helpers. > > Acked-by: Jani Nikula <jani.nikula@intel.com> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > drivers/gpu/drm/display/drm_dp_aux_dev.c | 12 +++++------- > 1 file changed, 5 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/display/drm_dp_aux_dev.c b/drivers/gpu/drm/display/drm_dp_aux_dev.c > index 29555b9f03c8c42681c17c4a01e74a966cf8611f..a31ab3f41efb71fd5f936c24ba5c3b8ebea68a5e 100644 > --- a/drivers/gpu/drm/display/drm_dp_aux_dev.c > +++ b/drivers/gpu/drm/display/drm_dp_aux_dev.c > @@ -163,17 +163,16 @@ static ssize_t auxdev_read_iter(struct kiocb *iocb, struct iov_iter *to) > break; > } > > - res = drm_dp_dpcd_read(aux_dev->aux, pos, buf, todo); > - > + res = drm_dp_dpcd_read_data(aux_dev->aux, pos, buf, todo); > if (res <= 0) > break; > > - if (copy_to_iter(buf, res, to) != res) { > + if (copy_to_iter(buf, todo, to) != todo) { > res = -EFAULT; > break; > } > > - pos += res; > + pos += todo; > } > > if (pos != iocb->ki_pos) > @@ -211,12 +210,11 @@ static ssize_t auxdev_write_iter(struct kiocb *iocb, struct iov_iter *from) > break; > } > > - res = drm_dp_dpcd_write(aux_dev->aux, pos, buf, todo); > - > + res = drm_dp_dpcd_write_data(aux_dev->aux, pos, buf, todo); > if (res <= 0) > break; > > - pos += res; > + pos += todo; > } > > if (pos != iocb->ki_pos) >
On Fri, Mar 07, 2025 at 05:53:38PM -0500, Lyude Paul wrote: > I thought we had agreed that drm_dp_aux_dev.c was one of the few places where > we wanted to keep using the old functions here? Hmm, I thought I dropped it. > > On Fri, 2025-03-07 at 06:34 +0200, Dmitry Baryshkov wrote: > > From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > > > Switch drm_dp_aux_dev.c to use new set of DPCD read / write helpers. > > > > Acked-by: Jani Nikula <jani.nikula@intel.com> > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > --- > > drivers/gpu/drm/display/drm_dp_aux_dev.c | 12 +++++------- > > 1 file changed, 5 insertions(+), 7 deletions(-) > >
diff --git a/drivers/gpu/drm/display/drm_dp_aux_dev.c b/drivers/gpu/drm/display/drm_dp_aux_dev.c index 29555b9f03c8c42681c17c4a01e74a966cf8611f..a31ab3f41efb71fd5f936c24ba5c3b8ebea68a5e 100644 --- a/drivers/gpu/drm/display/drm_dp_aux_dev.c +++ b/drivers/gpu/drm/display/drm_dp_aux_dev.c @@ -163,17 +163,16 @@ static ssize_t auxdev_read_iter(struct kiocb *iocb, struct iov_iter *to) break; } - res = drm_dp_dpcd_read(aux_dev->aux, pos, buf, todo); - + res = drm_dp_dpcd_read_data(aux_dev->aux, pos, buf, todo); if (res <= 0) break; - if (copy_to_iter(buf, res, to) != res) { + if (copy_to_iter(buf, todo, to) != todo) { res = -EFAULT; break; } - pos += res; + pos += todo; } if (pos != iocb->ki_pos) @@ -211,12 +210,11 @@ static ssize_t auxdev_write_iter(struct kiocb *iocb, struct iov_iter *from) break; } - res = drm_dp_dpcd_write(aux_dev->aux, pos, buf, todo); - + res = drm_dp_dpcd_write_data(aux_dev->aux, pos, buf, todo); if (res <= 0) break; - pos += res; + pos += todo; } if (pos != iocb->ki_pos)