| Message ID | f8ba03dc-0f90-4781-8d54-c16b3251ecb1@stanley.mountain (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [next] drm/msm/dpu: Fix uninitialized variable in dpu_crtc_kickoff_clone_mode() | expand |
On Fri, Mar 07, 2025 at 12:29:39PM +0300, Dan Carpenter wrote: > After the loop there is a check for whether "wb_encoder" has been set > to non-NULL, however it was never set to NULL. Initialize it to NULL. > > Fixes: ad06972d5365 ("drm/msm/dpu: Reorder encoder kickoff for CWB") > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> On Fri, 07 Mar 2025 12:29:39 +0300, Dan Carpenter wrote: > After the loop there is a check for whether "wb_encoder" has been set > to non-NULL, however it was never set to NULL. Initialize it to NULL. > > Applied, thanks! [1/1] drm/msm/dpu: Fix uninitialized variable in dpu_crtc_kickoff_clone_mode() https://gitlab.freedesktop.org/lumag/msm/-/commit/1b9d131a098e Best regards,
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c index b0a062d6fa3b..ff6f5c5303d4 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c @@ -956,7 +956,7 @@ static int _dpu_crtc_wait_for_frame_done(struct drm_crtc *crtc) static int dpu_crtc_kickoff_clone_mode(struct drm_crtc *crtc) { struct drm_encoder *encoder; - struct drm_encoder *rt_encoder = NULL, *wb_encoder; + struct drm_encoder *rt_encoder = NULL, *wb_encoder = NULL; struct dpu_kms *dpu_kms = _dpu_crtc_get_kms(crtc); /* Find encoder for real time display */
After the loop there is a check for whether "wb_encoder" has been set to non-NULL, however it was never set to NULL. Initialize it to NULL. Fixes: ad06972d5365 ("drm/msm/dpu: Reorder encoder kickoff for CWB") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)