| Message ID | 20250304152133.GA2763820@hu-kapandey-hyd.qualcomm.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | arm64: dts: qcom: qcom6490-idp: Add IPA nodes | expand |
On Tue, Mar 04, 2025 at 08:51:33PM +0530, Kaustubh Pandey wrote: > Add IPA nodes for Qualcomm qcm6490 board. > > Signed-off-by: Kaustubh Pandey <quic_kapandey@quicinc.com> > --- > arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts > index 9209efcc49b5..ba47786d6474 100644 > --- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts > +++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts > @@ -19,7 +19,6 @@ > #include "pm8350c.dtsi" > #include "pmk8350.dtsi" > > -/delete-node/ &ipa_fw_mem; > /delete-node/ &rmtfs_mem; > /delete-node/ &adsp_mem; > /delete-node/ &cdsp_mem; > @@ -515,6 +514,13 @@ &gpu_zap_shader { > firmware-name = "qcom/qcm6490/a660_zap.mbn"; > }; > > +&ipa { > + qcom,gsi-loader = "self"; > + memory-region = <&ipa_fw_mem>; > + firmware-name = "qcom/qcm6490/ipa_fws.mdt"; "qcom/qcm6490/ipa_fws.mbn". There is no .mdt in linux-firmware. > + status = "okay"; > +}; > + > &mdss { > status = "okay"; > };
On Tue, 04 Mar 2025 20:51:33 +0530, Kaustubh Pandey wrote: > Add IPA nodes for Qualcomm qcm6490 board. > > Signed-off-by: Kaustubh Pandey <quic_kapandey@quicinc.com> > --- > arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > My bot found new DTB warnings on the .dts files added or changed in this series. Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments. If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date: pip3 install dtschema --upgrade New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/qcom/' for 20250304152133.GA2763820@hu-kapandey-hyd.qualcomm.com: arch/arm64/boot/dts/qcom/qcm6490-idp.dts:119.31-122.5: ERROR (duplicate_label): /reserved-memory/ipa-fw@8b300000: Duplicate label 'ipa_fw_mem' on /reserved-memory/ipa-fw@8b300000 and /reserved-memory/ipa-fw@8b700000 ERROR: Input tree has errors, aborting (use -f to force output) make[3]: *** [scripts/Makefile.dtbs:131: arch/arm64/boot/dts/qcom/qcm6490-idp.dtb] Error 2 make[2]: *** [scripts/Makefile.build:461: arch/arm64/boot/dts/qcom] Error 2 make[2]: Target 'arch/arm64/boot/dts/qcom/qcm6490-idp.dtb' not remade because of errors. make[1]: *** [/home/rob/proj/linux-dt-testing/Makefile:1462: qcom/qcm6490-idp.dtb] Error 2 make: *** [Makefile:251: __sub-make] Error 2
On 3/5/2025 2:28 AM, Dmitry Baryshkov wrote: > On Tue, Mar 04, 2025 at 08:51:33PM +0530, Kaustubh Pandey wrote: >> Add IPA nodes for Qualcomm qcm6490 board. >> >> Signed-off-by: Kaustubh Pandey <quic_kapandey@quicinc.com> >> --- >> arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 8 +++++++- >> 1 file changed, 7 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts >> index 9209efcc49b5..ba47786d6474 100644 >> --- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts >> +++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts >> @@ -19,7 +19,6 @@ >> #include "pm8350c.dtsi" >> #include "pmk8350.dtsi" >> >> -/delete-node/ &ipa_fw_mem; >> /delete-node/ &rmtfs_mem; >> /delete-node/ &adsp_mem; >> /delete-node/ &cdsp_mem; >> @@ -515,6 +514,13 @@ &gpu_zap_shader { >> firmware-name = "qcom/qcm6490/a660_zap.mbn"; >> }; >> >> +&ipa { >> + qcom,gsi-loader = "self"; >> + memory-region = <&ipa_fw_mem>; >> + firmware-name = "qcom/qcm6490/ipa_fws.mdt"; > > "qcom/qcm6490/ipa_fws.mbn". There is no .mdt in linux-firmware. > >> + status = "okay"; >> +}; >> + >> &mdss { >> status = "okay"; >> }; > Sure, thanks for review. Will post another patch with correct format. Thanks, Kaustubh
On 3/5/2025 4:03 AM, Rob Herring (Arm) wrote: > > On Tue, 04 Mar 2025 20:51:33 +0530, Kaustubh Pandey wrote: >> Add IPA nodes for Qualcomm qcm6490 board. >> >> Signed-off-by: Kaustubh Pandey <quic_kapandey@quicinc.com> >> --- >> arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 8 +++++++- >> 1 file changed, 7 insertions(+), 1 deletion(-) >> > > > My bot found new DTB warnings on the .dts files added or changed in this > series. > > Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings > are fixed by another series. Ultimately, it is up to the platform > maintainer whether these warnings are acceptable or not. No need to reply > unless the platform maintainer has comments. > > If you already ran DT checks and didn't see these error(s), then > make sure dt-schema is up to date: > > pip3 install dtschema --upgrade > > > New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/qcom/' for 20250304152133.GA2763820@hu-kapandey-hyd.qualcomm.com: > > arch/arm64/boot/dts/qcom/qcm6490-idp.dts:119.31-122.5: ERROR (duplicate_label): /reserved-memory/ipa-fw@8b300000: Duplicate label 'ipa_fw_mem' on /reserved-memory/ipa-fw@8b300000 and /reserved-memory/ipa-fw@8b700000 > ERROR: Input tree has errors, aborting (use -f to force output) > make[3]: *** [scripts/Makefile.dtbs:131: arch/arm64/boot/dts/qcom/qcm6490-idp.dtb] Error 2 > make[2]: *** [scripts/Makefile.build:461: arch/arm64/boot/dts/qcom] Error 2 > make[2]: Target 'arch/arm64/boot/dts/qcom/qcm6490-idp.dtb' not remade because of errors. > make[1]: *** [/home/rob/proj/linux-dt-testing/Makefile:1462: qcom/qcm6490-idp.dtb] Error 2 > make: *** [Makefile:251: __sub-make] Error 2 > > > > > Sure, Rob. Thanks for review. Will check on these warnings and update new patch. Thanks, Kaustubh
On 4.03.2025 4:21 PM, Kaustubh Pandey wrote: > Add IPA nodes for Qualcomm qcm6490 board. > > Signed-off-by: Kaustubh Pandey <quic_kapandey@quicinc.com> > --- This is a patch to a devicetree of a board that is known not to boot [1]. Were you able to confirm this change works with a relatively unchanged mainline kernel? Moreover, is the IDP still used, with a final SoC revision as well? Konrad [1] https://lore.kernel.org/linux-arm-msm/20250206-protected_clock_qcm6490-v1-1-5923e8c47ab5@quicinc.com/
diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts index 9209efcc49b5..ba47786d6474 100644 --- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts +++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts @@ -19,7 +19,6 @@ #include "pm8350c.dtsi" #include "pmk8350.dtsi" -/delete-node/ &ipa_fw_mem; /delete-node/ &rmtfs_mem; /delete-node/ &adsp_mem; /delete-node/ &cdsp_mem; @@ -515,6 +514,13 @@ &gpu_zap_shader { firmware-name = "qcom/qcm6490/a660_zap.mbn"; }; +&ipa { + qcom,gsi-loader = "self"; + memory-region = <&ipa_fw_mem>; + firmware-name = "qcom/qcm6490/ipa_fws.mdt"; + status = "okay"; +}; + &mdss { status = "okay"; };
Add IPA nodes for Qualcomm qcm6490 board. Signed-off-by: Kaustubh Pandey <quic_kapandey@quicinc.com> --- arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)