Message ID | 20250305050716.3460989-1-pierrick.bouvier@linaro.org (mailing list archive) |
---|---|
State | New |
Headers | show |
Series | trace/control-target: cleanup headers and make compilation unit common | expand |
On 3/4/25 21:07, Pierrick Bouvier wrote: > Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org> > --- > trace/control-target.c | 2 -- > trace/meson.build | 4 +--- > 2 files changed, 1 insertion(+), 5 deletions(-) > > diff --git a/trace/control-target.c b/trace/control-target.c > index d58e84f6dd8..57ceac21084 100644 > --- a/trace/control-target.c > +++ b/trace/control-target.c > @@ -8,8 +8,6 @@ > */ > > #include "qemu/osdep.h" > -#include "qemu/lockable.h" > -#include "cpu.h" > #include "trace/control.h" > > > diff --git a/trace/meson.build b/trace/meson.build > index c3412dc0ba5..3df45493555 100644 > --- a/trace/meson.build > +++ b/trace/meson.build > @@ -1,6 +1,4 @@ > -system_ss.add(files('trace-hmp-cmds.c')) > - > -specific_ss.add(files('control-target.c')) > +system_ss.add(files('control-target.c', 'trace-hmp-cmds.c')) > > trace_events_files = [] > foreach item : [ '.' ] + trace_events_subdirs + qapi_trace_events Hi folks, gentle ping on this trivial change. Regards, Pierrick
On 3/10/25 10:17, Pierrick Bouvier wrote: > On 3/4/25 21:07, Pierrick Bouvier wrote: >> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org> >> --- >> trace/control-target.c | 2 -- >> trace/meson.build | 4 +--- >> 2 files changed, 1 insertion(+), 5 deletions(-) >> >> diff --git a/trace/control-target.c b/trace/control-target.c >> index d58e84f6dd8..57ceac21084 100644 >> --- a/trace/control-target.c >> +++ b/trace/control-target.c >> @@ -8,8 +8,6 @@ >> */ >> #include "qemu/osdep.h" >> -#include "qemu/lockable.h" >> -#include "cpu.h" >> #include "trace/control.h" >> diff --git a/trace/meson.build b/trace/meson.build >> index c3412dc0ba5..3df45493555 100644 >> --- a/trace/meson.build >> +++ b/trace/meson.build >> @@ -1,6 +1,4 @@ >> -system_ss.add(files('trace-hmp-cmds.c')) >> - >> -specific_ss.add(files('control-target.c')) >> +system_ss.add(files('control-target.c', 'trace-hmp-cmds.c')) >> trace_events_files = [] >> foreach item : [ '.' ] + trace_events_subdirs + qapi_trace_events Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
Pierrick Bouvier <pierrick.bouvier@linaro.org> writes: > Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org> Reviewed-by: Alex Bennée <alex.bennee@linaro.org> Tested-by: Alex Bennée <alex.bennee@linaro.org>
On Tue, Mar 04, 2025 at 09:07:16PM -0800, Pierrick Bouvier wrote: > Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org> > --- > trace/control-target.c | 2 -- > trace/meson.build | 4 +--- > 2 files changed, 1 insertion(+), 5 deletions(-) Thanks, applied to my tracing tree: https://gitlab.com/stefanha/qemu/commits/tracing Stefan
diff --git a/trace/control-target.c b/trace/control-target.c index d58e84f6dd8..57ceac21084 100644 --- a/trace/control-target.c +++ b/trace/control-target.c @@ -8,8 +8,6 @@ */ #include "qemu/osdep.h" -#include "qemu/lockable.h" -#include "cpu.h" #include "trace/control.h" diff --git a/trace/meson.build b/trace/meson.build index c3412dc0ba5..3df45493555 100644 --- a/trace/meson.build +++ b/trace/meson.build @@ -1,6 +1,4 @@ -system_ss.add(files('trace-hmp-cmds.c')) - -specific_ss.add(files('control-target.c')) +system_ss.add(files('control-target.c', 'trace-hmp-cmds.c')) trace_events_files = [] foreach item : [ '.' ] + trace_events_subdirs + qapi_trace_events
Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org> --- trace/control-target.c | 2 -- trace/meson.build | 4 +--- 2 files changed, 1 insertion(+), 5 deletions(-)