| Message ID | 20250310195921.157511-6-ariel.dalessandro@collabora.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | drm/panfrost: Add support for AARCH64_4K page table format | expand |
On Mon, 10 Mar 2025 16:59:20 -0300 Ariel D'Alessandro <ariel.dalessandro@collabora.com> wrote: > Now that Panfrost supports AARCH64_4K page table format, let's enable it > on Mediatek MT8188. Can you maybe give more details on why this is needed (legacy shareability/cacheability not suitable for this GPU?)? > > Signed-off-by: Ariel D'Alessandro <ariel.dalessandro@collabora.com> > --- > drivers/gpu/drm/panfrost/panfrost_drv.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c b/drivers/gpu/drm/panfrost/panfrost_drv.c > index 0f3935556ac76..d7b8bded6d784 100644 > --- a/drivers/gpu/drm/panfrost/panfrost_drv.c > +++ b/drivers/gpu/drm/panfrost/panfrost_drv.c > @@ -824,6 +824,7 @@ static const struct panfrost_compatible mediatek_mt8188_data = { > .num_pm_domains = ARRAY_SIZE(mediatek_mt8183_pm_domains), > .pm_domain_names = mediatek_mt8183_pm_domains, > .pm_features = BIT(GPU_PM_CLK_DIS) | BIT(GPU_PM_VREG_OFF), > + .gpu_configs = BIT(GPU_CONFIG_AARCH64_4K), > }; > > static const char * const mediatek_mt8192_supplies[] = { "mali", NULL };
Il 10/03/25 20:59, Ariel D'Alessandro ha scritto: > Now that Panfrost supports AARCH64_4K page table format, let's enable it > on Mediatek MT8188. > > Signed-off-by: Ariel D'Alessandro <ariel.dalessandro@collabora.com> > --- > drivers/gpu/drm/panfrost/panfrost_drv.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c b/drivers/gpu/drm/panfrost/panfrost_drv.c > index 0f3935556ac76..d7b8bded6d784 100644 > --- a/drivers/gpu/drm/panfrost/panfrost_drv.c > +++ b/drivers/gpu/drm/panfrost/panfrost_drv.c > @@ -824,6 +824,7 @@ static const struct panfrost_compatible mediatek_mt8188_data = { > .num_pm_domains = ARRAY_SIZE(mediatek_mt8183_pm_domains), > .pm_domain_names = mediatek_mt8183_pm_domains, > .pm_features = BIT(GPU_PM_CLK_DIS) | BIT(GPU_PM_VREG_OFF), > + .gpu_configs = BIT(GPU_CONFIG_AARCH64_4K), > }; > > static const char * const mediatek_mt8192_supplies[] = { "mali", NULL }; Didn't that work on MT8195/8395 as well? I also recall hearing that it was somewhat giving ever-so-slightly better performance? If it does, please enable it on 8195 as well :-) also s/mediatek_mt8188/MediaTek MT8188/g ...and btw Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Cheers, Angelo
diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c b/drivers/gpu/drm/panfrost/panfrost_drv.c index 0f3935556ac76..d7b8bded6d784 100644 --- a/drivers/gpu/drm/panfrost/panfrost_drv.c +++ b/drivers/gpu/drm/panfrost/panfrost_drv.c @@ -824,6 +824,7 @@ static const struct panfrost_compatible mediatek_mt8188_data = { .num_pm_domains = ARRAY_SIZE(mediatek_mt8183_pm_domains), .pm_domain_names = mediatek_mt8183_pm_domains, .pm_features = BIT(GPU_PM_CLK_DIS) | BIT(GPU_PM_VREG_OFF), + .gpu_configs = BIT(GPU_CONFIG_AARCH64_4K), }; static const char * const mediatek_mt8192_supplies[] = { "mali", NULL };
Now that Panfrost supports AARCH64_4K page table format, let's enable it on Mediatek MT8188. Signed-off-by: Ariel D'Alessandro <ariel.dalessandro@collabora.com> --- drivers/gpu/drm/panfrost/panfrost_drv.c | 1 + 1 file changed, 1 insertion(+)