| Message ID | 20250311171017.3053891-1-alex.hung@amd.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | drm/amd/display: Remove incorrect macro guard | expand |
On 03/11, Alex Hung wrote: > This macro guard "__cplusplus" is unnecessary and should not be there. > > Signed-off-by: Alex Hung <alex.hung@amd.com> > --- > drivers/gpu/drm/amd/display/dc/sspl/dc_spl.h | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/gpu/drm/amd/display/dc/sspl/dc_spl.h b/drivers/gpu/drm/amd/display/dc/sspl/dc_spl.h > index 145961803a92..d621c42a237e 100644 > --- a/drivers/gpu/drm/amd/display/dc/sspl/dc_spl.h > +++ b/drivers/gpu/drm/amd/display/dc/sspl/dc_spl.h > @@ -17,9 +17,6 @@ > #define SPL_EXPAND(a, b) SPL_EXPAND2(a, b) > #define SPL_NAMESPACE(symbol) SPL_EXPAND(SPL_PFX_, symbol) > > -#ifdef __cplusplus > -extern "C" { > -#endif > > /* SPL interfaces */ > > -- > 2.43.0 > Reviewed-by: Rodrigo Siqueira <siqueira@igalia.com>
Am 11.03.25 um 18:10 schrieb Alex Hung: > This macro guard "__cplusplus" is unnecessary and should not be there. > > Signed-off-by: Alex Hung <alex.hung@amd.com> > --- > drivers/gpu/drm/amd/display/dc/sspl/dc_spl.h | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/gpu/drm/amd/display/dc/sspl/dc_spl.h b/drivers/gpu/drm/amd/display/dc/sspl/dc_spl.h > index 145961803a92..d621c42a237e 100644 > --- a/drivers/gpu/drm/amd/display/dc/sspl/dc_spl.h > +++ b/drivers/gpu/drm/amd/display/dc/sspl/dc_spl.h > @@ -17,9 +17,6 @@ > #define SPL_EXPAND(a, b) SPL_EXPAND2(a, b) > #define SPL_NAMESPACE(symbol) SPL_EXPAND(SPL_PFX_, symbol) > > -#ifdef __cplusplus > -extern "C" { > -#endif Just double checking: Is there a closing "#ifdef.. } #endif" at the end of the file? If yes then please remove that as well, if not feel free to add Reviewed-by: Christian König <christian.koenig@amd.com>. Regards, Christian. > > /* SPL interfaces */ >
diff --git a/drivers/gpu/drm/amd/display/dc/sspl/dc_spl.h b/drivers/gpu/drm/amd/display/dc/sspl/dc_spl.h index 145961803a92..d621c42a237e 100644 --- a/drivers/gpu/drm/amd/display/dc/sspl/dc_spl.h +++ b/drivers/gpu/drm/amd/display/dc/sspl/dc_spl.h @@ -17,9 +17,6 @@ #define SPL_EXPAND(a, b) SPL_EXPAND2(a, b) #define SPL_NAMESPACE(symbol) SPL_EXPAND(SPL_PFX_, symbol) -#ifdef __cplusplus -extern "C" { -#endif /* SPL interfaces */
This macro guard "__cplusplus" is unnecessary and should not be there. Signed-off-by: Alex Hung <alex.hung@amd.com> --- drivers/gpu/drm/amd/display/dc/sspl/dc_spl.h | 3 --- 1 file changed, 3 deletions(-)