| Message ID | 20250317083822.891-4-jjian.zhou@mediatek.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | add VCP mailbox and IPC driver | expand |
On 17/03/2025 09:38, Jjian Zhou wrote: > This patch adds document for mediatek vcp mbox. > > Signed-off-by: Jjian Zhou <jjian.zhou@mediatek.com> > --- > .../bindings/mailbox/mtk,mt8196-vcp-mbox.yaml | 49 +++++++++++++++++++ Please use subject prefixes matching the subsystem. You can get them for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching. For bindings, the preferred subjects are explained here: https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters > 1 file changed, 49 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mailbox/mtk,mt8196-vcp-mbox.yaml Filename based on compatible. You already got this comment. Copy paste your filename here: <here goes filename> and here your compatible: <here goes compatible> Are the the same? Best regards, Krzysztof
On 17/03/2025 10:00, Krzysztof Kozlowski wrote: > On 17/03/2025 09:38, Jjian Zhou wrote: >> This patch adds document for mediatek vcp mbox. >> >> Signed-off-by: Jjian Zhou <jjian.zhou@mediatek.com> >> --- >> .../bindings/mailbox/mtk,mt8196-vcp-mbox.yaml | 49 +++++++++++++++++++ > > Please use subject prefixes matching the subsystem. You can get them for > example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory > your patch is touching. For bindings, the preferred subjects are > explained here: > https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters > >> 1 file changed, 49 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/mailbox/mtk,mt8196-vcp-mbox.yaml > > Filename based on compatible. You already got this comment. Copy paste > your filename here: > > <here goes filename> > > and here your compatible: > > <here goes compatible> > > Are the the same? Can you do this exercise here, instead of sending next versions? Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/mailbox/mtk,mt8196-vcp-mbox.yaml b/Documentation/devicetree/bindings/mailbox/mtk,mt8196-vcp-mbox.yaml new file mode 100644 index 000000000000..bd1b024e22f1 --- /dev/null +++ b/Documentation/devicetree/bindings/mailbox/mtk,mt8196-vcp-mbox.yaml @@ -0,0 +1,49 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/mailbox/mtk,mt8196-vcp-mbox.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: MediaTek Video Companion Processor (VCP) mailbox + +maintainers: + - Jjian Zhou <Jjian.Zhou@mediatek.com> + +description: + The MTK VCP mailbox enables the SoC to communicate with the VCP by passing + messages through 64 32-bit wide registers. It has 32 interrupt vectors in + either direction for signalling purposes. + +properties: + compatible: + enum: + - mediatek,mt8196-vcp-mbox + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + "#mbox-cells": + const: 0 + +required: + - compatible + - reg + - interrupts + - "#mbox-cells" + +additionalProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/arm-gic.h> + #include <dt-bindings/interrupt-controller/irq.h> + + mailbox@31b80000 { + compatible = "mediatek,mt8196-vcp-mbox"; + reg = <0x31b80000 0x1000>; + interrupts = <GIC_SPI 789 IRQ_TYPE_LEVEL_HIGH 0>; + #mbox-cells = <0>; + };
This patch adds document for mediatek vcp mbox. Signed-off-by: Jjian Zhou <jjian.zhou@mediatek.com> --- .../bindings/mailbox/mtk,mt8196-vcp-mbox.yaml | 49 +++++++++++++++++++ 1 file changed, 49 insertions(+) create mode 100644 Documentation/devicetree/bindings/mailbox/mtk,mt8196-vcp-mbox.yaml