diff mbox series

[v5,2/5] arm64: dts: imx8mp: Add mu2 root clock

Message ID 20250317133306.2003909-3-daniel.baluta@nxp.com (mailing list archive)
State New
Headers show
Series Configure imx8mp dsp node for rproc usage | expand

Commit Message

Daniel Baluta March 17, 2025, 1:33 p.m. UTC
Enable MU2 node and add mu2 root clock.
MU2 is used to communicate with DSP core.

Reviewed-by: Iuliana Prodan <iuliana.prodan@nxp.com>
Reviewed-by: Peng Fan <peng.fan@nxp.com>
Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
---
 arch/arm64/boot/dts/freescale/imx8mp.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Alexander Stein March 17, 2025, 3:30 p.m. UTC | #1
Am Montag, 17. März 2025, 14:33:03 CET schrieb Daniel Baluta:
> Enable MU2 node and add mu2 root clock.
> MU2 is used to communicate with DSP core.
> 
> Reviewed-by: Iuliana Prodan <iuliana.prodan@nxp.com>
> Reviewed-by: Peng Fan <peng.fan@nxp.com>
> Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
> ---
>  arch/arm64/boot/dts/freescale/imx8mp.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> index 3b725fe442d0..5b443fbeded8 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> @@ -1253,7 +1253,7 @@ mu2: mailbox@30e60000 {
>  				reg = <0x30e60000 0x10000>;
>  				interrupts = <GIC_SPI 136 IRQ_TYPE_LEVEL_HIGH>;
>  				#mbox-cells = <2>;
> -				status = "disabled";

There is no need to enable MU2 if the DSP is disabled by default, no?

Best regards
Alexander

> +				clocks = <&audio_blk_ctrl IMX8MP_CLK_AUDIOMIX_MU2_ROOT>;
>  			};
>  
>  			i2c5: i2c@30ad0000 {
>
Daniel Baluta March 17, 2025, 3:58 p.m. UTC | #2
On Mon, Mar 17, 2025 at 5:30 PM Alexander Stein
<alexander.stein@ew.tq-group.com> wrote:
>
> Am Montag, 17. März 2025, 14:33:03 CET schrieb Daniel Baluta:
> > Enable MU2 node and add mu2 root clock.
> > MU2 is used to communicate with DSP core.
> >
> > Reviewed-by: Iuliana Prodan <iuliana.prodan@nxp.com>
> > Reviewed-by: Peng Fan <peng.fan@nxp.com>
> > Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
> > ---
> >  arch/arm64/boot/dts/freescale/imx8mp.dtsi | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > index 3b725fe442d0..5b443fbeded8 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > @@ -1253,7 +1253,7 @@ mu2: mailbox@30e60000 {
> >                               reg = <0x30e60000 0x10000>;
> >                               interrupts = <GIC_SPI 136 IRQ_TYPE_LEVEL_HIGH>;
> >                               #mbox-cells = <2>;
> > -                             status = "disabled";
>
> There is no need to enable MU2 if the DSP is disabled by default, no?

True, I can enable it only when needed. Will fix in next version.
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
index 3b725fe442d0..5b443fbeded8 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
@@ -1253,7 +1253,7 @@  mu2: mailbox@30e60000 {
 				reg = <0x30e60000 0x10000>;
 				interrupts = <GIC_SPI 136 IRQ_TYPE_LEVEL_HIGH>;
 				#mbox-cells = <2>;
-				status = "disabled";
+				clocks = <&audio_blk_ctrl IMX8MP_CLK_AUDIOMIX_MU2_ROOT>;
 			};
 
 			i2c5: i2c@30ad0000 {