| Message ID | 20250317-fix-nexus-4-v1-6-655c52e2ad97@oss.qualcomm.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | ARM: qcom: fix APQ8064 schema warnings | expand |
On 3/17/25 6:44 PM, Dmitry Baryshkov wrote: > Follow up the expected way of describing the SFPB hwspinlock and merge > hwspinlock node into corresponding syscon node, fixing several dt-schema > warnings. > > Fixes: 24a9baf933dc ("ARM: dts: qcom: apq8064: Add hwmutex and SMEM nodes") > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> > --- > arch/arm/boot/dts/qcom/qcom-apq8064.dtsi | 11 +++-------- > 1 file changed, 3 insertions(+), 8 deletions(-) > > diff --git a/arch/arm/boot/dts/qcom/qcom-apq8064.dtsi b/arch/arm/boot/dts/qcom/qcom-apq8064.dtsi > index ba99e794dcd2236f65f2f3d8c49213cfdaee5f6e..3728875a5506397b36a4c0d6a5ad12c067bbdd8c 100644 > --- a/arch/arm/boot/dts/qcom/qcom-apq8064.dtsi > +++ b/arch/arm/boot/dts/qcom/qcom-apq8064.dtsi > @@ -213,12 +213,6 @@ sleep_clk: sleep_clk { > }; > }; > > - sfpb_mutex: hwmutex { > - compatible = "qcom,sfpb-mutex"; > - syscon = <&sfpb_wrapper_mutex 0x604 0x4>; > - #hwlock-cells = <1>; > - }; > - > smem { > compatible = "qcom,smem"; > memory-region = <&smem_region>; > @@ -305,9 +299,10 @@ tlmm_pinmux: pinctrl@800000 { > pinctrl-0 = <&ps_hold_default_state>; > }; > > - sfpb_wrapper_mutex: syscon@1200000 { > - compatible = "syscon"; > + sfpb_mutex: hwmutex@1200000 { > + compatible = "qcom,sfpb-mutex"; > reg = <0x01200000 0x8000>; The mutex is at +0x600 Konrad
On Tue, Mar 18, 2025 at 01:08:00PM +0100, Konrad Dybcio wrote: > On 3/17/25 6:44 PM, Dmitry Baryshkov wrote: > > Follow up the expected way of describing the SFPB hwspinlock and merge > > hwspinlock node into corresponding syscon node, fixing several dt-schema > > warnings. > > > > Fixes: 24a9baf933dc ("ARM: dts: qcom: apq8064: Add hwmutex and SMEM nodes") > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> > > --- > > arch/arm/boot/dts/qcom/qcom-apq8064.dtsi | 11 +++-------- > > 1 file changed, 3 insertions(+), 8 deletions(-) > > > > diff --git a/arch/arm/boot/dts/qcom/qcom-apq8064.dtsi b/arch/arm/boot/dts/qcom/qcom-apq8064.dtsi > > index ba99e794dcd2236f65f2f3d8c49213cfdaee5f6e..3728875a5506397b36a4c0d6a5ad12c067bbdd8c 100644 > > --- a/arch/arm/boot/dts/qcom/qcom-apq8064.dtsi > > +++ b/arch/arm/boot/dts/qcom/qcom-apq8064.dtsi > > @@ -213,12 +213,6 @@ sleep_clk: sleep_clk { > > }; > > }; > > > > - sfpb_mutex: hwmutex { > > - compatible = "qcom,sfpb-mutex"; > > - syscon = <&sfpb_wrapper_mutex 0x604 0x4>; > > - #hwlock-cells = <1>; > > - }; > > - > > smem { > > compatible = "qcom,smem"; > > memory-region = <&smem_region>; > > @@ -305,9 +299,10 @@ tlmm_pinmux: pinctrl@800000 { > > pinctrl-0 = <&ps_hold_default_state>; > > }; > > > > - sfpb_wrapper_mutex: syscon@1200000 { > > - compatible = "syscon"; > > + sfpb_mutex: hwmutex@1200000 { > > + compatible = "qcom,sfpb-mutex"; > > reg = <0x01200000 0x8000>; > > The mutex is at +0x600 Indeed...
diff --git a/arch/arm/boot/dts/qcom/qcom-apq8064.dtsi b/arch/arm/boot/dts/qcom/qcom-apq8064.dtsi index ba99e794dcd2236f65f2f3d8c49213cfdaee5f6e..3728875a5506397b36a4c0d6a5ad12c067bbdd8c 100644 --- a/arch/arm/boot/dts/qcom/qcom-apq8064.dtsi +++ b/arch/arm/boot/dts/qcom/qcom-apq8064.dtsi @@ -213,12 +213,6 @@ sleep_clk: sleep_clk { }; }; - sfpb_mutex: hwmutex { - compatible = "qcom,sfpb-mutex"; - syscon = <&sfpb_wrapper_mutex 0x604 0x4>; - #hwlock-cells = <1>; - }; - smem { compatible = "qcom,smem"; memory-region = <&smem_region>; @@ -305,9 +299,10 @@ tlmm_pinmux: pinctrl@800000 { pinctrl-0 = <&ps_hold_default_state>; }; - sfpb_wrapper_mutex: syscon@1200000 { - compatible = "syscon"; + sfpb_mutex: hwmutex@1200000 { + compatible = "qcom,sfpb-mutex"; reg = <0x01200000 0x8000>; + #hwlock-cells = <1>; }; intc: interrupt-controller@2000000 {
Follow up the expected way of describing the SFPB hwspinlock and merge hwspinlock node into corresponding syscon node, fixing several dt-schema warnings. Fixes: 24a9baf933dc ("ARM: dts: qcom: apq8064: Add hwmutex and SMEM nodes") Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> --- arch/arm/boot/dts/qcom/qcom-apq8064.dtsi | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-)