| Message ID | 20250317-fix-nexus-4-v1-4-655c52e2ad97@oss.qualcomm.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | ARM: qcom: fix APQ8064 schema warnings | expand |
On Mon, 17 Mar 2025 19:44:39 +0200, Dmitry Baryshkov wrote: > As most other CoreSight devices the replicator can use either of the > optional clocks (or both). Document those optional clocks in the schema. > > Fixes: 3c15fddf3121 ("dt-bindings: arm: Convert CoreSight bindings to DT schema") > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> > --- > .../bindings/arm/arm,coresight-static-replicator.yaml | 10 ++++++++++ > 1 file changed, 10 insertions(+) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/arm/arm,coresight-static-replicator.yaml: properties:clock-names: 'enum' should not be valid under {'enum': ['const', 'enum', 'exclusiveMaximum', 'exclusiveMinimum', 'minimum', 'maximum', 'multipleOf', 'pattern']} hint: Scalar and array keywords cannot be mixed from schema $id: http://devicetree.org/meta-schemas/keywords.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250317-fix-nexus-4-v1-4-655c52e2ad97@oss.qualcomm.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On 3/17/25 6:44 PM, Dmitry Baryshkov wrote: > As most other CoreSight devices the replicator can use either of the > optional clocks (or both). Document those optional clocks in the schema. > > Fixes: 3c15fddf3121 ("dt-bindings: arm: Convert CoreSight bindings to DT schema") > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> > --- > .../bindings/arm/arm,coresight-static-replicator.yaml | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/arm,coresight-static-replicator.yaml b/Documentation/devicetree/bindings/arm/arm,coresight-static-replicator.yaml > index a6f793ea03b6c193fc0ff72a45e0249a63a2ba3c..56e64067ed3d63c5e293a0840858f13428bacb45 100644 > --- a/Documentation/devicetree/bindings/arm/arm,coresight-static-replicator.yaml > +++ b/Documentation/devicetree/bindings/arm/arm,coresight-static-replicator.yaml > @@ -30,6 +30,16 @@ properties: > power-domains: > maxItems: 1 > > + clocks: > + minItems: 1 > + maxItems: 2 > + > + clock-names: > + minItems: 1 > + enum: I believe this should either be items: if 0/1/2 is allowed, or minItems should be dropped if 0/1 is allowed, but the former seems to be the intention Konrad > + - apb_pclk > + - atclk > + > in-ports: > $ref: /schemas/graph.yaml#/properties/ports > additionalProperties: false >
On 17/03/2025 17:44, Dmitry Baryshkov wrote: nit: Subject: s/qcom,coresight-static-replicator/arm,coresight-static-replicator > As most other CoreSight devices the replicator can use either of the > optional clocks (or both). Document those optional clocks in the schema. > > Fixes: 3c15fddf3121 ("dt-bindings: arm: Convert CoreSight bindings to DT schema") > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> > --- > .../bindings/arm/arm,coresight-static-replicator.yaml | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/arm,coresight-static-replicator.yaml b/Documentation/devicetree/bindings/arm/arm,coresight-static-replicator.yaml > index a6f793ea03b6c193fc0ff72a45e0249a63a2ba3c..56e64067ed3d63c5e293a0840858f13428bacb45 100644 > --- a/Documentation/devicetree/bindings/arm/arm,coresight-static-replicator.yaml > +++ b/Documentation/devicetree/bindings/arm/arm,coresight-static-replicator.yaml > @@ -30,6 +30,16 @@ properties: > power-domains: > maxItems: 1 > > + clocks: > + minItems: 1 > + maxItems: 2 > + For the static replicator, you don't have an APB clock, as they can't be programmed. It may have an ATB clock. So minItems 0, maxItems: 1 Suzuki > + clock-names: > + minItems: 1 > + enum: > + - apb_pclk > + - atclk > + > in-ports: > $ref: /schemas/graph.yaml#/properties/ports > additionalProperties: false >
On Tue, Mar 18, 2025 at 10:38:17AM +0000, Suzuki K Poulose wrote: > On 17/03/2025 17:44, Dmitry Baryshkov wrote: > > nit: Subject: > > s/qcom,coresight-static-replicator/arm,coresight-static-replicator > > > As most other CoreSight devices the replicator can use either of the > > optional clocks (or both). Document those optional clocks in the schema. > > > > Fixes: 3c15fddf3121 ("dt-bindings: arm: Convert CoreSight bindings to DT schema") > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> > > --- > > .../bindings/arm/arm,coresight-static-replicator.yaml | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/arm/arm,coresight-static-replicator.yaml b/Documentation/devicetree/bindings/arm/arm,coresight-static-replicator.yaml > > index a6f793ea03b6c193fc0ff72a45e0249a63a2ba3c..56e64067ed3d63c5e293a0840858f13428bacb45 100644 > > --- a/Documentation/devicetree/bindings/arm/arm,coresight-static-replicator.yaml > > +++ b/Documentation/devicetree/bindings/arm/arm,coresight-static-replicator.yaml > > @@ -30,6 +30,16 @@ properties: > > power-domains: > > maxItems: 1 > > + clocks: > > + minItems: 1 > > + maxItems: 2 > > + > > For the static replicator, you don't have an APB clock, as they can't be > programmed. It may have an ATB clock. So minItems 0, maxItems: 1 It can, see qcom-apq8064.dtsi Also minItems:0 doesn't make sense to me. I'd rather keep this as an optional property rather than requiring an empty set. > > Suzuki > > > > > + clock-names: > > + minItems: 1 > > + enum: > > + - apb_pclk > > + - atclk > > + > > in-ports: > > $ref: /schemas/graph.yaml#/properties/ports > > additionalProperties: false > > >
On 18/03/2025 12:19, Dmitry Baryshkov wrote: > On Tue, Mar 18, 2025 at 10:38:17AM +0000, Suzuki K Poulose wrote: >> On 17/03/2025 17:44, Dmitry Baryshkov wrote: >> >> nit: Subject: >> >> s/qcom,coresight-static-replicator/arm,coresight-static-replicator >> >>> As most other CoreSight devices the replicator can use either of the >>> optional clocks (or both). Document those optional clocks in the schema. >>> >>> Fixes: 3c15fddf3121 ("dt-bindings: arm: Convert CoreSight bindings to DT schema") >>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> >>> --- >>> .../bindings/arm/arm,coresight-static-replicator.yaml | 10 ++++++++++ >>> 1 file changed, 10 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/arm/arm,coresight-static-replicator.yaml b/Documentation/devicetree/bindings/arm/arm,coresight-static-replicator.yaml >>> index a6f793ea03b6c193fc0ff72a45e0249a63a2ba3c..56e64067ed3d63c5e293a0840858f13428bacb45 100644 >>> --- a/Documentation/devicetree/bindings/arm/arm,coresight-static-replicator.yaml >>> +++ b/Documentation/devicetree/bindings/arm/arm,coresight-static-replicator.yaml >>> @@ -30,6 +30,16 @@ properties: >>> power-domains: >>> maxItems: 1 >>> + clocks: >>> + minItems: 1 >>> + maxItems: 2 >>> + >> >> For the static replicator, you don't have an APB clock, as they can't be >> programmed. It may have an ATB clock. So minItems 0, maxItems: 1 > > It can, see qcom-apq8064.dtsi > > Also minItems:0 doesn't make sense to me. I'd rather keep this as an > optional property rather than requiring an empty set. Interesting, that must be atclk in fact. Because a static replicator only manages ATB transactions. It doesn't have an APB interface. I am not an expert in DTB schema. But the point is the clocks are optional. Suzuki > >> >> Suzuki >> >> >> >>> + clock-names: >>> + minItems: 1 >>> + enum: >>> + - apb_pclk >>> + - atclk >>> + >>> in-ports: >>> $ref: /schemas/graph.yaml#/properties/ports >>> additionalProperties: false >>> >> >
diff --git a/Documentation/devicetree/bindings/arm/arm,coresight-static-replicator.yaml b/Documentation/devicetree/bindings/arm/arm,coresight-static-replicator.yaml index a6f793ea03b6c193fc0ff72a45e0249a63a2ba3c..56e64067ed3d63c5e293a0840858f13428bacb45 100644 --- a/Documentation/devicetree/bindings/arm/arm,coresight-static-replicator.yaml +++ b/Documentation/devicetree/bindings/arm/arm,coresight-static-replicator.yaml @@ -30,6 +30,16 @@ properties: power-domains: maxItems: 1 + clocks: + minItems: 1 + maxItems: 2 + + clock-names: + minItems: 1 + enum: + - apb_pclk + - atclk + in-ports: $ref: /schemas/graph.yaml#/properties/ports additionalProperties: false
As most other CoreSight devices the replicator can use either of the optional clocks (or both). Document those optional clocks in the schema. Fixes: 3c15fddf3121 ("dt-bindings: arm: Convert CoreSight bindings to DT schema") Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> --- .../bindings/arm/arm,coresight-static-replicator.yaml | 10 ++++++++++ 1 file changed, 10 insertions(+)