| Message ID | 20250317-fix-nexus-4-v1-9-655c52e2ad97@oss.qualcomm.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | ARM: qcom: fix APQ8064 schema warnings | expand |
On 3/17/25 6:44 PM, Dmitry Baryshkov wrote: > The CoreSight replicator device isn't a part of the system MMIO bus, as the static kind, anyway - the dynamic ones are > such it should not be a part of the soc node. Follow the example of > other platforms and move it out of the soc bus to the top-level. > > Fixes: 7a5c275fd821 ("ARM: dts: qcom: Add apq8064 CoreSight components") > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> > --- > arch/arm/boot/dts/qcom/qcom-apq8064.dtsi | 66 ++++++++++++++++---------------- > 1 file changed, 33 insertions(+), 33 deletions(-) > > diff --git a/arch/arm/boot/dts/qcom/qcom-apq8064.dtsi b/arch/arm/boot/dts/qcom/qcom-apq8064.dtsi > index a106f9f984fcb51dea1fff1515e6f290b36ccf99..acd94f3ba0350c5dcdd8f80885ee643d8cbddac7 100644 > --- a/arch/arm/boot/dts/qcom/qcom-apq8064.dtsi > +++ b/arch/arm/boot/dts/qcom/qcom-apq8064.dtsi > @@ -278,6 +278,39 @@ scm { > }; > }; > > + replicator { > + compatible = "arm,coresight-static-replicator"; > + > + clocks = <&rpmcc RPM_QDSS_CLK>; > + clock-names = "apb_pclk"; > + > + out-ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + replicator_out0: endpoint { Please take the artistic liberty to add a newline before subnodes and re-sort the in/out-ports to make them alphabetical Konrad
On Tue, Mar 18, 2025 at 01:15:16PM +0100, Konrad Dybcio wrote: > On 3/17/25 6:44 PM, Dmitry Baryshkov wrote: > > The CoreSight replicator device isn't a part of the system MMIO bus, as > > the static kind, anyway - the dynamic ones are > > > such it should not be a part of the soc node. Follow the example of > > other platforms and move it out of the soc bus to the top-level. > > > > Fixes: 7a5c275fd821 ("ARM: dts: qcom: Add apq8064 CoreSight components") > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> > > --- > > arch/arm/boot/dts/qcom/qcom-apq8064.dtsi | 66 ++++++++++++++++---------------- > > 1 file changed, 33 insertions(+), 33 deletions(-) > > > > diff --git a/arch/arm/boot/dts/qcom/qcom-apq8064.dtsi b/arch/arm/boot/dts/qcom/qcom-apq8064.dtsi > > index a106f9f984fcb51dea1fff1515e6f290b36ccf99..acd94f3ba0350c5dcdd8f80885ee643d8cbddac7 100644 > > --- a/arch/arm/boot/dts/qcom/qcom-apq8064.dtsi > > +++ b/arch/arm/boot/dts/qcom/qcom-apq8064.dtsi > > @@ -278,6 +278,39 @@ scm { > > }; > > }; > > > > + replicator { > > + compatible = "arm,coresight-static-replicator"; > > + > > + clocks = <&rpmcc RPM_QDSS_CLK>; > > + clock-names = "apb_pclk"; > > + > > + out-ports { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + port@0 { > > + reg = <0>; > > + replicator_out0: endpoint { > > Please take the artistic liberty to add a newline before subnodes and re-sort > the in/out-ports to make them alphabetical Ack
diff --git a/arch/arm/boot/dts/qcom/qcom-apq8064.dtsi b/arch/arm/boot/dts/qcom/qcom-apq8064.dtsi index a106f9f984fcb51dea1fff1515e6f290b36ccf99..acd94f3ba0350c5dcdd8f80885ee643d8cbddac7 100644 --- a/arch/arm/boot/dts/qcom/qcom-apq8064.dtsi +++ b/arch/arm/boot/dts/qcom/qcom-apq8064.dtsi @@ -278,6 +278,39 @@ scm { }; }; + replicator { + compatible = "arm,coresight-static-replicator"; + + clocks = <&rpmcc RPM_QDSS_CLK>; + clock-names = "apb_pclk"; + + out-ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + replicator_out0: endpoint { + remote-endpoint = <&etb_in>; + }; + }; + port@1 { + reg = <1>; + replicator_out1: endpoint { + remote-endpoint = <&tpiu_in>; + }; + }; + }; + + in-ports { + port { + replicator_in: endpoint { + remote-endpoint = <&funnel_out>; + }; + }; + }; + }; + soc: soc { #address-cells = <1>; #size-cells = <1>; @@ -1529,39 +1562,6 @@ tpiu_in: endpoint { }; }; - replicator { - compatible = "arm,coresight-static-replicator"; - - clocks = <&rpmcc RPM_QDSS_CLK>; - clock-names = "apb_pclk"; - - out-ports { - #address-cells = <1>; - #size-cells = <0>; - - port@0 { - reg = <0>; - replicator_out0: endpoint { - remote-endpoint = <&etb_in>; - }; - }; - port@1 { - reg = <1>; - replicator_out1: endpoint { - remote-endpoint = <&tpiu_in>; - }; - }; - }; - - in-ports { - port { - replicator_in: endpoint { - remote-endpoint = <&funnel_out>; - }; - }; - }; - }; - funnel@1a04000 { compatible = "arm,coresight-dynamic-funnel", "arm,primecell"; reg = <0x1a04000 0x1000>;
The CoreSight replicator device isn't a part of the system MMIO bus, as such it should not be a part of the soc node. Follow the example of other platforms and move it out of the soc bus to the top-level. Fixes: 7a5c275fd821 ("ARM: dts: qcom: Add apq8064 CoreSight components") Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> --- arch/arm/boot/dts/qcom/qcom-apq8064.dtsi | 66 ++++++++++++++++---------------- 1 file changed, 33 insertions(+), 33 deletions(-)