| Message ID | 20250318102259.189289-3-laura.nao@collabora.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Use ChromeOS DT hardware prober with MT8192 Spherion trackpads | expand |
Il 18/03/25 11:22, Laura Nao ha scritto: > Different Spherion variants use different trackpads on the same I2C2 > bus. Instead of enabling all of them by default, mark them as > "fail-needs-probe" and let the implementation determine which one is > actually present. > > Additionally, move the trackpad pinctrl entry back to the individual > trackpad nodes. > > Signed-off-by: Laura Nao <laura.nao@collabora.com> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
On Tue, Mar 18, 2025 at 11:22:59AM +0100, Laura Nao wrote: > Different Spherion variants use different trackpads on the same I2C2 > bus. Instead of enabling all of them by default, mark them as > "fail-needs-probe" and let the implementation determine which one is > actually present. > > Additionally, move the trackpad pinctrl entry back to the individual > trackpad nodes. > > Signed-off-by: Laura Nao <laura.nao@collabora.com> Reviewed-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> Tested-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> With these patches only the right trackpad is enabled on my Spherion and it works as expected. Thanks, Nícolas
diff --git a/arch/arm64/boot/dts/mediatek/mt8192-asurada-spherion-r0.dts b/arch/arm64/boot/dts/mediatek/mt8192-asurada-spherion-r0.dts index 8c485c3ced2c..163960f58db5 100644 --- a/arch/arm64/boot/dts/mediatek/mt8192-asurada-spherion-r0.dts +++ b/arch/arm64/boot/dts/mediatek/mt8192-asurada-spherion-r0.dts @@ -85,8 +85,15 @@ &i2c2 { trackpad@2c { compatible = "hid-over-i2c"; reg = <0x2c>; + pinctrl-names = "default"; + pinctrl-0 = <&trackpad_pins>; hid-descr-addr = <0x20>; interrupts-extended = <&pio 15 IRQ_TYPE_LEVEL_LOW>; wakeup-source; + status = "fail-needs-probe"; }; }; + +&trackpad { + status = "fail-needs-probe"; +}; diff --git a/arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi b/arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi index dd0d07fbe61a..b11b32a63bbc 100644 --- a/arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi @@ -335,11 +335,13 @@ &i2c2 { clock-frequency = <400000>; clock-stretch-ns = <12600>; pinctrl-names = "default"; - pinctrl-0 = <&i2c2_pins>, <&trackpad_pins>; + pinctrl-0 = <&i2c2_pins>; - trackpad@15 { + trackpad: trackpad@15 { compatible = "elan,ekth3000"; reg = <0x15>; + pinctrl-names = "default"; + pinctrl-0 = <&trackpad_pins>; interrupts-extended = <&pio 15 IRQ_TYPE_LEVEL_LOW>; vcc-supply = <&pp3300_u>; wakeup-source;
Different Spherion variants use different trackpads on the same I2C2 bus. Instead of enabling all of them by default, mark them as "fail-needs-probe" and let the implementation determine which one is actually present. Additionally, move the trackpad pinctrl entry back to the individual trackpad nodes. Signed-off-by: Laura Nao <laura.nao@collabora.com> --- .../arm64/boot/dts/mediatek/mt8192-asurada-spherion-r0.dts | 7 +++++++ arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi | 6 ++++-- 2 files changed, 11 insertions(+), 2 deletions(-)