Message ID | 20250318184550.47642-2-uwe@kleine-koenig.org (mailing list archive) |
---|---|
State | New |
Headers | show |
Series | arm64: dts: rockchip: Improve gmac phy setup for QNAP-TS433 | expand |
Hey Uwe, Am Dienstag, 18. März 2025, 19:45:49 MEZ schrieb Uwe Kleine-König: > Instead of relying on the MDIO broadcast address (0) talk to the phy on > its configured address. Also add the phy reset gpio which was found by > Heiko inspecting the U-Boot vendor source code. He is still trying to > recover. I believe these want to be two separate changes ... as indicated by the "Also ..." in the commit message: - reset-gpio addition - mdio address change and I guess both could possibly have a Fixes: 9da1c0327d58 ("arm64: dts: rockchip: Add basic support for QNAP TS-433") Heiko > Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org> > --- > .../arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts | 15 +++++++++++++-- > 1 file changed, 13 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts b/arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts > index 7bd32d230ad2..411f8ac7994b 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts > @@ -481,9 +481,14 @@ eeprom@56 { > }; > > &mdio0 { > - rgmii_phy0: ethernet-phy@0 { > + rgmii_phy0: ethernet-phy@3 { > + /* Motorcomm YT8521 phy */ > compatible = "ethernet-phy-ieee802.3-c22"; > - reg = <0x0>; > + reg = <0x3>; > + pinctrl-0 = <ð_phy0_reset_pin>; > + pinctrl-names = "default"; > + reset-assert-us = <10000>; > + reset-gpios = <&gpio0 RK_PC6 GPIO_ACTIVE_LOW>; > }; > }; > > @@ -556,6 +561,12 @@ &pcie3x2 { > }; > > &pinctrl { > + gmac0 { > + eth_phy0_reset_pin: eth-phy0-reset-pin { > + rockchip,pins = <0 RK_PC6 RK_FUNC_GPIO &pcfg_pull_up>; > + }; > + }; > + > keys { > copy_button_pin: copy-button-pin { > rockchip,pins = <0 RK_PB6 RK_FUNC_GPIO &pcfg_pull_up>; > > base-commit: 2014c95afecee3e76ca4a56956a936e23283f05b >
diff --git a/arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts b/arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts index 7bd32d230ad2..411f8ac7994b 100644 --- a/arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts +++ b/arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts @@ -481,9 +481,14 @@ eeprom@56 { }; &mdio0 { - rgmii_phy0: ethernet-phy@0 { + rgmii_phy0: ethernet-phy@3 { + /* Motorcomm YT8521 phy */ compatible = "ethernet-phy-ieee802.3-c22"; - reg = <0x0>; + reg = <0x3>; + pinctrl-0 = <ð_phy0_reset_pin>; + pinctrl-names = "default"; + reset-assert-us = <10000>; + reset-gpios = <&gpio0 RK_PC6 GPIO_ACTIVE_LOW>; }; }; @@ -556,6 +561,12 @@ &pcie3x2 { }; &pinctrl { + gmac0 { + eth_phy0_reset_pin: eth-phy0-reset-pin { + rockchip,pins = <0 RK_PC6 RK_FUNC_GPIO &pcfg_pull_up>; + }; + }; + keys { copy_button_pin: copy-button-pin { rockchip,pins = <0 RK_PB6 RK_FUNC_GPIO &pcfg_pull_up>;
Instead of relying on the MDIO broadcast address (0) talk to the phy on its configured address. Also add the phy reset gpio which was found by Heiko inspecting the U-Boot vendor source code. He is still trying to recover. Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org> --- .../arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) base-commit: 2014c95afecee3e76ca4a56956a936e23283f05b