diff mbox series

[6.12.y-cip,05/13] pinctrl: renesas: rzg2l: Move RZG2L_SINGLE_PIN definition to top of the file

Message ID 20250331110659.252237-6-tommaso.merciai.xr@bp.renesas.com (mailing list archive)
State New
Headers show
Series Add RZ/G3E pinctrl support | expand

Commit Message

Tommaso Merciai March 31, 2025, 11:06 a.m. UTC 
From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

commit 13dcd63dc704b33a8ad94f1d161c0f5dad243a5b upstream.

Define `RZG2L_SINGLE_PIN` at the top of the file to clarify its use for
dedicated pins for improved readability.

While at it update the comment for `RZG2L_SINGLE_PIN_PACK` macro and place
it just above the macro for clarity.

Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Tested-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Link: https://lore.kernel.org/r/20240618174831.415583-4-prabhakar.mahadev-lad.rj@bp.renesas.com
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>
---
 drivers/pinctrl/renesas/pinctrl-rzg2l.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Pavel Machek April 1, 2025, 10:26 a.m. UTC | #1 
Hi!

> commit 13dcd63dc704b33a8ad94f1d161c0f5dad243a5b upstream.
> 
> Define `RZG2L_SINGLE_PIN` at the top of the file to clarify its use for
> dedicated pins for improved readability.
> 
> While at it update the comment for `RZG2L_SINGLE_PIN_PACK` macro and place
> it just above the macro for clarity.

Changelog no longer matches the patch.

> diff --git a/drivers/pinctrl/renesas/pinctrl-rzg2l.c b/drivers/pinctrl/renesas/pinctrl-rzg2l.c
> index 5081c7d8064fa..b47f0f1257cff 100644
> --- a/drivers/pinctrl/renesas/pinctrl-rzg2l.c
> +++ b/drivers/pinctrl/renesas/pinctrl-rzg2l.c
> @@ -65,6 +65,8 @@
>  #define RZG2L_SINGLE_PIN		BIT_ULL(63)	/* Dedicated pin */
>  #define RZG2L_VARIABLE_CFG		BIT_ULL(62)	/* Variable cfg for port pins */
>  
> +#define RZG2L_SINGLE_PIN		BIT_ULL(63)	/* Dedicated pin */
> +

And the patch was already applied, see the previous defines. I believe
we can just drop this one safely.

Best regards,
								Pavel
Tommaso Merciai April 1, 2025, 10:38 a.m. UTC | #2 
Hi Pavel,
Thanks for your review.

On Tue, Apr 01, 2025 at 12:26:19PM +0200, Pavel Machek wrote:
> Hi!
> 
> > commit 13dcd63dc704b33a8ad94f1d161c0f5dad243a5b upstream.
> > 
> > Define `RZG2L_SINGLE_PIN` at the top of the file to clarify its use for
> > dedicated pins for improved readability.
> > 
> > While at it update the comment for `RZG2L_SINGLE_PIN_PACK` macro and place
> > it just above the macro for clarity.
> 
> Changelog no longer matches the patch.
> 
> > diff --git a/drivers/pinctrl/renesas/pinctrl-rzg2l.c b/drivers/pinctrl/renesas/pinctrl-rzg2l.c
> > index 5081c7d8064fa..b47f0f1257cff 100644
> > --- a/drivers/pinctrl/renesas/pinctrl-rzg2l.c
> > +++ b/drivers/pinctrl/renesas/pinctrl-rzg2l.c
> > @@ -65,6 +65,8 @@
> >  #define RZG2L_SINGLE_PIN		BIT_ULL(63)	/* Dedicated pin */
> >  #define RZG2L_VARIABLE_CFG		BIT_ULL(62)	/* Variable cfg for port pins */
> >  
> > +#define RZG2L_SINGLE_PIN		BIT_ULL(63)	/* Dedicated pin */
> > +
> 
> And the patch was already applied, see the previous defines. I believe
> we can just drop this one safely.

Agreed. I've done a test on my side.
We can just drop this one safely.

Thanks,
Tommaso

> 
> Best regards,
> 								Pavel
> -- 
> DENX Software Engineering GmbH,        Managing Director: Erika Unter
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
diff mbox series

Patch

diff --git a/drivers/pinctrl/renesas/pinctrl-rzg2l.c b/drivers/pinctrl/renesas/pinctrl-rzg2l.c
index 5081c7d8064fa..b47f0f1257cff 100644
--- a/drivers/pinctrl/renesas/pinctrl-rzg2l.c
+++ b/drivers/pinctrl/renesas/pinctrl-rzg2l.c
@@ -65,6 +65,8 @@ 
 #define RZG2L_SINGLE_PIN		BIT_ULL(63)	/* Dedicated pin */
 #define RZG2L_VARIABLE_CFG		BIT_ULL(62)	/* Variable cfg for port pins */
 
+#define RZG2L_SINGLE_PIN		BIT_ULL(63)	/* Dedicated pin */
+
 #define RZG2L_MPXED_COMMON_PIN_FUNCS(group) \
 					(PIN_CFG_IOLH_##group | \
 					 PIN_CFG_PUPD | \