| Message ID | 20250402135001.12475-1-gshahrouzi@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [v2] staging: media: Fix indentation to use tabs instead of spaces | expand |
On Wed, Apr 2, 2025 at 4:50 PM Gabriel Shahrouzi <gshahrouzi@gmail.com> wrote: > > Replace spaces with tab to comply with kernel coding style. Still 'tab'. please, capitalize it to be 'TAB'. But wait a bit, the driver maintainer might do that for you whilst applying.
On Wed, Apr 2, 2025 at 10:37 AM Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > > On Wed, Apr 2, 2025 at 4:50 PM Gabriel Shahrouzi <gshahrouzi@gmail.com> wrote: > > > > Replace spaces with tab to comply with kernel coding style. > > Still 'tab'. please, capitalize it to be 'TAB'. Whoops.Completely forgot about this one. I'll have to reread the thread or write it down so I don't forgot in the future. > > But wait a bit, the driver maintainer might do that for you whilst applying. Sounds good. > > -- > With Best Regards, > Andy Shevchenko
On Wed, Apr 02, 2025 at 05:36:31PM +0300, Andy Shevchenko wrote: > On Wed, Apr 2, 2025 at 4:50 PM Gabriel Shahrouzi <gshahrouzi@gmail.com> wrote: > > > > Replace spaces with tab to comply with kernel coding style. > > Still 'tab'. please, capitalize it to be 'TAB'. > > But wait a bit, the driver maintainer might do that for you whilst applying. It's not an acronym so it shouldn't be capitalized. It should be either "a tab" or "tabs". regards, dan carpenter
On Thu, Apr 03, 2025 at 03:36:27PM +0300, Dan Carpenter wrote: > On Wed, Apr 02, 2025 at 05:36:31PM +0300, Andy Shevchenko wrote: > > On Wed, Apr 2, 2025 at 4:50 PM Gabriel Shahrouzi <gshahrouzi@gmail.com> wrote: > > > > > > Replace spaces with tab to comply with kernel coding style. > > > > Still 'tab'. please, capitalize it to be 'TAB'. > > > > But wait a bit, the driver maintainer might do that for you whilst applying. > > It's not an acronym so it shouldn't be capitalized. It should be either > "a tab" or "tabs". Not everything that is capitalised is an acronym :-)
diff --git a/drivers/staging/media/atomisp/pci/isp/kernels/vf/vf_1.0/ia_css_vf.host.c b/drivers/staging/media/atomisp/pci/isp/kernels/vf/vf_1.0/ia_css_vf.host.c index ece5e3da34ee..127f12ba2214 100644 --- a/drivers/staging/media/atomisp/pci/isp/kernels/vf/vf_1.0/ia_css_vf.host.c +++ b/drivers/staging/media/atomisp/pci/isp/kernels/vf/vf_1.0/ia_css_vf.host.c @@ -114,7 +114,7 @@ configure_dma( } int ia_css_vf_configure(const struct ia_css_binary *binary, - const struct ia_css_frame_info *out_info, + const struct ia_css_frame_info *out_info, struct ia_css_frame_info *vf_info, unsigned int *downscale_log2) {
Replace spaces with tab to comply with kernel coding style. Signed-off-by: Gabriel Shahrouzi <gshahrouzi@gmail.com> --- Changes in v2: - Resend using git send-email to fix formatting issues in email body. --- .../media/atomisp/pci/isp/kernels/vf/vf_1.0/ia_css_vf.host.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)