diff mbox series

[07/30] panel/ilitek-ili9341: Use refcounted allocation in place of devm_kzalloc()

Message ID 20250402-b4-drm_panel_mass_convert_part2-v1-7-903b70999ea6@redhat.com (mailing list archive)
State New
Headers show
Series drm/panel: Use refcounted allocation in place of devm_kzalloc() - Part2 | expand

Commit Message

Anusha Srivatsa April 2, 2025, 3:23 p.m. UTC 
Move to using the new API devm_drm_panel_alloc() to allocate the
panel.

Signed-off-by: Anusha Srivatsa <asrivats@redhat.com>
---
 drivers/gpu/drm/panel/panel-ilitek-ili9341.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

Comments

Ondřej Jirman April 2, 2025, 9:09 p.m. UTC | #1 
Hi Anusha,

On Wed, Apr 02, 2025 at 11:23:45AM -0400, Anusha Srivatsa wrote:
> Move to using the new API devm_drm_panel_alloc() to allocate the
> panel.
> 
> Signed-off-by: Anusha Srivatsa <asrivats@redhat.com>
> ---
>  drivers/gpu/drm/panel/panel-ilitek-ili9341.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9341.c b/drivers/gpu/drm/panel/panel-ilitek-ili9341.c
> index ff39f5dd4097e8da0a0e16c50c5bfd45c078d91c..d87b7eefe9beedd290fb59065b389b3315c85720 100644
> --- a/drivers/gpu/drm/panel/panel-ilitek-ili9341.c
> +++ b/drivers/gpu/drm/panel/panel-ilitek-ili9341.c
> @@ -490,9 +490,11 @@ static int ili9341_dpi_probe(struct spi_device *spi, struct gpio_desc *dc,
>  	struct ili9341 *ili;
>  	int ret;
>  
> -	ili = devm_kzalloc(dev, sizeof(struct ili9341), GFP_KERNEL);
> -	if (!ili)
> -		return -ENOMEM;
> +	ili = devm_drm_panel_alloc(dev, struct ili9341, panel,
> +				   &ili9341_dpi_funcs,
> +				   DRM_MODE_CONNECTOR_DPI);
> +	if (IS_ERR(ili))
> +		return PTR_ERR(ili);
>  
>  	ili->dbi = devm_kzalloc(dev, sizeof(struct mipi_dbi),
>  				GFP_KERNEL);

Unlike in other patches, in this one you did not remove:

https://elixir.bootlin.com/linux/v6.13.7/source/drivers/gpu/drm/panel/panel-ilitek-ili9341.c#L529

	drm_panel_init(&ili->panel, dev, &ili9341_dpi_funcs,
		       DRM_MODE_CONNECTOR_DPI);

Unintentional?

kind regards,
	o.

> -- 
> 2.48.1
>
Anusha Srivatsa April 3, 2025, 1:42 p.m. UTC | #2 
On Wed, Apr 2, 2025 at 5:09 PM Ondřej Jirman <megi@xff.cz> wrote:

> Hi Anusha,
>
> On Wed, Apr 02, 2025 at 11:23:45AM -0400, Anusha Srivatsa wrote:
> > Move to using the new API devm_drm_panel_alloc() to allocate the
> > panel.
> >
> > Signed-off-by: Anusha Srivatsa <asrivats@redhat.com>
> > ---
> >  drivers/gpu/drm/panel/panel-ilitek-ili9341.c | 8 +++++---
> >  1 file changed, 5 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9341.c
> b/drivers/gpu/drm/panel/panel-ilitek-ili9341.c
> > index
> ff39f5dd4097e8da0a0e16c50c5bfd45c078d91c..d87b7eefe9beedd290fb59065b389b3315c85720
> 100644
> > --- a/drivers/gpu/drm/panel/panel-ilitek-ili9341.c
> > +++ b/drivers/gpu/drm/panel/panel-ilitek-ili9341.c
> > @@ -490,9 +490,11 @@ static int ili9341_dpi_probe(struct spi_device
> *spi, struct gpio_desc *dc,
> >       struct ili9341 *ili;
> >       int ret;
> >
> > -     ili = devm_kzalloc(dev, sizeof(struct ili9341), GFP_KERNEL);
> > -     if (!ili)
> > -             return -ENOMEM;
> > +     ili = devm_drm_panel_alloc(dev, struct ili9341, panel,
> > +                                &ili9341_dpi_funcs,
> > +                                DRM_MODE_CONNECTOR_DPI);
> > +     if (IS_ERR(ili))
> > +             return PTR_ERR(ili);
> >
> >       ili->dbi = devm_kzalloc(dev, sizeof(struct mipi_dbi),
> >                               GFP_KERNEL);
>
> Unlike in other patches, in this one you did not remove:
>
>
> https://elixir.bootlin.com/linux/v6.13.7/source/drivers/gpu/drm/panel/panel-ilitek-ili9341.c#L529
>
>         drm_panel_init(&ili->panel, dev, &ili9341_dpi_funcs,
>                        DRM_MODE_CONNECTOR_DPI);
>
> Unintentional?
>
> Yup. Unintentional. WIll remove this in the next iteration.

Thanks!
Anusha

> kind regards,
>         o.
>
> > --
> > 2.48.1
> >
>
>
diff mbox series

Patch

diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9341.c b/drivers/gpu/drm/panel/panel-ilitek-ili9341.c
index ff39f5dd4097e8da0a0e16c50c5bfd45c078d91c..d87b7eefe9beedd290fb59065b389b3315c85720 100644
--- a/drivers/gpu/drm/panel/panel-ilitek-ili9341.c
+++ b/drivers/gpu/drm/panel/panel-ilitek-ili9341.c
@@ -490,9 +490,11 @@  static int ili9341_dpi_probe(struct spi_device *spi, struct gpio_desc *dc,
 	struct ili9341 *ili;
 	int ret;
 
-	ili = devm_kzalloc(dev, sizeof(struct ili9341), GFP_KERNEL);
-	if (!ili)
-		return -ENOMEM;
+	ili = devm_drm_panel_alloc(dev, struct ili9341, panel,
+				   &ili9341_dpi_funcs,
+				   DRM_MODE_CONNECTOR_DPI);
+	if (IS_ERR(ili))
+		return PTR_ERR(ili);
 
 	ili->dbi = devm_kzalloc(dev, sizeof(struct mipi_dbi),
 				GFP_KERNEL);