| Message ID | 20250408-ad3552r-fix-bus-read-v1-0-37add66aeb08@baylibre.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | iio: dac: adi-axi-dac: fix for wrong bus read | expand |
On Tue, 2025-04-08 at 22:48 +0200, Angelo Dureghello wrote: > This patchset is intended to fix a random wrong chip ID read, or a > scratchpad test mismatch, tests done in the ad3552r-hs driver probe. The > bus "read" operation must always check for busy flag before reading. > > First patch reorganizes a bit the busy-wait polling code, second patch > fixes the wrong bus read occurence. > > NOTE: due to ongoing changes in adi-axi-dac.c, this patch is intended to be > applied after the linked "ramp generator" patch. > > Link: > https://lore.kernel.org/linux-iio/20250408-wip-bl-ad3552r-fixes-v4-0-b33c0264bd78@baylibre.com > Signed-off-by: Angelo Dureghello <adureghello@baylibre.com> > --- Hi Angelo, patches look good but typically fixes should come first. The reason is that we only want to backport fixes to stable branches and like this we depend on the first patch. So first use the plain regmap_read_poll_timeout() before accessing the bus and then add the helper... - Nuno Sá
This patchset is intended to fix a random wrong chip ID read, or a scratchpad test mismatch, tests done in the ad3552r-hs driver probe. The bus "read" operation must always check for busy flag before reading. First patch reorganizes a bit the busy-wait polling code, second patch fixes the wrong bus read occurence. NOTE: due to ongoing changes in adi-axi-dac.c, this patch is intended to be applied after the linked "ramp generator" patch. Link: https://lore.kernel.org/linux-iio/20250408-wip-bl-ad3552r-fixes-v4-0-b33c0264bd78@baylibre.com Signed-off-by: Angelo Dureghello <adureghello@baylibre.com> --- Angelo Dureghello (2): iio: dac: adi-axi-dac: use unique bus free check iio: dac: adi-axi-dac: fix bus read drivers/iio/dac/adi-axi-dac.c | 40 +++++++++++++++++++++++++--------------- 1 file changed, 25 insertions(+), 15 deletions(-) --- base-commit: 6fb85f14853ddde06d57030c753168402bf69cd9 change-id: 20250408-ad3552r-fix-bus-read-1522622fbd2b Best regards,