| Message ID | 20250410090251.1103979-7-primoz.fiser@norik.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Update PHYTEC i.MX93 DTS | expand |
On Thu, Apr 10, 2025 at 11:02:44AM +0200, Primoz Fiser wrote: > Drop redundant 'no-1-8-v' flag from usdhc1 (eMMC) node. Flag is now set > by default in the SOM include file (imx93-phycore-som.dtsi). > > Signed-off-by: Primoz Fiser <primoz.fiser@norik.com> > --- Reviewed-by: Frank Li <Frank.Li@nxp.com> > arch/arm64/boot/dts/freescale/imx93-phyboard-segin.dts | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/arch/arm64/boot/dts/freescale/imx93-phyboard-segin.dts b/arch/arm64/boot/dts/freescale/imx93-phyboard-segin.dts > index 85fb188b057f..902b523fc92c 100644 > --- a/arch/arm64/boot/dts/freescale/imx93-phyboard-segin.dts > +++ b/arch/arm64/boot/dts/freescale/imx93-phyboard-segin.dts > @@ -40,11 +40,6 @@ &lpuart1 { > status = "okay"; > }; > > -/* eMMC */ > -&usdhc1 { > - no-1-8-v; > -}; > - > /* SD-Card */ > &usdhc2 { > pinctrl-names = "default", "state_100mhz", "state_200mhz"; > -- > 2.34.1 >
Hi Primoz, Am 10.04.25 um 11:02 schrieb Primoz Fiser: > Drop redundant 'no-1-8-v' flag from usdhc1 (eMMC) node. Flag is now set > by default in the SOM include file (imx93-phycore-som.dtsi). > > Signed-off-by: Primoz Fiser <primoz.fiser@norik.com> i think, Patch 5 and this one should be squashed together. Regards > --- > arch/arm64/boot/dts/freescale/imx93-phyboard-segin.dts | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/arch/arm64/boot/dts/freescale/imx93-phyboard-segin.dts b/arch/arm64/boot/dts/freescale/imx93-phyboard-segin.dts > index 85fb188b057f..902b523fc92c 100644 > --- a/arch/arm64/boot/dts/freescale/imx93-phyboard-segin.dts > +++ b/arch/arm64/boot/dts/freescale/imx93-phyboard-segin.dts > @@ -40,11 +40,6 @@ &lpuart1 { > status = "okay"; > }; > > -/* eMMC */ > -&usdhc1 { > - no-1-8-v; > -}; > - > /* SD-Card */ > &usdhc2 { > pinctrl-names = "default", "state_100mhz", "state_200mhz";
Hi Stefan, On 12. 04. 25 18:23, Stefan Wahren wrote: > Hi Primoz, > > Am 10.04.25 um 11:02 schrieb Primoz Fiser: >> Drop redundant 'no-1-8-v' flag from usdhc1 (eMMC) node. Flag is now set >> by default in the SOM include file (imx93-phycore-som.dtsi). >> >> Signed-off-by: Primoz Fiser <primoz.fiser@norik.com> > i think, Patch 5 and this one should be squashed together. I intentionally split these series into SoM and board related patches. I see no benefit in squashing #5 and #6. Also, I already got Frank's Reviewed-by tag on this patch. Thus I would like to keep them separate as is. Thanks, BR, Primoz > > Regards >> --- >> arch/arm64/boot/dts/freescale/imx93-phyboard-segin.dts | 5 ----- >> 1 file changed, 5 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/freescale/imx93-phyboard-segin.dts >> b/arch/arm64/boot/dts/freescale/imx93-phyboard-segin.dts >> index 85fb188b057f..902b523fc92c 100644 >> --- a/arch/arm64/boot/dts/freescale/imx93-phyboard-segin.dts >> +++ b/arch/arm64/boot/dts/freescale/imx93-phyboard-segin.dts >> @@ -40,11 +40,6 @@ &lpuart1 { >> status = "okay"; >> }; >> >> -/* eMMC */ >> -&usdhc1 { >> - no-1-8-v; >> -}; >> - >> /* SD-Card */ >> &usdhc2 { >> pinctrl-names = "default", "state_100mhz", "state_200mhz"; >
Hi Primoz, Am 14.04.25 um 12:39 schrieb Primoz Fiser: > Hi Stefan, > > On 12. 04. 25 18:23, Stefan Wahren wrote: >> Hi Primoz, >> >> Am 10.04.25 um 11:02 schrieb Primoz Fiser: >>> Drop redundant 'no-1-8-v' flag from usdhc1 (eMMC) node. Flag is now set >>> by default in the SOM include file (imx93-phycore-som.dtsi). >>> >>> Signed-off-by: Primoz Fiser <primoz.fiser@norik.com> >> i think, Patch 5 and this one should be squashed together. > I intentionally split these series into SoM and board related patches. > > I see no benefit in squashing #5 and #6. From my understanding both changes belong together, because you actually moved the property from board to SoM level. Otherwise in case there is something wrong later, both patches need to be reverted. > Also, I already got Frank's Reviewed-by tag on this patch. This wouldn't invalidate Frank's review. Just my two cents
diff --git a/arch/arm64/boot/dts/freescale/imx93-phyboard-segin.dts b/arch/arm64/boot/dts/freescale/imx93-phyboard-segin.dts index 85fb188b057f..902b523fc92c 100644 --- a/arch/arm64/boot/dts/freescale/imx93-phyboard-segin.dts +++ b/arch/arm64/boot/dts/freescale/imx93-phyboard-segin.dts @@ -40,11 +40,6 @@ &lpuart1 { status = "okay"; }; -/* eMMC */ -&usdhc1 { - no-1-8-v; -}; - /* SD-Card */ &usdhc2 { pinctrl-names = "default", "state_100mhz", "state_200mhz";
Drop redundant 'no-1-8-v' flag from usdhc1 (eMMC) node. Flag is now set by default in the SOM include file (imx93-phycore-som.dtsi). Signed-off-by: Primoz Fiser <primoz.fiser@norik.com> --- arch/arm64/boot/dts/freescale/imx93-phyboard-segin.dts | 5 ----- 1 file changed, 5 deletions(-)