[v2,net-next,0/4] net: stmmac: anarion: cleanups

Message

Russell King (Oracle) April 14, 2025, 9:05 a.m. UTC

A series of cleanups to the anarion glue driver.

Clean up anarion_config_dt() error handling, printing a human readable
error rather than the numeric errno, and use ERR_CAST().

Using a switch statement with incorrect "fallthrough;" for RGMII vs
non-RGMII is unnecessary when we have phy_interface_mode_is_rgmii().
Convert to use the helper.

Use stmmac_pltfr_probe() rahter than open-coding the call to the
init function (which stmmac_pltfr_probe() will do for us.)

Finally, convert to use devm_stmmac_pltfr_probe() which allows the
removal of the .remove initialiser in the driver structure.

Not tested on hardware.

v2: fix build error, add Andrew's r-bs.

 .../net/ethernet/stmicro/stmmac/dwmac-anarion.c    | 25 +++++++---------------
 1 file changed, 8 insertions(+), 17 deletions(-)

Comments

[e-mail] April 15, 2025, 3:40 p.m. UTC | #1

Hello:

This series was applied to netdev/net-next.git (main)
by Jakub Kicinski <[e-mail]>:

On Mon, 14 Apr 2025 10:05:56 +0100 you wrote:
> A series of cleanups to the anarion glue driver.
> 
> Clean up anarion_config_dt() error handling, printing a human readable
> error rather than the numeric errno, and use ERR_CAST().
> 
> Using a switch statement with incorrect "fallthrough;" for RGMII vs
> non-RGMII is unnecessary when we have phy_interface_mode_is_rgmii().
> Convert to use the helper.
> 
> [...]

Here is the summary with links:
  - [net-next,v2,1/4] net: stmmac: anarion: clean up anarion_config_dt() error handling
    https://git.kernel.org/netdev/net-next/c/c30a45a7e072
  - [net-next,v2,2/4] net: stmmac: anarion: clean up interface parsing
    https://git.kernel.org/netdev/net-next/c/a55ec9c811aa
  - [net-next,v2,3/4] net: stmmac: anarion: use stmmac_pltfr_probe()
    https://git.kernel.org/netdev/net-next/c/5956527e26ff
  - [net-next,v2,4/4] net: stmmac: anarion: use devm_stmmac_pltfr_probe()
    https://git.kernel.org/netdev/net-next/c/a1afabef915c

You are awesome, thank you!