| Message ID | 20250415130458.33714-1-d.haller@phytec.de (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [v2,1/3] dt-bindings: arm: ti: Add bindings for PHYTEC AM68x based hardware | expand |
On Tue, Apr 15, 2025 at 03:04:56PM +0200, Dominik Haller wrote: > Add devicetree bindings for the AM68x based phyCORE-AM68x/TDA4x SoM > and the phyBOARD-Izar carrier board. > > Signed-off-by: Dominik Haller <d.haller@phytec.de> > --- > > Notes: > Changes in v2: > - no changes > > Documentation/devicetree/bindings/arm/ti/k3.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/ti/k3.yaml b/Documentation/devicetree/bindings/arm/ti/k3.yaml > index 18f155cd06c8..a03fdb9c0482 100644 > --- a/Documentation/devicetree/bindings/arm/ti/k3.yaml > +++ b/Documentation/devicetree/bindings/arm/ti/k3.yaml > @@ -135,6 +135,8 @@ properties: > - description: K3 J721s2 SoC > items: > - enum: > + - phytec,am68-phyboard-izar > + - phytec,am68-phycore-som This looks wrong, if I am not misunderstanding. Your izar dts includes the som dtsi, so this should be configured with a fallback, so you're going "phytec,am68-phyboard-izar", "phytec,am68-phycore-som", "ti,j721s2", no? > - ti,am68-sk > - ti,j721s2-evm > - const: ti,j721s2 > -- > 2.43.0 >
On Tue, 2025-04-15 at 17:09 +0100, Conor Dooley wrote: > On Tue, Apr 15, 2025 at 03:04:56PM +0200, Dominik Haller wrote: > > Add devicetree bindings for the AM68x based phyCORE-AM68x/TDA4x SoM > > and the phyBOARD-Izar carrier board. > > > > Signed-off-by: Dominik Haller <d.haller@phytec.de> > > --- > > > > Notes: > > Changes in v2: > > - no changes > > > > Documentation/devicetree/bindings/arm/ti/k3.yaml | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/arm/ti/k3.yaml > > b/Documentation/devicetree/bindings/arm/ti/k3.yaml > > index 18f155cd06c8..a03fdb9c0482 100644 > > --- a/Documentation/devicetree/bindings/arm/ti/k3.yaml > > +++ b/Documentation/devicetree/bindings/arm/ti/k3.yaml > > @@ -135,6 +135,8 @@ properties: > > - description: K3 J721s2 SoC > > items: > > - enum: > > + - phytec,am68-phyboard-izar > > + - phytec,am68-phycore-som > > This looks wrong, if I am not misunderstanding. Your izar dts > includes > the som dtsi, so this should be configured with a fallback, so you're > going "phytec,am68-phyboard-izar", "phytec,am68-phycore-som", > "ti,j721s2", > no? The compatibles are "phytec,am68-phyboard-izar", "ti,j721s2"; in the dts and "phytec,am68-phycore-som", "ti,j721s2"; in the dtsi now. So when I add the phytec,am68-phycore-som comaptible to the dts I'll move my bindings into an own entry and use a second const for the som: - description: K3 J721S2 SoC Phytec SoM based boards items: - enum: - phytec,am68-phyboard-izar - const: phytec,am68-phycore-som - const: ti,j721s2 > > > - ti,am68-sk > > - ti,j721s2-evm > > - const: ti,j721s2 > > -- > > 2.43.0 > >
On Wed, Apr 16, 2025 at 12:25:36PM +0000, Dominik Haller wrote: > On Tue, 2025-04-15 at 17:09 +0100, Conor Dooley wrote: > > On Tue, Apr 15, 2025 at 03:04:56PM +0200, Dominik Haller wrote: > > > Add devicetree bindings for the AM68x based phyCORE-AM68x/TDA4x SoM > > > and the phyBOARD-Izar carrier board. > > > > > > Signed-off-by: Dominik Haller <d.haller@phytec.de> > > > --- > > > > > > Notes: > > > Changes in v2: > > > - no changes > > > > > > Documentation/devicetree/bindings/arm/ti/k3.yaml | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/arm/ti/k3.yaml > > > b/Documentation/devicetree/bindings/arm/ti/k3.yaml > > > index 18f155cd06c8..a03fdb9c0482 100644 > > > --- a/Documentation/devicetree/bindings/arm/ti/k3.yaml > > > +++ b/Documentation/devicetree/bindings/arm/ti/k3.yaml > > > @@ -135,6 +135,8 @@ properties: > > > - description: K3 J721s2 SoC > > > items: > > > - enum: > > > + - phytec,am68-phyboard-izar > > > + - phytec,am68-phycore-som > > > > This looks wrong, if I am not misunderstanding. Your izar dts > > includes > > the som dtsi, so this should be configured with a fallback, so you're > > going "phytec,am68-phyboard-izar", "phytec,am68-phycore-som", > > "ti,j721s2", > > no? > The compatibles are "phytec,am68-phyboard-izar", "ti,j721s2"; in the > dts and "phytec,am68-phycore-som", "ti,j721s2"; in the dtsi now. > > So when I add the phytec,am68-phycore-som comaptible to the dts I'll > move my bindings into an own entry and use a second const for the som: > > - description: K3 J721S2 SoC Phytec SoM based boards > items: > - enum: > - phytec,am68-phyboard-izar > - const: phytec,am68-phycore-som > - const: ti,j721s2 This looks more like what I'd expect, ye.
diff --git a/Documentation/devicetree/bindings/arm/ti/k3.yaml b/Documentation/devicetree/bindings/arm/ti/k3.yaml index 18f155cd06c8..a03fdb9c0482 100644 --- a/Documentation/devicetree/bindings/arm/ti/k3.yaml +++ b/Documentation/devicetree/bindings/arm/ti/k3.yaml @@ -135,6 +135,8 @@ properties: - description: K3 J721s2 SoC items: - enum: + - phytec,am68-phyboard-izar + - phytec,am68-phycore-som - ti,am68-sk - ti,j721s2-evm - const: ti,j721s2
Add devicetree bindings for the AM68x based phyCORE-AM68x/TDA4x SoM and the phyBOARD-Izar carrier board. Signed-off-by: Dominik Haller <d.haller@phytec.de> --- Notes: Changes in v2: - no changes Documentation/devicetree/bindings/arm/ti/k3.yaml | 2 ++ 1 file changed, 2 insertions(+)