| Message ID | 20250417053909.1051416-11-amakhija@qti.qualcomm.com (mailing list archive) |
|---|---|
| State | Handled Elsewhere |
| Headers | show |
| Series | Add DSI display support for SA8775P target | expand |
On Thu, Apr 17, 2025 at 11:09:08AM +0530, Ayushi Makhija wrote: > From: Ayushi Makhija <quic_amakhija@quicinc.com> > > In the anx7625_sink_detect(), the device is checked to see > if it is a panel bridge, and it always sends a "connected" > status to the connector. When adding the DP port on port 1 of the > anx7625, it incorrectly treats it as a panel bridge and sends an > always "connected" status. Instead of checking the status on the > panel bridge, it's better to check the hpd_status for connectors > that supports hot-plugging. This way, it verifies the hpd_status > variable before sending the status to the connector. Does this work if the Analogix bridge is connected to an eDP panel? In such a case it should report 'connected' even before powering up the panel (which might mean HPD pin being low). > > Signed-off-by: Ayushi Makhija <quic_amakhija@quicinc.com> > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> > --- > drivers/gpu/drm/bridge/analogix/anx7625.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c > index a32ebe1fa0cd..365d1c871028 100644 > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c > @@ -1814,9 +1814,6 @@ static enum drm_connector_status anx7625_sink_detect(struct anx7625_data *ctx) > > DRM_DEV_DEBUG_DRIVER(dev, "sink detect\n"); > > - if (ctx->pdata.panel_bridge) > - return connector_status_connected; > - > return ctx->hpd_status ? connector_status_connected : > connector_status_disconnected; > } > -- > 2.34.1 >
diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c index a32ebe1fa0cd..365d1c871028 100644 --- a/drivers/gpu/drm/bridge/analogix/anx7625.c +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c @@ -1814,9 +1814,6 @@ static enum drm_connector_status anx7625_sink_detect(struct anx7625_data *ctx) DRM_DEV_DEBUG_DRIVER(dev, "sink detect\n"); - if (ctx->pdata.panel_bridge) - return connector_status_connected; - return ctx->hpd_status ? connector_status_connected : connector_status_disconnected; }